[Lldb-commits] [PATCH] D49410: [PDB] Parse UDT symbols and pointers to members

Hui added inline comments. Comment at: source/Plugins/SymbolFile/PDB/PDBASTParser.cpp:647-648 +auto member_ast_type = type_sp->GetLayoutCompilerType(); +if (!member_ast_type.IsCompleteType()) + member_ast_type.GetCompleteType(); +// CXX class type

[Lldb-commits] [PATCH] D49410: [PDB] Parse UDT symbols and pointers to members

Hui added inline comments. Comment at: source/Plugins/SymbolFile/PDB/PDBASTParser.cpp:271-272 +AccessType access = TranslateMemberAccess(udt->getAccess()); +if (access == lldb::eAccessNone && udt->isNested() && +udt->getClassParent()) { + access = GetDefaultA

[Lldb-commits] [PATCH] D49410: [PDB] Parse UDT symbols and pointers to members

Hui added inline comments. Comment at: source/Plugins/SymbolFile/PDB/PDBASTParser.cpp:246 +return ty ? ty->shared_from_this() : nullptr; + } break; case PDB_SymType::UDT: { zturner wrote: > This looks unusual. Did you clang-format it? Just tried clang-fo

[Lldb-commits] [PATCH] D49410: [PDB] Parse UDT symbols and pointers to members

Hui added inline comments. Comment at: source/Plugins/SymbolFile/PDB/SymbolFilePDB.cpp:588 +if (result->GetID() == type_uid) { + pdb->CompleteRecordTypeForPDBSymbol(*pdb_type, result); +} aleksandr.urakov wrote: > What are the advantages and disadvan

[Lldb-commits] [PATCH] D49410: [PDB] Parse UDT symbols and pointers to members

Hui added inline comments. Comment at: source/Plugins/SymbolFile/PDB/PDBASTParser.cpp:696 + base_ast_type.GetOpaqueQualType(), access, + pdb_base_class->isVirtualBaseClass(), /*base_of_class*/ true); + base_classes.push_back(base_spec); ale

[Lldb-commits] [PATCH] D49410: [PDB] Parse UDT symbols and pointers to members

Hui added inline comments. Comment at: source/Plugins/SymbolFile/PDB/SymbolFilePDB.cpp:587 +// only do this once. +if (result->GetID() == type_uid) { + pdb->CompleteRecordTypeForPDBSymbol(*pdb_type, result); aleksandr.urakov wrote: > I don't fully un

[Lldb-commits] [PATCH] D49018: Convert a location information from PDB to a DWARF expression

stella.stamenova added a comment. Can you test this change and send it for review? Thanks! Repository: rL LLVM https://reviews.llvm.org/D49018 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinf

[Lldb-commits] [PATCH] D49475: Fix variables.test after D49018

aleksandr.urakov added a comment. Thanks! Repository: rL LLVM https://reviews.llvm.org/D49475 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D49410: [PDB] Parse UDT symbols and pointers to members

Not at all. > On Jul 18, 2018, at 8:27 AM, Aleksandr Urakov via Phabricator > wrote: > > aleksandr.urakov added a comment. > > Don't you mind if I try to combine this with https://reviews.llvm.org/D49368? > To avoid doing the work twice. > > > https://reviews.llvm.org/D49410 > > > _

[Lldb-commits] [PATCH] D49475: Fix variables.test after D49018

This revision was automatically updated to reflect the committed changes. Closed by commit rL337397: Fix variables.test after D49018 (authored by stella.stamenova, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D49475?vs=156049&id=1560

[Lldb-commits] [lldb] r337397 - Fix variables.test after D49018

Author: stella.stamenova Date: Wed Jul 18 08:50:24 2018 New Revision: 337397 URL: http://llvm.org/viewvc/llvm-project?rev=337397&view=rev Log: Fix variables.test after D49018 Summary: This one fixes variables.test after D49018. The test was broken because D49018 adds a location information to va

[Lldb-commits] [PATCH] D49410: [PDB] Parse UDT symbols and pointers to members

aleksandr.urakov added a comment. Don't you mind if I try to combine this with https://reviews.llvm.org/D49368? To avoid doing the work twice. https://reviews.llvm.org/D49410 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.ll

[Lldb-commits] [lldb] r337395 - [windows] Use a well-known path for ComSpec if we fail to retrieve it

Author: stella.stamenova Date: Wed Jul 18 08:21:54 2018 New Revision: 337395 URL: http://llvm.org/viewvc/llvm-project?rev=337395&view=rev Log: [windows] Use a well-known path for ComSpec if we fail to retrieve it Summary: Right now we always try to retrieve ComSpec and if we fail, we give up. Th

[Lldb-commits] [PATCH] D49410: [PDB] Parse UDT symbols and pointers to members

aleksandr.urakov added inline comments. Comment at: source/Plugins/SymbolFile/PDB/PDBASTParser.cpp:291-295 +if (udt->isConstType()) + clang_type = clang_type.AddConstModifier(); + +if (udt->isVolatileType()) + clang_type = clang_type.AddVolatileModifier(); -

[Lldb-commits] [lldb] r337393 - [lit, lldbsuite] Remove tests that are duplicated between lit and lldb-suite

Author: stella.stamenova Date: Wed Jul 18 08:16:54 2018 New Revision: 337393 URL: http://llvm.org/viewvc/llvm-project?rev=337393&view=rev Log: [lit, lldbsuite] Remove tests that are duplicated between lit and lldb-suite Summary: Several tests exist in both lit and lldbsuite. This removes the lit

[Lldb-commits] [PATCH] D49475: Fix variables.test after D49018

aleksandr.urakov added a comment. Can you commit this for me, please? I have no commit access. https://reviews.llvm.org/D49475 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D48782: LLDB Test Suite: Provide an Option to run all tests with Dwarf Package Format (DWP).

jankratochvil requested changes to this revision. jankratochvil added inline comments. This revision now requires changes to proceed. Comment at: packages/Python/lldbsuite/test/make/Makefile.rules:238 +ifneq (,$(wildcard $(DWP))) + MAKE_DWP=YES I was thinking

[Lldb-commits] [PATCH] D49475: Fix variables.test after D49018

aleksandr.urakov created this revision. aleksandr.urakov added reviewers: stella.stamenova, lldb-commits. This one fixes variables.test after https://reviews.llvm.org/D49018. The test was broken because https://reviews.llvm.org/D49018 adds a location information to variables, but I hadn't notice

[Lldb-commits] [PATCH] D49435: Added unit tests for Flags

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. lgtm. Thanks. Comment at: unittests/Utility/CMakeLists.txt:10-11 EnvironmentTest.cpp + FlagsTest.cpp FileSpecTest.cpp JSONTest.cpp Please keep this

[Lldb-commits] [PATCH] D49415: Add unit tests for VMRange

labath added a comment. In https://reviews.llvm.org/D49415#1165179, @teemperor wrote: > - Added a PrintTo function as otherwise the gtest comparison macros won't > compile. Sorry, I did not anticipate that. It looks like the `iterator` typedef inside the VMRange is confusing gtest's universal