[Lldb-commits] [PATCH] D49334: Added syntax highlighting support

teemperor added a comment. Also: This patch doesn't answer the question how the user will be able to configure the specific colors used for each token (i.e. there is only one style available at the moment). The reason for this is that there seems to be a lot of opinions about whether we want to

[Lldb-commits] [PATCH] D49334: Added syntax highlighting support

teemperor created this revision. Herald added a subscriber: mgorny. This patch adds syntax highlighting support to LLDB. When enabled (and lldb is allowed to use colors), printed source code is annotated with the ANSI color escape sequences. So far we have only one highlighter which is based on

[Lldb-commits] [PATCH] D48802: [lldb-mi] Re-implement symbol-list-lines command.

stella.stamenova added a comment. Thank you! Repository: rL LLVM https://reviews.llvm.org/D48802 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D48802: [lldb-mi] Re-implement symbol-list-lines command.

apolyakov added a comment. @stella.stamenova Done in r337064. Repository: rL LLVM https://reviews.llvm.org/D48802 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D49062: [lldb-mi] Re-implement data-info-line command.

apolyakov added a comment. It would be good to convert to LIT as more tests as we can. I'll do this in one of a next patches. Let's continue with this one? https://reviews.llvm.org/D49062 ___ lldb-commits mailing list lldb-commits@lists.llvm.org ht

[Lldb-commits] [lldb] r337064 - [lldb-mi] Make symbol-list-lines.test XFAIL on Windows

Author: apolyakov Date: Fri Jul 13 15:41:16 2018 New Revision: 337064 URL: http://llvm.org/viewvc/llvm-project?rev=337064&view=rev Log: [lldb-mi] Make symbol-list-lines.test XFAIL on Windows It's a temporary decision until we reach out what causes a failure. Modified: lldb/trunk/lit/tools/ll

[Lldb-commits] [lldb] r337063 - Fix -Wswitch after introduction of clang; :Type::DependentVector in r337036

Author: maskray Date: Fri Jul 13 15:40:40 2018 New Revision: 337063 URL: http://llvm.org/viewvc/llvm-project?rev=337063&view=rev Log: Fix -Wswitch after introduction of clang;:Type::DependentVector in r337036 Modified: lldb/trunk/source/Symbol/ClangASTContext.cpp Modified: lldb/trunk/source/

[Lldb-commits] [lldb] r337058 - Make these tests c++ tests so they can be skipped on systems that don't support those tests.

Author: jingham Date: Fri Jul 13 15:31:59 2018 New Revision: 337058 URL: http://llvm.org/viewvc/llvm-project?rev=337058&view=rev Log: Make these tests c++ tests so they can be skipped on systems that don't support those tests. Modified: lldb/trunk/packages/Python/lldbsuite/test/functionalit

[Lldb-commits] [PATCH] D49322: Narrow the CompletionRequest API to being append-only.

teemperor updated this revision to Diff 155515. teemperor added a comment. - Removed some small string allocations. https://reviews.llvm.org/D49322 Files: include/lldb/Utility/CompletionRequest.h source/Commands/CommandCompletions.cpp source/Commands/CommandObjectCommands.cpp source/Com

[Lldb-commits] [PATCH] D49271: Adding libc++ formattors for std::optional

davide added a comment. This is getting really close. Please try the `lldbInline` test format and revert the unrelated bits and I'll take another look. Thanks! Comment at: source/Plugins/Language/CPlusPlus/CPlusPlusLanguage.cpp:971-972 g_formatters.push_back([](lldb_priv

[Lldb-commits] [PATCH] D49271: Adding libc++ formattors for std::optional

shafik added a comment. @davide @jingham Thank you for the review, those were good catches and comments. I have addressed them except for refactoring the test to use lldbInline which I will be working on now. Comment at: packages/Python/lldbsuite/test/functionalities/data-fo

[Lldb-commits] [PATCH] D49271: Adding libc++ formattors for std::optional

shafik updated this revision to Diff 155508. shafik marked 7 inline comments as done. shafik edited the summary of this revision. shafik added a comment. Address comments - Applying clang-formt - Refactoring OptionalFrontEnd to produce out that makes the underlying data look like an array - Remo

[Lldb-commits] [PATCH] D49322: Narrow the CompletionRequest API to being append-only.

teemperor created this revision. teemperor added a reviewer: jingham. We currently allow any completion handler to read and manipulate the list of matches we calculated so far. This leads to a few problems: Firstly, a completion handler's logic can now depend on previously calculated results by

[Lldb-commits] [PATCH] D48802: [lldb-mi] Re-implement symbol-list-lines command.

apolyakov added a comment. In https://reviews.llvm.org/D48802#1161904, @stella.stamenova wrote: > @apolyakov Perhaps we can mark the test as XFAIL on Windows while you > investigate. Any objections? Sure, I'll do it. Repository: rL LLVM https://reviews.llvm.org/D48802 _

[Lldb-commits] [PATCH] D49309: No longer pass a StringRef to the Python API

stella.stamenova added a comment. All better now! Tests are passing. Repository: rL LLVM https://reviews.llvm.org/D49309 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D49282: [cmake] Add option to skip building lldb-server

xiaobai updated this revision to Diff 155459. xiaobai added a comment. Update unittest logic. https://reviews.llvm.org/D49282 Files: cmake/modules/LLDBConfig.cmake tools/CMakeLists.txt unittests/tools/CMakeLists.txt Index: unittests/tools/CMakeLists.txt =

[Lldb-commits] [lldb] r337035 - Fix the libcxx set, multiset, vector and bitset formatters to work on references.

Author: jingham Date: Fri Jul 13 12:28:32 2018 New Revision: 337035 URL: http://llvm.org/viewvc/llvm-project?rev=337035&view=rev Log: Fix the libcxx set, multiset, vector and bitset formatters to work on references. The synthetic child providers for these classes had a type expression that matc

[Lldb-commits] [lldb] r337034 - Add the new PDBLocationToDWARFExpression.{cpp, h} to the Xcode project.

Author: jingham Date: Fri Jul 13 12:24:26 2018 New Revision: 337034 URL: http://llvm.org/viewvc/llvm-project?rev=337034&view=rev Log: Add the new PDBLocationToDWARFExpression.{cpp,h} to the Xcode project. Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj Modified: lldb/trunk/lldb.xcodeproj

[Lldb-commits] [PATCH] D48782: LLDB Test Suite: Provide an Option to run all tests with Dwarf Package Format (DWP).

plotfi added a comment. > What's the medium-to-long term solution? Havn't fully fleshed that out yet. Comment at: packages/Python/lldbsuite/test/make/Makefile.rules:520 $(EXE) : $(OBJECTS) $(ARCHIVE_NAME) $(DYLIB_FILENAME) $(LD) $(OBJECTS) $(ARCHIVE_NAME) -L. -l$(DY

[Lldb-commits] [PATCH] D48782: LLDB Test Suite: Provide an Option to run all tests with Dwarf Package Format (DWP).

plotfi updated this revision to Diff 155452. https://reviews.llvm.org/D48782 Files: packages/Python/lldbsuite/test/make/Makefile.rules Index: packages/Python/lldbsuite/test/make/Makefile.rules === --- packages/Python/lldbsuite/te

[Lldb-commits] [PATCH] D49311: Add includes for CompletionRequest to every file that uses it

This revision was automatically updated to reflect the committed changes. Closed by commit rL337032: Add includes for CompletionRequest to every file that uses it (authored by teemperor, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D

[Lldb-commits] [lldb] r337032 - Add includes for CompletionRequest to every file that uses it

Author: teemperor Date: Fri Jul 13 11:54:55 2018 New Revision: 337032 URL: http://llvm.org/viewvc/llvm-project?rev=337032&view=rev Log: Add includes for CompletionRequest to every file that uses it Summary: Should fix the builds (and prevent future builds from failing when people try to reduce i

[Lldb-commits] [PATCH] D49311: Add includes for CompletionRequest to every file that uses it

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. That works for me, thanks for fixing this. https://reviews.llvm.org/D49311 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lis

[Lldb-commits] [PATCH] D49311: Add includes for CompletionRequest to every file that uses it

teemperor created this revision. Should fix the builds (and prevent future builds from failing when people try to reduce includes). https://reviews.llvm.org/D49311 Files: include/lldb/Interpreter/CommandAlias.h include/lldb/Interpreter/CommandInterpreter.h include/lldb/Interpreter/Comman

[Lldb-commits] [PATCH] D48976: Replaced more boilerplate code with CompletionRequest (NFC)

This revision was automatically updated to reflect the committed changes. Closed by commit rL337031: Replaced more boilerplate code with CompletionRequest (NFC) (authored by teemperor, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D48

[Lldb-commits] [lldb] r337031 - Replaced more boilerplate code with CompletionRequest (NFC)

Author: teemperor Date: Fri Jul 13 11:28:14 2018 New Revision: 337031 URL: http://llvm.org/viewvc/llvm-project?rev=337031&view=rev Log: Replaced more boilerplate code with CompletionRequest (NFC) Summary: As suggested in D48796, this patch replaces even more internal calls that were using the ol

[Lldb-commits] [PATCH] D49309: No longer pass a StringRef to the Python API

This revision was automatically updated to reflect the committed changes. Closed by commit rL337030: No longer pass a StringRef to the Python API (authored by teemperor, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D49309?vs=155434&i

[Lldb-commits] [lldb] r337030 - No longer pass a StringRef to the Python API

Author: teemperor Date: Fri Jul 13 11:13:46 2018 New Revision: 337030 URL: http://llvm.org/viewvc/llvm-project?rev=337030&view=rev Log: No longer pass a StringRef to the Python API Summary: The refactoring patch for DoExecute missed this case of a variadic function that just silently accepts a S

[Lldb-commits] [PATCH] D48976: Replaced more boilerplate code with CompletionRequest (NFC)

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. Oops, sorry for the delay. This is so much easier to read. Thanks for cleaning this up! https://reviews.llvm.org/D48976 ___ lldb-commits mai

[Lldb-commits] [PATCH] D49309: No longer pass a StringRef to the Python API

teemperor added a comment. @stella.stamenova I believe this fixes the issue. Thanks for finding this! https://reviews.llvm.org/D49309 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commi

[Lldb-commits] [PATCH] D49309: No longer pass a StringRef to the Python API

teemperor created this revision. teemperor added a reviewer: stella.stamenova. The refactoring patch for DoExecute missed this case of a variadic function that just silently accepts a StringRef which it then tries to reinterpret as a C-string. This should fix the Windows builds. https://review

[Lldb-commits] [lldb] r337029 - Fix TestAttachDenied on macOS Mojave

Author: friss Date: Fri Jul 13 10:45:43 2018 New Revision: 337029 URL: http://llvm.org/viewvc/llvm-project?rev=337029&view=rev Log: Fix TestAttachDenied on macOS Mojave TestAttachDenied tries to attach to a process that is ptracing itself and verifies that we error out. Starting with macOS Mojave

[Lldb-commits] [PATCH] D49207: Get rid of the C-string parameter in DoExecute

teemperor added a comment. Sorry, I think I know why this is happening. Give me a bit to make a patch. Repository: rL LLVM https://reviews.llvm.org/D49207 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mai

[Lldb-commits] [PATCH] D48802: [lldb-mi] Re-implement symbol-list-lines command.

stella.stamenova added a comment. @apolyakov Perhaps we can mark the test as XFAIL on Windows while you investigate. Any objections? Repository: rL LLVM https://reviews.llvm.org/D48802 ___ lldb-commits mailing list lldb-commits@lists.llvm.org ht

Re: [Lldb-commits] [lldb] r336991 - Add abbreviated name for Debugger::EventHandlerThread.

There's code in the ThreadHandler to handle systems with short thread names. If that isn't producing readable names, we should fix it there. A better algorithm might be to drop the leading "lldb" and then instead of truncating drop vowels (maybe leaving the first vowel after a .) So you'd get

[Lldb-commits] [PATCH] D49207: Get rid of the C-string parameter in DoExecute

stella.stamenova added a comment. I am debugging through it right now, but I believe this change caused several tests on Windows with Python 3 to fail. The failures are all related to UTF-8. For example: UnicodeDecodeError: 'utf-8' codec can't decode byte 0x80 in position 0: invalid start by

[Lldb-commits] [PATCH] D49307: Fix some crashes and deadlocks in FormatAnsiTerminalCodes

teemperor created this revision. teemperor added a reviewer: davide. Herald added a subscriber: mgorny. This patch fixes a few problems with the FormatAnsiTerminalCodes function: - It does an infinite loop on an unknown color value. - It crashes when the color value is at the end of the string. -

[Lldb-commits] [PATCH] D48976: Replaced more boilerplate code with CompletionRequest (NFC)

teemperor added a comment. ping https://reviews.llvm.org/D48976 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D49018: Convert a location information from PDB to a DWARF expression

stella.stamenova added a comment. I am not 100% sure that this is the cause yet, but the test variables.test is now failing on Windows. @aleksandr.urakov and @JDevlieghere, which tests did you run on Windows? Did they all pass? Repository: rL LLVM https://reviews.llvm.org/D49018

[Lldb-commits] [lldb] r336993 - Adjust thread name column width depending on real name length.

Author: tkrasnukha Date: Fri Jul 13 04:49:28 2018 New Revision: 336993 URL: http://llvm.org/viewvc/llvm-project?rev=336993&view=rev Log: Adjust thread name column width depending on real name length. Make 16-byte aligned field instead of truncating a name to 16 byte. Modified: lldb/trunk/sou

[Lldb-commits] [lldb] r336991 - Add abbreviated name for Debugger::EventHandlerThread.

Author: tkrasnukha Date: Fri Jul 13 04:21:06 2018 New Revision: 336991 URL: http://llvm.org/viewvc/llvm-project?rev=336991&view=rev Log: Add abbreviated name for Debugger::EventHandlerThread. On OS's where thread names are limited to 16 bytes, the full name was truncated to not very meaningful "

[Lldb-commits] [PATCH] D49018: Convert a location information from PDB to a DWARF expression

aleksandr.urakov added a comment. Thank you! Repository: rL LLVM https://reviews.llvm.org/D49018 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D49018: Convert a location information from PDB to a DWARF expression

This revision was automatically updated to reflect the committed changes. Closed by commit rL336988: Convert a location information from PDB to a DWARF expression (authored by JDevlieghere, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.or

[Lldb-commits] [lldb] r336988 - Convert a location information from PDB to a DWARF expression

Author: jdevlieghere Date: Fri Jul 13 03:29:27 2018 New Revision: 336988 URL: http://llvm.org/viewvc/llvm-project?rev=336988&view=rev Log: Convert a location information from PDB to a DWARF expression The current version of SymbolFilePDB::ParseVariableForPDBData function always initializes variab

Re: [Lldb-commits] [PATCH] D48865: [LLDB] CommandObjectThreadUntil::DoExecute() sets the wrong selected thread ID

Jim, I do not have the commit access to LLDB. Could you please commit this patch? - Venkata Ramanaiah On Thu, Jul 12, 2018 at 10:46 PM, Jim Ingham via Phabricator < revi...@reviews.llvm.org> wrote: > jingham accepted this revision. > jingham added a comment. > This revision is now accepted and