JDevlieghere added a comment.
In https://reviews.llvm.org/D48782#1148376, @labath wrote:
> Then, for the integration test part, I propose to come up with a more generic
> way to specify the kind of debug info to generate. I don't have this fully
> thought out yet, but I have been thinking of so
apolyakov added inline comments.
Comment at: tools/lldb-mi/MICmdCmdSymbol.cpp:24
+namespace {
+inline const CMICmnMIValueTuple
+CreateMITuplePCLine(const uint32_t addr, const uint32_t line_number) {
aprantl wrote:
> Please remove the `inline` keyword. LLVM will i
aprantl added a comment.
This is going to be really nice!
Comment at: tools/lldb-mi/MICmdCmdSymbol.cpp:24
+namespace {
+inline const CMICmnMIValueTuple
+CreateMITuplePCLine(const uint32_t addr, const uint32_t line_number) {
Please remove the `inline` keyword. L
aprantl added a comment.
This seems like a reasonable addition. Could you also add documentation for the
new API?
https://reviews.llvm.org/D48801
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listin
apolyakov created this revision.
apolyakov added reviewers: aprantl, clayborg.
Herald added subscribers: eraman, ki.stfu.
Now this command uses SB API instead of HandleCommand.
https://reviews.llvm.org/D48802
Files:
lit/tools/lldb-mi/symbol/inputs/list-lines-helper.c
lit/tools/lldb-mi/symbo
apolyakov created this revision.
apolyakov added reviewers: aprantl, clayborg.
The new API allows to find a list of compile units related to target/module.
https://reviews.llvm.org/D48801
Files:
include/lldb/API/SBModule.h
include/lldb/API/SBTarget.h
scripts/interface/SBModule.i
scripts
