teemperor created this revision.
teemperor added reviewers: davide, jingham, labath.
Herald added a subscriber: mgorny.
This patch refactors the internal completion API. It now takes (as far as
possible) a single
CompletionRequest object instead o half a dozen in/out/in-out parameters. The
Compl
alexshap added a comment.
@labath
> I am not denying that there is value in running the dotest suite in all of
> these modes. In fact, I think that (the fact that we can use the same tests
> to exercise a lot of different scenarios) is one of the strengths ?>of our
> test suite. However, I don
alexshap added inline comments.
Comment at: packages/Python/lldbsuite/test/make/Makefile.rules:238
+ifneq (,$(wildcard $(LLVM_DWP)))
+ MAKE_DWP=YES
aprantl wrote:
> Is the fact this this is *llvm-*dwp critical, or are llvm-dwp and GNU dwp
> interchangeable? I
This revision was automatically updated to reflect the committed changes.
Closed by commit rL336009: [lldb-mi] Clean up and update a few MI commands.
(authored by apolyakov, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D47992?vs=1526
Author: apolyakov
Date: Fri Jun 29 12:58:31 2018
New Revision: 336009
URL: http://llvm.org/viewvc/llvm-project?rev=336009&view=rev
Log:
[lldb-mi] Clean up and update a few MI commands.
Summary:
This patch updates a few MI commands using a new way of
handling an errors in lldb-mi and removes unnec
kastiglione added a comment.
Thanks @jingham.
> if the `IOHandlerDelegate` could say whether it wants to be notified for
> `IOHandlerActivated` when non-interactive (like have a
> "`ShouldNotifyWhenNonInteractive`" method), and then the `IOHandler` could
> dispatch it or not based on the respo
Thanks Adrian. My latest patch is here: https://reviews.llvm.org/D48782
This adds an option to the makefile
in llvm/tools/lldb/packages/Python/lldbsuite/test/make/Makefile.rules to
enable producing a DWP file from the DWO split dwarf files to enable
testing Dwarf Package Format (DWP).
I spoke with
aprantl added a comment.
Is the dummy target something we need to expose over the SBAPI?
I see that other places in lldb-mi query `if (sbTarget ==
rSessionInfo.GetDebugger().GetDummyTarget())`. Would that be sufficient?
https://reviews.llvm.org/D48775
___
apolyakov updated this revision to Diff 153516.
apolyakov edited the summary of this revision.
apolyakov added a comment.
Added description to source files and commit message.
https://reviews.llvm.org/D48775
Files:
include/lldb/API/SBTarget.h
scripts/interface/SBTarget.i
source/API/SBTarg
brucem requested changes to this revision.
brucem added inline comments.
This revision now requires changes to proceed.
Comment at: include/lldb/API/SBTarget.h:65
+ bool IsDummy() const;
+
Could you add a doc comment here explaining it?
Comm
apolyakov created this revision.
apolyakov added reviewers: aprantl, clayborg.
The new member function allows to check if a target is dummy or real.
https://reviews.llvm.org/D48775
Files:
include/lldb/API/SBTarget.h
scripts/interface/SBTarget.i
source/API/SBTarget.cpp
Index: source/API/
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rL335967: Add a test for reading lld-generated build-ids
(authored by labath, committed by ).
Herald added a subscriber: llv
Author: labath
Date: Fri Jun 29 05:15:54 2018
New Revision: 335967
URL: http://llvm.org/viewvc/llvm-project?rev=335967&view=rev
Log:
Add a test for reading lld-generated build-ids
Summary:
This test makes sure we are able to read the shorter build-ids which are
generated by lld.
To make this wor
Author: labath
Date: Fri Jun 29 04:20:29 2018
New Revision: 335963
URL: http://llvm.org/viewvc/llvm-project?rev=335963&view=rev
Log:
UUID: Add support for arbitrary-sized module IDs
Summary:
The data structure is optimized for the case where the UUID size is <=
20 bytes (standard length emitted b
This revision was automatically updated to reflect the committed changes.
Closed by commit rL335963: UUID: Add support for arbitrary-sized module IDs
(authored by labath, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D48633
Files:
lldb
Author: labath
Date: Fri Jun 29 03:27:18 2018
New Revision: 335960
URL: http://llvm.org/viewvc/llvm-project?rev=335960&view=rev
Log:
Fix use-after-free in CommandCompletions.cpp
The code was creating a StringRef to a temporary std::string. The
solution is to just drop the .str() from the original
Author: labath
Date: Fri Jun 29 02:22:07 2018
New Revision: 335956
URL: http://llvm.org/viewvc/llvm-project?rev=335956&view=rev
Log:
Fix TestLoadUsingPaths on linux
we need to explicitly link the test program with -ldl for the dlopen
function to be available.
Modified:
lldb/trunk/packages/P
Author: labath
Date: Fri Jun 29 02:06:42 2018
New Revision: 335955
URL: http://llvm.org/viewvc/llvm-project?rev=335955&view=rev
Log:
Modernize completion tests
Now that we have gmock, we can use its matchers to better express the
test assertions. The main advantage of this is that when things fai
18 matches
Mail list logo
