asmith added a comment.
Has a dependence on https://reviews.llvm.org/D44458
Repository:
rL LLVM
https://reviews.llvm.org/D44456
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
asmith created this revision.
asmith added reviewers: zturner, rnk, lldb-commits.
Herald added a subscriber: llvm-commits.
Replace SymbolFilePDB::GetSourceFileNameForPDBCompiland() with
PDBSymbolCompiland::getSourceFileFullPath().
Repository:
rL LLVM
https://reviews.llvm.org/D44456
Files:
asmith created this revision.
asmith added reviewers: zturner, rnk, lldb-commits.
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D44455
Files:
source/Plugins/SymbolFile/PDB/PDBASTParser.cpp
source/Plugins/SymbolFile/PDB/SymbolFilePDB.cpp
source/Plug
timotheecour updated this revision to Diff 138291.
timotheecour added a comment.
- document C interface
https://reviews.llvm.org/D44321
Files:
include/lldb/Core/Mangled.h
include/lldb/Core/PluginManager.h
source/API/SystemInitializerFull.cpp
source/Core/CMakeLists.txt
source/Core/Mang
timotheecour added a comment.
> Actually, this is not the correct interface is it? The returned pointer
> should point to newly allocated memory using malloc, right?
> Good to document that somewhere.
not 100% sure what you mean in that comment but I just pushed a commit that
clarifies that po
On Tue, Mar 13, 2018 at 2:43 PM, Jason Molenda wrote:
>
>
>> On Mar 13, 2018, at 11:51 AM, Davide Italiano via lldb-commits
>> wrote:
>>
>> We had the report of a crash where lldb was setting a conditional
>> breakpoint on an invalid condition (CGRect == pointer, which is,
>> ill-formed).
>> The
Author: vedantk
Date: Tue Mar 13 16:37:11 2018
New Revision: 327463
URL: http://llvm.org/viewvc/llvm-project?rev=327463&view=rev
Log:
[test] Replace some references to Apple-internal bugs
This removes around 10 references to Apple-internal radars. I've filed
fresh bugs on bugs.llvm.org as appropr
jasonmolenda added a comment.
(or rather, not "conflict with the OperatingSystemPlugIn stop reason" -- but
would make it confusing to users. I think it might be best to remove
ThreadMachCore::CalculateStopInfo.)
https://reviews.llvm.org/D44139
__
jasonmolenda accepted this revision.
jasonmolenda added a comment.
Looks good, thanks for doing this Jonas. I thought there would be a problem
with ThreadMachCore::CalculateStopInfo() in
source/Plugins/Process/mach-core/ThreadMachCore.cpp which will mark every
thread that comes from the actual
> On Mar 13, 2018, at 11:51 AM, Davide Italiano via lldb-commits
> wrote:
>
> We had the report of a crash where lldb was setting a conditional
> breakpoint on an invalid condition (CGRect == pointer, which is,
> ill-formed).
> The symbol-based resolution of lldb was picking a random operator=
jingham accepted this revision.
jingham added a comment.
This revision is now accepted and ready to land.
Looks great! Thanks for working through this.
https://reviews.llvm.org/D44139
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http:/
Author: jingham
Date: Tue Mar 13 14:06:05 2018
New Revision: 327448
URL: http://llvm.org/viewvc/llvm-project?rev=327448&view=rev
Log:
Add a missing return in SBPlatform::IsConnected and test
for the behavior - using the fact that the Host platform
is always present & connected.
Modified:
lld
Author: davide
Date: Tue Mar 13 13:26:38 2018
New Revision: 327445
URL: http://llvm.org/viewvc/llvm-project?rev=327445&view=rev
Log:
[DataFormatter] Remove dead code for the NSDictionary formatter.
I'm going to make changes in this area soon, so I figured I
could clean things a bit while I was ar
On Tue, Mar 13, 2018 at 10:56 AM, Greg Clayton wrote:
>
>
> On Mar 13, 2018, at 10:25 AM, Davide Italiano via lldb-commits
> wrote:
>
> On Tue, Mar 13, 2018 at 9:59 AM, Frédéric Riss via lldb-commits
> wrote:
>
>
>
> On Mar 12, 2018, at 6:40 PM, Davide Italiano via lldb-commits
> wrote:
>
> Aut
On Tue, Mar 13, 2018 at 11:17 AM, Greg Clayton wrote:
> If you check the expression log, you will see the printf() function
> declaration and any others we add:
>
> (lldb) log enable lldb expr
> (lldb) 2+3
>
> ...
> #ifndef NULL
> #define NULL (__null)
> #endif
> #ifndef Nil
> #define Nil (__null
If you check the expression log, you will see the printf() function declaration
and any others we add:
(lldb) log enable lldb expr
(lldb) 2+3
...
#ifndef NULL
#define NULL (__null)
#endif
#ifndef Nil
#define Nil (__null)
#endif
#ifndef nil
#define nil (__null)
#endif
#ifndef YES
#define YES ((BO
On Tue, Mar 13, 2018 at 10:57 AM, Greg Clayton wrote:
>
>
>> On Mar 13, 2018, at 10:37 AM, Davide Italiano via lldb-commits
>> wrote:
>>
>> An alternative proposed by Fred which is an OK middle ground IMHO is
>> that of not inserting a decl for the unmangled name, but treat this
>> symbol always
> On Mar 13, 2018, at 10:37 AM, Davide Italiano via lldb-commits
> wrote:
>
> An alternative proposed by Fred which is an OK middle ground IMHO is
> that of not inserting a decl for the unmangled name, but treat this
> symbol always as-it-is.
> i.e. if we have a symbol _Znwm in some object, we
> On Mar 13, 2018, at 10:25 AM, Davide Italiano via lldb-commits
> wrote:
>
> On Tue, Mar 13, 2018 at 9:59 AM, Frédéric Riss via lldb-commits
> mailto:lldb-commits@lists.llvm.org>> wrote:
>>
>>
>>> On Mar 12, 2018, at 6:40 PM, Davide Italiano via lldb-commits
>>> wrote:
>>>
>>> Author: da
An alternative proposed by Fred which is an OK middle ground IMHO is
that of not inserting a decl for the unmangled name, but treat this
symbol always as-it-is.
i.e. if we have a symbol _Znwm in some object, we don't insert a decl
for `operator new(unsigned long)` but for _Znwm itself.
Greg, Jason
On Tue, Mar 13, 2018 at 9:59 AM, Frédéric Riss via lldb-commits
wrote:
>
>
>> On Mar 12, 2018, at 6:40 PM, Davide Italiano via lldb-commits
>> wrote:
>>
>> Author: davide
>> Date: Mon Mar 12 18:40:00 2018
>> New Revision: 327356
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=327356&view=rev
I agree with Jason, we shouldn't be looking at magic naming and making
assumptions. What is the name is a C function that starts with _Z.
Both of Jason's examples below should work. Sometimes we only have symbol
tables and if people are able to only get to the C++ function via a mangled
name, t
> On Mar 12, 2018, at 7:52 PM, Davide Italiano via lldb-commits
> wrote:
>
> On Mon, Mar 12, 2018 at 7:27 PM, Jason Molenda via lldb-commits
> wrote:
>> FWIW, we'll definitely get pushback about
>>
>>> Now you can't do in lldb anymore
>>> (lldb) call _Zsomethingsomething(1,2,3)
>>
>>
>> Th
> On Mar 12, 2018, at 6:40 PM, Davide Italiano via lldb-commits
> wrote:
>
> Author: davide
> Date: Mon Mar 12 18:40:00 2018
> New Revision: 327356
>
> URL: http://llvm.org/viewvc/llvm-project?rev=327356&view=rev
> Log:
> [ExpressionParser] Fix crash when evaluating invalid expresssions.
>
>
Author: labath
Date: Tue Mar 13 08:55:00 2018
New Revision: 327413
URL: http://llvm.org/viewvc/llvm-project?rev=327413&view=rev
Log:
include locale.h in IOHandler.cpp
This is needed for the setlocale() call, and it seems that it is not
transitively pulled in for some build configurations.
Modifi
labath planned changes to this revision.
labath added a comment.
Yes, that thought occurred to me almost immediately after I submitted this.
I'll try to implement something like that instead.
Since this will be just a bunch of static functions with no state, I think we
don't even have to put th
Author: labath
Date: Tue Mar 13 02:46:00 2018
New Revision: 327379
URL: http://llvm.org/viewvc/llvm-project?rev=327379&view=rev
Log:
Fix linux s390x build (pr36694)
Modified:
lldb/trunk/source/Plugins/Process/Linux/NativeRegisterContextLinux_s390x.cpp
Modified:
lldb/trunk/source/Plugins/Pro
Author: labath
Date: Tue Mar 13 02:46:10 2018
New Revision: 327380
URL: http://llvm.org/viewvc/llvm-project?rev=327380&view=rev
Log:
Fix clang-3.8 build
clang-3.8 complains that constructor for '...' must explicitly
initialize the const member. Newer clangs and gcc seem to be fine with
this, but
28 matches
Mail list logo
