[Lldb-commits] [PATCH] D43884: [lldb] Extract more fields from NSException values

kubamracek added a comment. I simplified what this patch is doing by removing the other independent parts. I extended the test to be testing both CLI text output and SB APIs (which also means it cannot be moved to a lit test). https://reviews.llvm.org/D43884

[Lldb-commits] [PATCH] D43884: [lldb] Extract more fields from NSException values

kubamracek updated this revision to Diff 136933. https://reviews.llvm.org/D43884 Files: packages/Python/lldbsuite/test/lang/objc/exceptions/Makefile packages/Python/lldbsuite/test/lang/objc/exceptions/TestObjCExceptions.py packages/Python/lldbsuite/test/lang/objc/exceptions/main.m source/

[Lldb-commits] [lldb] r326671 - llgs-tests: use the auto-parsing form of SendMessage for sending the continue packets

Author: labath Date: Sat Mar 3 18:12:18 2018 New Revision: 326671 URL: http://llvm.org/viewvc/llvm-project?rev=326671&view=rev Log: llgs-tests: use the auto-parsing form of SendMessage for sending the continue packets Modified: lldb/trunk/unittests/tools/lldb-server/tests/MessageObjects.h

[Lldb-commits] [PATCH] D44015: Fix std unique pointer not printing.

labath added inline comments. Comment at: source/Plugins/Language/CPlusPlus/LibStdcppUniquePointer.cpp:65-76 ValueObjectSP tuple_sp = valobj_sp->GetChildMemberWithName(ConstString("_M_t"), true); + + ValueObjectSP tuple_sp_child = + tuple_sp->GetChildMemberWithNa

[Lldb-commits] [PATCH] D44074: ObjectFileMachO: split CreateSections mega-function into more manageable chunks

labath created this revision. labath added reviewers: clayborg, davide. In an effort to understand the function's operation, I've split it into logical pieces. Parsing of a single segment is moved to a separate function (and the parsing state that is carried from one segment to another is explicit

[Lldb-commits] [PATCH] D43884: [lldb] Extract more fields from NSException values

kubamracek added a comment. The NFC refactoring part of this is at https://reviews.llvm.org/D44073. https://reviews.llvm.org/D43884 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D44073: [lldb] Refactor ObjC/NSException.cpp (cleanup, avoid code duplication). NFC.

kubamracek created this revision. kubamracek added reviewers: jingham, jasonmolenda, davide. - Refactor reading of NSException fields into ExtractFields method to avoid code duplication. - Remove "m_child_ptr" field, as it's not used anywhere. - Clang-format. https://reviews.llvm.org/D44073 Fi

[Lldb-commits] [lldb] r326667 - ObjectFileMachO: use early return to remove one nesting level from CreateSections()

Author: labath Date: Sat Mar 3 14:07:47 2018 New Revision: 326667 URL: http://llvm.org/viewvc/llvm-project?rev=326667&view=rev Log: ObjectFileMachO: use early return to remove one nesting level from CreateSections() NFCI Modified: lldb/trunk/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO

[Lldb-commits] [PATCH] D42955: Make Module::GetSectionList output consistent

labath abandoned this revision. labath added a comment. I don't think this approach is good while ObjectFileMachO is messing with sections of other object files. At this point I think, I've actually learned enough about MachO to understand what the code is doing there, so I'm going to see if I

[Lldb-commits] [PATCH] D44055: [lldb] Fix "requires global constructor" warning in g_range_specifiers

labath added a comment. BTW, to appease older versions of gcc you will need to write the initializer as `= {{"-"}, {"to"}, ...}` (i.e. add extra {} around the strings). https://reviews.llvm.org/D44055 ___ lldb-commits mailing list lldb-commits@list

[Lldb-commits] [PATCH] D44072: [lldb] Retrieve currently handled Obj-C exception via __cxa_current_exception_type

kubamracek created this revision. kubamracek added reviewers: jingham, jasonmolenda, davide. This builds on https://reviews.llvm.org/D43884 and https://reviews.llvm.org/D43886 and extends LLDB support of Obj-C exceptions to also look for a "current exception" for a thread in the C++ exception ha

[Lldb-commits] [PATCH] D44058: [lldb] Fix "code unreachable" warning in DNBArchImplX86_64::SetRegisterValue

kubamracek added a comment. In https://reviews.llvm.org/D44058#1026646, @davide wrote: > This seems scary. We really need a test case for this. Agreed, but I don't know this code, so I'm not able to come up with a test for this. https://reviews.llvm.org/D44058

[Lldb-commits] [PATCH] D43886: [lldb] Add GetCurrentException and GetCurrentExceptionBacktrace APIs to SBThread

kubamracek added a comment. Thanks for the high-level feedback! I'll split the patch and we can discuss further. https://reviews.llvm.org/D43886 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinf

[Lldb-commits] [PATCH] D44058: [lldb] Fix "code unreachable" warning in DNBArchImplX86_64::SetRegisterValue

davide added a comment. This seems scary. We really need a test case for this. https://reviews.llvm.org/D44058 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D44055: [lldb] Fix "requires global constructor" warning in g_range_specifiers

davide accepted this revision. davide added a comment. This revision is now accepted and ready to land. LGTM with Pavel's suggestion implemented. https://reviews.llvm.org/D44055 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.