[Lldb-commits] [PATCH] D42939: More correct handling of error cases C++ name parser

eugene updated this revision to Diff 132916. eugene added a comment. fix formating https://reviews.llvm.org/D42939 Files: source/Plugins/Language/CPlusPlus/CPlusPlusNameParser.cpp unittests/Language/CPlusPlus/CPlusPlusLanguageTest.cpp Index: unittests/Language/CPlusPlus/CPlusPlusLanguageT

[Lldb-commits] [PATCH] D42939: More correct handling of error cases C++ name parser

eugene created this revision. eugene added a reviewer: labath. Now incorrect type argument that looks like T doesn't cause an assert, but just a parsing error. Bug: 36224 https://reviews.llvm.org/D42939 Files: source/Plugins/Language/CPlusPlus/CPlusPlusNameParser.cpp unittests/Lan

[Lldb-commits] [lldb] r324293 - [testsuite] Skip a flakey test.

Author: davide Date: Mon Feb 5 15:51:57 2018 New Revision: 324293 URL: http://llvm.org/viewvc/llvm-project?rev=324293&view=rev Log: [testsuite] Skip a flakey test. Modified: lldb/trunk/packages/Python/lldbsuite/test/lang/objc/modules-incomplete/TestIncompleteModules.py Modified: lldb/trun

[Lldb-commits] [lldb] r324288 - Disable test_restart_bug failing on Android

Author: eugene Date: Mon Feb 5 15:31:58 2018 New Revision: 324288 URL: http://llvm.org/viewvc/llvm-project?rev=324288&view=rev Log: Disable test_restart_bug failing on Android Modified: lldb/trunk/packages/Python/lldbsuite/test/functionalities/signal/raise/TestRaise.py Modified: lldb/trun

Re: [Lldb-commits] [lldb] r324287 - Fix the cputype comparison in GDBRemoteCommunicationServerCommon::Handle_qHostInfo

On Mon, Feb 5, 2018 at 3:10 PM, Jason Molenda via lldb-commits wrote: > Author: jmolenda > Date: Mon Feb 5 15:10:51 2018 > New Revision: 324287 > > URL: http://llvm.org/viewvc/llvm-project?rev=324287&view=rev > Log: > Fix the cputype comparison in > GDBRemoteCommunicationServerCommon::Handle_qHo

[Lldb-commits] [lldb] r324287 - Fix the cputype comparison in GDBRemoteCommunicationServerCommon::Handle_qHostInfo

Author: jmolenda Date: Mon Feb 5 15:10:51 2018 New Revision: 324287 URL: http://llvm.org/viewvc/llvm-project?rev=324287&view=rev Log: Fix the cputype comparison in GDBRemoteCommunicationServerCommon::Handle_qHostInfo to use Mach-O cpu types instead of the ArchSpec enum value, and handle the case

[Lldb-commits] [lldb] r324281 - CMake: fix build directory name in clean rule

Author: adrian Date: Mon Feb 5 14:35:46 2018 New Revision: 324281 URL: http://llvm.org/viewvc/llvm-project?rev=324281&view=rev Log: CMake: fix build directory name in clean rule Modified: lldb/trunk/test/CMakeLists.txt Modified: lldb/trunk/test/CMakeLists.txt URL: http://llvm.org/viewvc/ll

[Lldb-commits] [lldb] r324280 - [lang/Objc] UNXFAIL a test. Nullability has been implemented in clang.

Author: davide Date: Mon Feb 5 14:31:59 2018 New Revision: 324280 URL: http://llvm.org/viewvc/llvm-project?rev=324280&view=rev Log: [lang/Objc] UNXFAIL a test. Nullability has been implemented in clang. (a while ago). Modified: lldb/trunk/packages/Python/lldbsuite/test/lang/objc/modules-

[Lldb-commits] [PATCH] D42914: Rewrite TestTargetSymbolsBuildidCase to be more focused

jankratochvil accepted this revision. jankratochvil added a comment. This revision is now accepted and ready to land. It does work for me also with: `r324254 - Fix parsing of object files with "early" section headers` https://reviews.llvm.org/D42914 __

[Lldb-commits] [PATCH] D42931: ELF GetSectionHeaderInfo: process SHT_NOTE even without .shstrtab

jankratochvil added a comment. I see now Pavel has solved it by: [Lldb-commits] [lldb] r324254 - Fix parsing of object files with "early" section headers https://lists.llvm.org/pipermail/lldb-commits/Week-of-Mon-20180205/038992.html I am not sure if that is not a more general so

[Lldb-commits] [PATCH] D42891: DWZ 01/12: refactor: DWARFCompileUnit::Producer -> DWARFProducer

This revision was automatically updated to reflect the committed changes. Closed by commit rL324275: refactor: DWARFCompileUnit::Producer -> DWARFProducer (authored by jankratochvil, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D4289

[Lldb-commits] [lldb] r324275 - refactor: DWARFCompileUnit::Producer -> DWARFProducer

Author: jankratochvil Date: Mon Feb 5 13:50:01 2018 New Revision: 324275 URL: http://llvm.org/viewvc/llvm-project?rev=324275&view=rev Log: refactor: DWARFCompileUnit::Producer -> DWARFProducer Differential revision: https://reviews.llvm.org/D42891 Modified: lldb/trunk/source/Plugins/SymbolF

[Lldb-commits] [PATCH] D42914: Rewrite TestTargetSymbolsBuildidCase to be more focused

jankratochvil added a comment. This testcase does work for me only with newly written https://reviews.llvm.org/D42931. https://reviews.llvm.org/D42914 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/l

[Lldb-commits] [PATCH] D42931: ELF GetSectionHeaderInfo: process SHT_NOTE even without .shstrtab

jankratochvil created this revision. jankratochvil added a reviewer: labath. Herald added subscribers: emaste, srhines. This is written for tha YAML testcase of https://reviews.llvm.org/D42914. Its unstripped.yaml contains: Start of section headers: 64 (bytes into file) Number o

[Lldb-commits] [PATCH] D42763: Build each testcase variant in its own subdirectory and remove the srcdir lock file

aprantl updated this revision to Diff 132888. aprantl marked 17 inline comments as done. aprantl added a comment. Cleanup and address outstanding review feedback. https://reviews.llvm.org/D42763 Files: packages/Python/lldbsuite/test/functionalities/load_unload/TestLoadUnload.py packages/Pyt

[Lldb-commits] [PATCH] D42763: Build each testcase variant in its own subdirectory and remove the srcdir lock file

aprantl updated this revision to Diff 132875. aprantl added a comment. Updated to query self.getDebugInfo() in getBuildDir(). https://reviews.llvm.org/D42763 Files: packages/Python/lldbsuite/test/api/listeners/TestListener.py packages/Python/lldbsuite/test/functionalities/breakpoint/comp_d

Re: [Lldb-commits] [PATCH] D42210: Re-enable logging on the child side of a fork() in lldb-server platform mode

Yeah I saw the TCPSocket::Accept differences on top of tree after sending the email - unfortunately I have to do my work on this old branch, and I can't build our top of tree sources for the iphone target right now. It's not a great situation! The min/max ports are needed for running the testsu

[Lldb-commits] [PATCH] D42914: Rewrite TestTargetSymbolsBuildidCase to be more focused

davide added a comment. In https://reviews.llvm.org/D42914#997974, @zturner wrote: > Yea this seems like a good candidate for an lldb-test test. Something like > this. > > RUN: yaml2obj %S/Inputs/stripped.yaml > %t.stripped.out > RUN: yaml2obj %S/Inputs/unstripped.yaml > > %t/.build-id/1b

[Lldb-commits] [PATCH] D42914: Rewrite TestTargetSymbolsBuildidCase to be more focused

zturner added a comment. Yea this seems like a good candidate for an lldb-test test. Something like this. RUN: yaml2obj %S/Inputs/stripped.yaml > %t.stripped.out RUN: yaml2obj %S/Inputs/unstripped.yaml > %t/.build-id/1b/8a73ac238390e32a7ff4ac8ebe4d6a41ecf5c9.debug RUN: lldb-test symbols

[Lldb-commits] [PATCH] D42914: Rewrite TestTargetSymbolsBuildidCase to be more focused

jankratochvil added a comment. FYI it FAILs for me on Fedora 27 x86_64, it cannot find "main", debugging it. The .build-id/ separate debug info does work with GDB but not with LLDB. https://reviews.llvm.org/D42914 ___ lldb-commits mailing list lld

[Lldb-commits] [PATCH] D42917: Adapt some tests to work with PPC64le architecture

anajuliapc created this revision. Merge branch 'master' into adaptPPC64tests https://reviews.llvm.org/D42917 Files: packages/Python/lldbsuite/test/functionalities/watchpoint/multiple_hits/TestMultipleHits.py packages/Python/lldbsuite/test/lang/c/register_variables/test.c packages/Python/

Re: [Lldb-commits] [lldb] r324254 - Fix parsing of object files with "early" section headers

On Mon, Feb 5, 2018 at 10:09 AM, Pavel Labath wrote: > Committed as r324256. Thanks for keeping me honest. > > Going back to this, I noticed that I did not check-in the final tiny > binary that I intended to, which happened because I was rushing to get > the build-id test fixed, so I could get bac

Re: [Lldb-commits] [lldb] r324254 - Fix parsing of object files with "early" section headers

Committed as r324256. Thanks for keeping me honest. Going back to this, I noticed that I did not check-in the final tiny binary that I intended to, which happened because I was rushing to get the build-id test fixed, so I could get back to what I originally planned to do for today, and the fact th

[Lldb-commits] [lldb] r324256 - Add a comment explaining how the input for GetModuleSpecifications_EarlySectionHeaders was generated

Author: labath Date: Mon Feb 5 10:03:02 2018 New Revision: 324256 URL: http://llvm.org/viewvc/llvm-project?rev=324256&view=rev Log: Add a comment explaining how the input for GetModuleSpecifications_EarlySectionHeaders was generated Davide pointed out this would be useful if the file ever needs

Re: [Lldb-commits] [lldb] r322339 - When parsing the target.xml register file, if no architecture has

On Mon, Jan 29, 2018 at 10:17 AM, Jason Molenda wrote: > > >> On Jan 28, 2018, at 9:59 PM, Davide Italiano wrote: >> >> On Thu, Jan 11, 2018 at 5:26 PM, Davide Italiano >> wrote: >>> On Thu, Jan 11, 2018 at 5:16 PM, Jason Molenda via lldb-commits >>> wrote: Author: jmolenda Date: Thu

Re: [Lldb-commits] [lldb] r324156 - Fix a copy of a fixed length, possibly non-nul terminated, string

On Fri, Feb 2, 2018 at 2:48 PM, Jason Molenda via lldb-commits wrote: > Author: jmolenda > Date: Fri Feb 2 14:48:45 2018 > New Revision: 324156 > > URL: http://llvm.org/viewvc/llvm-project?rev=324156&view=rev > Log: > Fix a copy of a fixed length, possibly non-nul terminated, string > into a std:

Re: [Lldb-commits] [lldb] r324254 - Fix parsing of object files with "early" section headers

On Mon, Feb 5, 2018 at 9:25 AM, Pavel Labath via lldb-commits wrote: > Author: labath > Date: Mon Feb 5 09:25:40 2018 > New Revision: 324254 > > URL: http://llvm.org/viewvc/llvm-project?rev=324254&view=rev > Log: > Fix parsing of object files with "early" section headers > > ObjectFileELF::GetMod

[Lldb-commits] [PATCH] D42914: Rewrite TestTargetSymbolsBuildidCase to be more focused

davide added a comment. Nice :) This looks already fine as-is, but I wonder whether we can get rid of the python boilerplate altogether? There has been quite a bit of discussion about using `lldb-test` for this sort of more focused testing, so I wonder whether you gave it a try? (just a random

[Lldb-commits] [PATCH] D42912: Sync PlatformNetBSD.cpp with Linux

davide added a comment. LGTM. I always found supercumbersome having to check `if log()` and error prone. Repository: rL LLVM https://reviews.llvm.org/D42912 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/m

Re: [Lldb-commits] [lldb] r324222 - Fix upper->lower case for /usr/lib/debug/.build-id/**.debug

Thank you for fixing this and adding a test! On Mon, Feb 5, 2018 at 2:46 AM, Jan Kratochvil via lldb-commits wrote: > Author: jankratochvil > Date: Mon Feb 5 02:46:56 2018 > New Revision: 324222 > > URL: http://llvm.org/viewvc/llvm-project?rev=324222&view=rev > Log: > Fix upper->lower case for /

[Lldb-commits] [lldb] r324254 - Fix parsing of object files with "early" section headers

Author: labath Date: Mon Feb 5 09:25:40 2018 New Revision: 324254 URL: http://llvm.org/viewvc/llvm-project?rev=324254&view=rev Log: Fix parsing of object files with "early" section headers ObjectFileELF::GetModuleSpecifications contained a lot of tip-toing code which was trying to avoid loading

[Lldb-commits] [PATCH] D42914: Rewrite TestTargetSymbolsBuildidCase to be more focused

labath created this revision. labath added a reviewer: jankratochvil. The test was failing in remote debugging scenario with windows as a host as cmd.exe is not able to parse the complicated shell commands in the Makefile. The test seemed like a perfect candidate for a more focused testing approa

[Lldb-commits] [lldb] r324251 - Sync PlatformNetBSD.cpp with Linux

Author: kamil Date: Mon Feb 5 09:12:23 2018 New Revision: 324251 URL: http://llvm.org/viewvc/llvm-project?rev=324251&view=rev Log: Sync PlatformNetBSD.cpp with Linux Summary: Various changes in logging from log->Printf() to generic LLDB_LOG(). Sponsored by Reviewers: labath, joerg Reviewed B

[Lldb-commits] [PATCH] D42912: Sync PlatformNetBSD.cpp with Linux

krytarowski created this revision. krytarowski added reviewers: labath, joerg. Herald added a subscriber: llvm-commits. Various changes in logging from log->Printf() to generic LLDB_LOG(). Sponsored by Repository: rL LLVM https://reviews.llvm.org/D42912 Files: source/Plugins/Platform/Net

[Lldb-commits] [PATCH] D42908: Fix Bug 36237 - TestTargetSymbolsSepDebugSymlink fails when run remotely

labath added a comment. >> I think that a more reasonable behavior here would be to copy the file >> contents instead. > The symlink is essential for this testcase otherwise it does not test the > bugfix. OK to just disable it for remote testing? My comment you are quoting should applies to

[Lldb-commits] [PATCH] D42908: Fix Bug 36237 - TestTargetSymbolsSepDebugSymlink fails when run remotely

jankratochvil created this revision. jankratochvil added a reviewer: labath. (In reply to labath from Bug 36237 comment #0) > The root problem is in Platform::Install. When given a symlink, it will try > to create the same symlink on the target. However, Platform::CreateSymlink > function is n

[Lldb-commits] [lldb] r324236 - Skip TestTargetSymbolsSepDebugSymlink on remote targets

Author: labath Date: Mon Feb 5 06:07:44 2018 New Revision: 324236 URL: http://llvm.org/viewvc/llvm-project?rev=324236&view=rev Log: Skip TestTargetSymbolsSepDebugSymlink on remote targets Currently, our behavior when installing symlinks on the remote target is broken (pr36237). Modified: l

[Lldb-commits] [lldb] r324234 - Fix a crash in *NetBSD::Factory::Launch

Author: kamil Date: Mon Feb 5 05:16:22 2018 New Revision: 324234 URL: http://llvm.org/viewvc/llvm-project?rev=324234&view=rev Log: Fix a crash in *NetBSD::Factory::Launch Summary: We cannot call process_up->SetState() inside the NativeProcessNetBSD::Factory::Launch function because it triggers a

[Lldb-commits] [lldb] r324230 - TestLinuxCore -- add a check for thread name

Author: labath Date: Mon Feb 5 04:34:09 2018 New Revision: 324230 URL: http://llvm.org/viewvc/llvm-project?rev=324230&view=rev Log: TestLinuxCore -- add a check for thread name We've had a bug (fixed by https://reviews.llvm.org/D42828) where the thread name was being read incorrectly. Add a test

[Lldb-commits] [PATCH] D42870: Correct recognition of NetBSD images

labath added a comment. Extending lldb-test's dumpModules() to also dump out the module's triple sounds like a reasonable thing to do (I am assuming that the Module class will do something reasonable when given an object file with no sections, like a core file -- if not we could make a separate

[Lldb-commits] [PATCH] D42145: [lldb] Use vFlash commands when writing to target's flash memory regions

labath added a comment. In https://reviews.llvm.org/D42145#996575, @owenpshaw wrote: > - adjust WriteObjectFile signature to return Status and take an std::vector > - match project formatting style > > I toyed with adding allow_flash to as an argument, but didn't really like > it because it se

[Lldb-commits] [PATCH] D42836: [dotest] make debug info variant accessible in setUp()

This revision was automatically updated to reflect the committed changes. Closed by commit rL324226: [dotest] make debug info variant accessible in setUp() (authored by labath, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D42836 Files:

[Lldb-commits] [lldb] r324226 - [dotest] make debug info variant accessible in setUp()

Author: labath Date: Mon Feb 5 03:30:46 2018 New Revision: 324226 URL: http://llvm.org/viewvc/llvm-project?rev=324226&view=rev Log: [dotest] make debug info variant accessible in setUp() Summary: This changes the way we store the debug info variant to make it available earlier in the test bringu

Re: [Lldb-commits] [PATCH] D42210: Re-enable logging on the child side of a fork() in lldb-server platform mode

Hi Jason, Thanks for the heads up. I look forward to getting rid of fork() there, but there is one thing that's not clear to me. You say that TCPSocket::Accept() calls CloseListenSockets().. I see don't see anything like that in the current code, and I know for a fact that we are able to handle mu

[Lldb-commits] [lldb] r324224 - Resolve binary symlinks before finding its separate .debug file

Author: jankratochvil Date: Mon Feb 5 02:50:38 2018 New Revision: 324224 URL: http://llvm.org/viewvc/llvm-project?rev=324224&view=rev Log: Resolve binary symlinks before finding its separate .debug file I have found LLDB cannot find separate debug info of Fedora /usr/bin/gdb. It is because: lrw

[Lldb-commits] [PATCH] D42853: Resolve binary symlinks before finding its separate .debug file

This revision was automatically updated to reflect the committed changes. Closed by commit rL324224: Resolve binary symlinks before finding its separate .debug file (authored by jankratochvil, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm

[Lldb-commits] [PATCH] D42852: Fix upper->lower case for /usr/lib/debug/.build-id/**.debug

This revision was automatically updated to reflect the committed changes. Closed by commit rL324222: Fix upper->lower case for /usr/lib/debug/.build-id/**.debug (authored by jankratochvil, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org

[Lldb-commits] [lldb] r324222 - Fix upper->lower case for /usr/lib/debug/.build-id/**.debug

Author: jankratochvil Date: Mon Feb 5 02:46:56 2018 New Revision: 324222 URL: http://llvm.org/viewvc/llvm-project?rev=324222&view=rev Log: Fix upper->lower case for /usr/lib/debug/.build-id/**.debug I have found the lookup by build-id (when lookup by /usr/lib/debug/path/name/exec.debug failed) d

[Lldb-commits] [PATCH] D42853: Resolve binary symlinks before finding its separate .debug file

labath accepted this revision. labath added a comment. Looks fine, just a couple of tweaks to the test case. No need to wait for another round of review. Comment at: packages/Python/lldbsuite/test/linux/sepdebugsymlink/TestTargetSymbolsSepDebugSymlink.py:17 +TestBase.