Author: labath Date: Mon Feb 5 10:03:02 2018 New Revision: 324256 URL: http://llvm.org/viewvc/llvm-project?rev=324256&view=rev Log: Add a comment explaining how the input for GetModuleSpecifications_EarlySectionHeaders was generated
Davide pointed out this would be useful if the file ever needs to be regenerated (and I certainly agree). I also replace the test binary with a slightly smaller one -- I intended to do this in the original commit, but I forgot to add it to the patch as I was juggling several things at the same time. Modified: lldb/trunk/unittests/ObjectFile/ELF/Inputs/early-section-headers.so lldb/trunk/unittests/ObjectFile/ELF/TestObjectFileELF.cpp Modified: lldb/trunk/unittests/ObjectFile/ELF/Inputs/early-section-headers.so URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/unittests/ObjectFile/ELF/Inputs/early-section-headers.so?rev=324256&r1=324255&r2=324256&view=diff ============================================================================== Binary files lldb/trunk/unittests/ObjectFile/ELF/Inputs/early-section-headers.so (original) and lldb/trunk/unittests/ObjectFile/ELF/Inputs/early-section-headers.so Mon Feb 5 10:03:02 2018 differ Modified: lldb/trunk/unittests/ObjectFile/ELF/TestObjectFileELF.cpp URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/unittests/ObjectFile/ELF/TestObjectFileELF.cpp?rev=324256&r1=324255&r2=324256&view=diff ============================================================================== --- lldb/trunk/unittests/ObjectFile/ELF/TestObjectFileELF.cpp (original) +++ lldb/trunk/unittests/ObjectFile/ELF/TestObjectFileELF.cpp Mon Feb 5 10:03:02 2018 @@ -102,6 +102,31 @@ TEST_F(ObjectFileELFTest, SectionsResolv // Test that GetModuleSpecifications works on an "atypical" object file which // has section headers right after the ELF header (instead of the more common // layout where the section headers are at the very end of the object file). +// +// Test file generated with yaml2obj (@svn rev 324254) from the following input: +/* +--- !ELF +FileHeader: + Class: ELFCLASS64 + Data: ELFDATA2LSB + Type: ET_EXEC + Machine: EM_X86_64 + Entry: 0x00000000004003D0 +Sections: + - Name: .note.gnu.build-id + Type: SHT_NOTE + Flags: [ SHF_ALLOC ] + Address: 0x0000000000400274 + AddressAlign: 0x0000000000000004 + Content: 040000001400000003000000474E55001B8A73AC238390E32A7FF4AC8EBE4D6A41ECF5C9 + - Name: .text + Type: SHT_PROGBITS + Flags: [ SHF_ALLOC, SHF_EXECINSTR ] + Address: 0x00000000004003D0 + AddressAlign: 0x0000000000000010 + Content: DEADBEEFBAADF00D +... +*/ TEST_F(ObjectFileELFTest, GetModuleSpecifications_EarlySectionHeaders) { std::string SO = GetInputFilePath("early-section-headers.so"); ModuleSpecList Specs; _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits