asmith updated this revision to Diff 127803.
asmith retitled this revision from "[lldb] Check that a regex is valid before
searching by regex for a symbol in a pdb." to "[lldb] Stop searching for a
symbol in a pdb by regex".
asmith edited the summary of this revision.
Repository:
rL LLVM
http
That seems reasonable. Seems Aaron ran into this not because he was trying
to do a regex search, but because he *wasnt* trying to do a regex search.
So if he doesn’t have immediate need for a regex search, and if it’s not
tested anyway, removing it seems fine
On Wed, Dec 20, 2017 at 10:49 AM Greg C
clayborg added a comment.
If you load a exe file that has a PDB file, people can currently run:
(lldb) type lookup "char*"
If no testing is using the regular expression stuff, then just pull it out. Do
we have unit tests that depend on this working? If not, lets just pull it out
from the Sy
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Looks good, thanks for the making the changes. This will make future tweaks to
reading of file data in object files just a single change in ObjectFile.cpp.
https://reviews.llvm.org/D40079
clayborg added inline comments.
Comment at: tools/debugserver/source/debugserver.cpp:1426
+for (i = 0; (env_entry = host_env[i]) != NULL; ++i)
+ remote->Context().PushEnvironment(env_entry);
+ }
We need to check if the env var is already in the environm
zturner added a comment.
This is another example where we could test it easily if `lldb-test` could dump
this. Are you willing to take a stab at this?
Repository:
rL LLVM
https://reviews.llvm.org/D41427
___
lldb-commits mailing list
lldb-commit
zturner added a comment.
Since it seems like you're going to be doing some work in here, it would be
great if you could update `lldb-test` to dump PDB symbol information. This
would allow us to easily test all sorts of things in here. For example, you
could find a PDB that returned an empty s
zturner accepted this revision.
zturner added a comment.
This revision is now accepted and ready to land.
This looks better. Technically it's possible to break this with some weird
PDBs but I don't think it's possible to do better without using the native
reader.
Repository:
rL LLVM
https:
zturner added inline comments.
Comment at: source/Plugins/SymbolFile/PDB/SymbolFilePDB.cpp:394
+ if (name_str.find_first_of("[]?*.-+\\") != std::string::npos)
+FindTypesByRegex(RegularExpression(name_str), max_matches, types);
else
clayborg wrote:
> You s
labath updated this revision to Diff 127687.
labath added a comment.
Add the suggested MapFileData function
https://reviews.llvm.org/D40079
Files:
include/lldb/Interpreter/OptionValueFileSpec.h
include/lldb/Symbol/ObjectFile.h
include/lldb/Target/Target.h
include/lldb/Utility/DataBuffer
labath updated this revision to Diff 127681.
labath added a comment.
Herald added a subscriber: mgorny.
New version: Make sure we respect variables set by --env and that they are not
overridden by --forward-env (the last part relies on the fact that in the
presence of multiply-defined environment
On Tue, Dec 19, 2017 at 11:54 PM, Adrian Prantl via lldb-commits
wrote:
> Author: adrian
> Date: Tue Dec 19 14:54:37 2017
> New Revision: 321120
>
> URL: http://llvm.org/viewvc/llvm-project?rev=321120&view=rev
> Log:
> Fix a couple of warnings (NFC)
>
Thanks for doing this!
--
Davide
___
12 matches
Mail list logo
