sas added a comment.
Friendly ping.
https://reviews.llvm.org/D39315
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rL317529: Disable tests in lang/c/shared_lib on Windows
(authored by sas).
Repository:
rL LLVM
https://reviews.llvm.org/D39692
Files:
lldb/trunk/packages/Python/lldbsuite/test/lang/c/shared_lib/TestSh
Author: sas
Date: Mon Nov 6 16:14:40 2017
New Revision: 317529
URL: http://llvm.org/viewvc/llvm-project?rev=317529&view=rev
Log:
Disable tests in lang/c/shared_lib on Windows
Summary: These fail because `-fPIC` is not supported on Windows.
Reviewers: zturner, jingham, clayborg
Reviewed By: cla
I think @zturner is correct. Shared libraries do work with lldb on Windows,
just just that these tests are not buildable for Windows.
On Mon, Nov 6, 2017 at 1:56 PM Zachary Turner wrote:
> It’s been a long time since I looked at this but I remember it just being
> a problem in the Makefiles, not
It’s been a long time since I looked at this but I remember it just being a
problem in the Makefiles, not in LLDB. I could be remembering wrong
On Mon, Nov 6, 2017 at 1:44 PM Greg Clayton via Phabricator <
revi...@reviews.llvm.org> wrote:
> clayborg added a comment.
>
> Are we planning on getting
clayborg added a comment.
Are we planning on getting shared libraries working on windows? Or this is just
an expression parser with shared libraries bug? Be nice to file a bug and
mention it if it is something we are planning on fixing.
https://reviews.llvm.org/D39692
__
This revision was automatically updated to reflect the committed changes.
Closed by commit rL317501: Add a dependency from check-lldb on lld (authored by
sas).
Repository:
rL LLVM
https://reviews.llvm.org/D39689
Files:
lldb/trunk/test/CMakeLists.txt
Index: lldb/trunk/test/CMakeLists.txt
=
Author: sas
Date: Mon Nov 6 11:25:33 2017
New Revision: 317501
URL: http://llvm.org/viewvc/llvm-project?rev=317501&view=rev
Log:
Add a dependency from check-lldb on lld
Summary:
This is required when using the in-tree clang for building tests,
because -fuse-ld=lld is used by default.
Subscriber
sas updated this revision to Diff 121760.
sas added a comment.
Move check out of if (TARGET clang) block.
https://reviews.llvm.org/D39689
Files:
test/CMakeLists.txt
Index: test/CMakeLists.txt
===
--- test/CMakeLists.txt
+++ tes
zturner accepted this revision.
zturner added inline comments.
Comment at: test/CMakeLists.txt:116-122
+ if (CMAKE_SYSTEM_NAME MATCHES "Windows")
+if (TARGET lld)
+ add_dependencies(check-lldb lld)
+else ()
+ message(WARNING "lld required to test LLDB on Window
clayborg accepted this revision.
clayborg added a comment.
Do we want to add an option to our build system to try LLD where it is
supported? Doesn't need to be part of this patch, but it would be great to be
able to try it out on ELF based systems.
https://reviews.llvm.org/D39689
__
clayborg added inline comments.
Comment at: source/Plugins/Process/elf-core/ThreadElfCore.h:183
lldb_private::DataExtractor m_vregset_data;
+ lldb_private::DataExtractor m_vsregset_data; /* For PPC VSX registers. */
labath wrote:
> gpregset and fpregset sou
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Looks good.
https://reviews.llvm.org/D39545
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/l
sas updated this revision to Diff 121750.
sas added a comment.
Check only on Windows.
https://reviews.llvm.org/D39689
Files:
test/CMakeLists.txt
Index: test/CMakeLists.txt
===
--- test/CMakeLists.txt
+++ test/CMakeLists.txt
@@
labath requested changes to this revision.
labath added a comment.
This revision now requires changes to proceed.
lld is required for building windows inferiors, but that can't be the case
elsewhere (I don't even have lld checked out). It's possible it gets somehow
auto-selected by clang when yo
Makes sense. I'll update the diff.
On Mon, Nov 6, 2017 at 9:28 AM Zachary Turner wrote:
> This is definitely required, but only on windows. I’d put it behind a
> check for Windows, and I’d also add a check to print a warning/error if
> (TARGET lld) returns false on windows
> On Mon, Nov 6, 2017
sas added a comment.
@davide: I agree, the extra dependency is annoying.
FWIW, I was trying to run tests on Windows and nothing worked because lld
wasn't built. Maybe the behavior is different on Windows and on other hosts? I
just assumed this was the new default because I saw a couple of chang
This is definitely required, but only on windows. I’d put it behind a check
for Windows, and I’d also add a check to print a warning/error if (TARGET
lld) returns false on windows
On Mon, Nov 6, 2017 at 9:22 AM Davide Italiano via Phabricator <
revi...@reviews.llvm.org> wrote:
> davide added a sub
davide added a subscriber: zturner.
davide added a comment.
Not sure lld is the default? I think I always build with bfd (or gold).
I'll check later today when I'm in the office. I'm not against this change per
se, but adding another dependency seems annoying. cc: @zturner
https://reviews.llvm.
labath added a comment.
We were quite successful in the past in creating tiny core files to test these
register contexts. Could you take a look at
`test/testcases/functionalities/postmortem/elf-core/make-core.sh` to see if you
can do the same for your architecture?
Comment a
alexandreyy created this revision.
Herald added subscribers: kbarton, mgorny, nemanjai.
Implement core dump debugging for PPC64le.
https://reviews.llvm.org/D39681
Files:
source/Plugins/Process/Utility/CMakeLists.txt
source/Plugins/Process/Utility/RegisterContextPOSIX_ppc64le.cpp
source/Pl
Author: labath
Date: Mon Nov 6 04:34:27 2017
New Revision: 317474
URL: http://llvm.org/viewvc/llvm-project?rev=317474&view=rev
Log:
Extend android xfail in TestTopLevelExprs
The test fails on API level 19 as well. I'm going to assume that it
fails on every API level below 23.
Modified:
lld
labath created this revision.
Herald added subscribers: kristof.beyls, aemerson.
The test incremented an atomic varible to trigger the watchpoint event.
On arm64 this compiled to a ldaxr/stlxr loop, with the watchpoint being
triggered in the middle of the loop. Hitting the watchpoint resets the
ex
23 matches
Mail list logo
