labath added a comment.

We were quite successful in the past in creating tiny core files to test these 
register contexts. Could you take a look at 
`test/testcases/functionalities/postmortem/elf-core/make-core.sh` to see if you 
can do the same for your architecture?



================
Comment at: source/Plugins/Process/Utility/RegisterContextPOSIX_ppc64le.h:23
+
+class ProcessMonitor;
+class RegisterContextPOSIX_ppc64le : public lldb_private::RegisterContext {
----------------
delete this ?


================
Comment at: source/Plugins/Process/elf-core/ThreadElfCore.h:183
   lldb_private::DataExtractor m_vregset_data;
+  lldb_private::DataExtractor m_vsregset_data; /* For PPC VSX registers. */
 
----------------
gpregset and fpregset sound fairly generic, but these other two sound really 
architecture specific. Since ThreadElfCore does not really do anything with 
these, just pass them to the register context, I'm thinking that we could just 
have a map of all register sets (something like `DenseMap<uint32_t, 
DataExtractor>`). Then we can just pass that to the register context 
constructor, and let it figure out what to do with it. What do you think?


https://reviews.llvm.org/D39681



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
  • [Lldb-commits] ... Alexandre Yukio Yamashita via Phabricator via lldb-commits
    • [Lldb-comm... Pavel Labath via Phabricator via lldb-commits
    • [Lldb-comm... Greg Clayton via Phabricator via lldb-commits
    • [Lldb-comm... Alexandre Yukio Yamashita via Phabricator via lldb-commits
    • [Lldb-comm... Alexandre Yukio Yamashita via Phabricator via lldb-commits
    • [Lldb-comm... Pavel Labath via Phabricator via lldb-commits
    • [Lldb-comm... Alexandre Yukio Yamashita via Phabricator via lldb-commits
    • [Lldb-comm... Alexandre Yukio Yamashita via Phabricator via lldb-commits
    • [Lldb-comm... Pavel Labath via Phabricator via lldb-commits
    • [Lldb-comm... Alexandre Yukio Yamashita via Phabricator via lldb-commits
    • [Lldb-comm... Alexandre Yukio Yamashita via Phabricator via lldb-commits
    • [Lldb-comm... Pavel Labath via Phabricator via lldb-commits

Reply via email to