If that works, let’s just do that. I would much rather make definite
forward progress towards the desired end state than support something
nobody even uses
On Mon, Oct 23, 2017 at 8:24 PM Pavel Labath via Phabricator <
revi...@reviews.llvm.org> wrote:
> labath added a comment.
>
> In https://revie
labath added a comment.
In https://reviews.llvm.org/D39215#904677, @zturner wrote:
> Ok the issue is that you cant use CMake generator expressions in this way.
> This should work though:
>
> if (TARGET clang)
> set(LLDB_DEFAULT_TEST_COMPILER
> "${LLVM_BINARY_DIR}/clang${CMAKE_EXECUTABLE_
zturner added a comment.
Ok the issue is that you cant use CMake generator expressions in this way.
This should work though:
if (TARGET clang)
set(LLDB_DEFAULT_TEST_COMPILER
"${LLVM_BINARY_DIR}/clang${CMAKE_EXECUTABLE_SUFFIX}")
else()
set(LLDB_DEFAULT_TEST_COMPILER "")
endif()
Also worth noting is that the lit site config files only matter for 3-4
tests, which I don’t believe are run anywhere. I plan to overhaul this
whole system in the coming weeks/months, so personally I don’t mind much if
it breaks
On Mon, Oct 23, 2017 at 6:17 PM Zachary Turner via Phabricator <
revi.
zturner added a comment.
In https://reviews.llvm.org/D39215#904615, @zturner wrote:
> In https://reviews.llvm.org/D39215#904578, @labath wrote:
>
> > I've played around with this, but I couldn't get the `lit/lit.site.cfg.in`
> > file to see the expanded values of the `$` generator
> > expressio
zturner added a comment.
In https://reviews.llvm.org/D39215#904578, @labath wrote:
> I've played around with this, but I couldn't get the `lit/lit.site.cfg.in`
> file to see the expanded values of the `$` generator
> expression (the reason it works now is because the file is special-casing
> L
labath added a comment.
I've played around with this, but I couldn't get the `lit/lit.site.cfg.in` file
to see the expanded values of the `$` generator expression
(the reason it works now is because the file is special-casing
LLDB_TEST_CLANG=True). Currently, I do not see how to work around tha
Indeed, that was my point.
As an aside, clang has the —driver-mode option that lets you specify either
gcc or g++, which is in turn equivalent to running clang.exe vs
clang++.exe. Does gcc have this? If so we can require it to be the non ++
version, and then build the driver mode argument as neces
labath added a comment.
In https://reviews.llvm.org/D39215#904536, @labath wrote:
> In https://reviews.llvm.org/D39215#904510, @zturner wrote:
>
> > There is already a CMake variable called `LLDB_TEST_COMPILER`. This
> > `LLDB_TEST_CLANG` was introduced later, I guess unaware of the presence of
labath added a comment.
In https://reviews.llvm.org/D39215#904510, @zturner wrote:
> There is already a CMake variable called `LLDB_TEST_COMPILER`. This
> `LLDB_TEST_CLANG` was introduced later, I guess unaware of the presence of
> `LLDB_TEST_COMPILER`. Would it be possible to standardize on
zturner added a comment.
Yea. Right now there's FOUR different variables to specify the compiler, and
they can all conflict with each other. You can theoretically set
LLDB_TEST_COMPILER=
LLDB_TEST_CLANG=On
LLDB_TEST_C_COMPILER=/usr/bin/cc
LLDB_TEST_CXX_COMPILER=/usr/bin/clang++
This i
davide added a comment.
I think we should just use the `_COMPILER` variant and default to the clang in
tree (wheter possible)
https://reviews.llvm.org/D39215
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/ma
davide accepted this revision.
davide added a comment.
This revision is now accepted and ready to land.
I was going to propose the same :)
Maybe an heads up on lldb-dev?
Thanks!
https://reviews.llvm.org/D39215
___
lldb-commits mailing list
lldb-com
zturner added a comment.
There is already a CMake variable called `LLDB_TEST_COMPILER`. This
`LLDB_TEST_CLANG` was introduced later, I guess unaware of the presence of
`LLDB_TEST_COMPILER`. Would it be possible to standardize on one variable?
This would also mean deleting the `TEST_C_COMPILE
labath created this revision.
Herald added a subscriber: mgorny.
Using the in-tree clang should be the default test configuration as that
is the one compiler that we can be sure everyone has (better
reproducibility of test results). Also, it should hopefully reduce the
impact of pr35040.
https:/
Author: davide
Date: Mon Oct 23 16:17:53 2017
New Revision: 316393
URL: http://llvm.org/viewvc/llvm-project?rev=316393&view=rev
Log:
[lldbtests] Handle errors instead of crashing.
If you pass an invalid compiler/debugger path on the cmdline to `dotest.py`
this is what you get.
Traceback (mos
This revision was automatically updated to reflect the committed changes.
Closed by commit rL316393: [lldbtests] Handle errors instead of crashing.
(authored by davide).
Changed prior to commit:
https://reviews.llvm.org/D39199?vs=119917&id=119965#toc
Repository:
rL LLVM
https://reviews.llvm
Author: labath
Date: Mon Oct 23 16:15:37 2017
New Revision: 316391
URL: http://llvm.org/viewvc/llvm-project?rev=316391&view=rev
Log:
Use ipv4 localhost address in lldb-server tests
Since the ipv6 patch, we've experienced occasional flakyness in
lldb-server tests. This was due to the fact that lld
Author: davide
Date: Mon Oct 23 16:14:17 2017
New Revision: 316390
URL: http://llvm.org/viewvc/llvm-project?rev=316390&view=rev
Log:
[Symbol] Remove dead code. NFCI.
Modified:
lldb/trunk/source/Symbol/Symtab.cpp
Modified: lldb/trunk/source/Symbol/Symtab.cpp
URL:
http://llvm.org/viewvc/llvm-
This fixes a couple of typos that I happened to notice on the web page.
---
www/architecture/index.html | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/www/architecture/index.html b/www/architecture/index.html
index 312476f..0a8a919 100755
--- a/www/architecture/index.html
+++
jingham added a comment.
Will do. I was sick all last week so I have a bit of a backlog, I'll get to
this as soon as I can.
https://reviews.llvm.org/D35556
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mai
labath added a comment.
Hey Jim,
I wrote a couple of new libc++ data formatters in july. You seem to be the data
formatter owner nowadays. Would you mind taking a look?
https://reviews.llvm.org/D35556
___
lldb-commits mailing list
lldb-commits@lis
jasonmolenda added a comment.
I think this is a good idea, thanks for writing the patch Davide.
https://reviews.llvm.org/D39199
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
davide added a comment.
In https://reviews.llvm.org/D39199#904169, @zturner wrote:
> I just wanted to make sure nobody was *already* relying on that behavior. If
> we can get away with being strict, we should be strict.
I agree. From a quick skim I don't see anything really relying on that, b
zturner added a comment.
I just wanted to make sure nobody was *already* relying on that behavior. If
we can get away with being strict, we should be strict.
https://reviews.llvm.org/D39199
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
davide added inline comments.
Comment at: packages/Python/lldbsuite/test/dotest.py:52
def is_exe(fpath):
+"""Returns true if fpath is an executable.
clayborg wrote:
> We could add a default parameter here like:
>
> ```
> def is_exe(fpath, fatal=False):
>
clayborg added inline comments.
Comment at: packages/Python/lldbsuite/test/dotest.py:52
def is_exe(fpath):
+"""Returns true if fpath is an executable.
We could add a default parameter here like:
```
def is_exe(fpath, fatal=False):
if fatal and not os.pa
This revision was automatically updated to reflect the committed changes.
Closed by commit rL316368: Logging: Disable logging after fork() (authored by
labath).
Changed prior to commit:
https://reviews.llvm.org/D38938?vs=119710&id=119920#toc
Repository:
rL LLVM
https://reviews.llvm.org/D389
davide added a comment.
If there are cases where `is_exe` shouldn't be fatal, then we might consider
splitting the utility into two bits (exists & is_exe).
In my mind, if you're checking whether something is executable you should run
the check on a valid entity, and it's up to the caller guarant
Author: labath
Date: Mon Oct 23 12:41:17 2017
New Revision: 316368
URL: http://llvm.org/viewvc/llvm-project?rev=316368&view=rev
Log:
Logging: Disable logging after fork()
Summary:
We had a bug where if we had forked (in the ProcessLauncherPosixFork)
while another thread was writing a log message,
davide added a comment.
Apologies, I generally do (but I forgot this time), let me update the patch.
Repository:
rL LLVM
https://reviews.llvm.org/D39199
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailm
davide updated this revision to Diff 119917.
https://reviews.llvm.org/D39199
Files:
packages/Python/lldbsuite/test/dotest.py
Index: packages/Python/lldbsuite/test/dotest.py
===
--- packages/Python/lldbsuite/test/dotest.py
+++ pac
zturner added a comment.
Can you upload diffs with context in the future?
I'm trying to figure out whether `is_exe` is used for anything where
non-existance should not be considered fatal, but I can't see the rest of the
file here.
Repository:
rL LLVM
https://reviews.llvm.org/D39199
___
davide added inline comments.
Comment at: packages/Python/lldbsuite/test/dotest.py:56
+sys.exit(-1)
return os.path.isfile(fpath) and os.access(fpath, os.X_OK)
lemo wrote:
> minor: can we print quotes around fpath? (this usually helps in messages to
lemo added inline comments.
Comment at: packages/Python/lldbsuite/test/dotest.py:56
+sys.exit(-1)
return os.path.isfile(fpath) and os.access(fpath, os.X_OK)
minor: can we print quotes around fpath? (this usually helps in messages to
avoid confusion
davide created this revision.
If you pass an invalid compiler/debugger path on the cmdline to `dotest.py`
this is what you get.
$ python dotest.py --executable /home/davide/work/build-lldb/bin/lldb
--compiler /home/davide/work/build-lldb/bin/clandasfaasdfsg
Traceback (most recent call last
clayborg added a comment.
Yeah, I meant to suggest to remove that. Remove and submit as needed. Thanks
again.
https://reviews.llvm.org/D38897
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/l
Author: davide
Date: Mon Oct 23 10:51:22 2017
New Revision: 316355
URL: http://llvm.org/viewvc/llvm-project?rev=316355&view=rev
Log:
[lldbtest] Simplify removing an unneeded else. NFCI.
Modified:
lldb/trunk/packages/Python/lldbsuite/test/lldbtest.py
Modified: lldb/trunk/packages/Python/lldbs
hintonda added a comment.
Thanks for all the feedback. I'll report back once I've addressed all your
suggestions.
Thanks again...
https://reviews.llvm.org/D36347
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-
eugene accepted this revision.
eugene added inline comments.
This revision is now accepted and ready to land.
Comment at: source/Utility/Log.cpp:333
+
+void Log::DisableLoggingChild() {
+ for (auto &c: *g_channel_map)
A little comment here describing nature of a
anajuliapc updated this revision to Diff 119885.
anajuliapc added a comment.
- Remove unused enum
https://reviews.llvm.org/D38897
Files:
include/lldb/lldb-enumerations.h
source/Plugins/Process/Linux/NativeRegisterContextLinux_ppc64le.cpp
source/Plugins/Process/Linux/NativeRegisterContextL
anajuliapc added inline comments.
Comment at:
source/Plugins/Process/Linux/NativeRegisterContextLinux_ppc64le.cpp:59
+
+ enum watch_mode {
+write_mode = 1,
I just realized I forgot to remove the enum I've created before. I know you
already accepted this pa
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Looks fine. Thanks for doing the changes.
https://reviews.llvm.org/D38897
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://li
anajuliapc updated this revision to Diff 119847.
anajuliapc marked an inline comment as done.
anajuliapc added a comment.
- Use bitwise OR operator
https://reviews.llvm.org/D38897
Files:
include/lldb/lldb-enumerations.h
source/Plugins/Process/Linux/NativeRegisterContextLinux_ppc64le.cpp
s
gut added inline comments.
Comment at:
source/Plugins/Process/Linux/NativeRegisterContextLinux_ppc64le.cpp:292
+break;
+ case (eWatchpointKindRead + eWatchpointKindWrite):
+rw_mode = PPC_BREAKPOINT_TRIGGER_RW;
As these enums are bitmasks, the traditiona
anajuliapc updated this revision to Diff 119835.
anajuliapc added a comment.
- Switch over read and write eWatchpointKind to match with watch_flags
https://reviews.llvm.org/D38897
Files:
include/lldb/lldb-enumerations.h
source/Plugins/Process/Linux/NativeRegisterContextLinux_ppc64le.cpp
s
46 matches
Mail list logo
