[Lldb-commits] [lldb] r313221 - Commands are -d to break modify, not -C.

2017-09-13 Thread Jim Ingham via lldb-commits
Author: jingham Date: Wed Sep 13 17:27:36 2017 New Revision: 313221 URL: http://llvm.org/viewvc/llvm-project?rev=313221&view=rev Log: Commands are -d to break modify, not -C. The auto-continue test was using the new (better) name for providing commands (-C) but I haven't checked in that change ye

[Lldb-commits] [lldb] r313216 - Forgot to svn add the test cases for breakpoint auto-continue flag.

2017-09-13 Thread Jim Ingham via lldb-commits
Author: jingham Date: Wed Sep 13 16:43:26 2017 New Revision: 313216 URL: http://llvm.org/viewvc/llvm-project?rev=313216&view=rev Log: Forgot to svn add the test cases for breakpoint auto-continue flag. Adding that now. Added: lldb/trunk/packages/Python/lldbsuite/test/functionalities/breakpoi

[Lldb-commits] [lldb] r313210 - Fix for bug 34532 - A few rough corners related to post-mortem debugging (core/minidump)

2017-09-13 Thread Adrian McCarthy via lldb-commits
Author: amccarth Date: Wed Sep 13 15:57:11 2017 New Revision: 313210 URL: http://llvm.org/viewvc/llvm-project?rev=313210&view=rev Log: Fix for bug 34532 - A few rough corners related to post-mortem debugging (core/minidump) The main change is to avoid setting the process state as running when de

[Lldb-commits] [PATCH] D37651: Fix for bug 34532 - A few rough corners related to post-mortem debugging (core/minidump)

2017-09-13 Thread Adrian McCarthy via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL313210: Fix for bug 34532 - A few rough corners related to post-mortem debugging… (authored by amccarth). Changed prior to commit: https://reviews.llvm.org/D37651?vs=115068&id=115132#toc Repository:

[Lldb-commits] [PATCH] D37651: Fix for bug 34532 - A few rough corners related to post-mortem debugging (core/minidump)

2017-09-13 Thread Stephane Sezer via Phabricator via lldb-commits
sas accepted this revision. sas added a comment. This revision is now accepted and ready to land. Seems fine. https://reviews.llvm.org/D37651 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/ll

[Lldb-commits] [PATCH] D37651: Fix for bug 34532 - A few rough corners related to post-mortem debugging (core/minidump)

2017-09-13 Thread Adrian McCarthy via Phabricator via lldb-commits
amccarth added a comment. @sas: Do the latest changes address your concerns with this patch? https://reviews.llvm.org/D37651 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] r313183 - [unittests] Another speculative fix for changes introduced in rL313156

2017-09-13 Thread Vedant Kumar via lldb-commits
Author: vedantk Date: Wed Sep 13 13:03:34 2017 New Revision: 313183 URL: http://llvm.org/viewvc/llvm-project?rev=313183&view=rev Log: [unittests] Another speculative fix for changes introduced in rL313156 Modified: lldb/trunk/unittests/Symbol/TestDWARFCallFrameInfo.cpp Modified: lldb/trunk/u

[Lldb-commits] [lldb] r313181 - [unittests] Speculative fix for changes introduced in rL313156

2017-09-13 Thread Vedant Kumar via lldb-commits
Author: vedantk Date: Wed Sep 13 13:02:24 2017 New Revision: 313181 URL: http://llvm.org/viewvc/llvm-project?rev=313181&view=rev Log: [unittests] Speculative fix for changes introduced in rL313156 Modified: lldb/trunk/unittests/ObjectFile/ELF/TestObjectFileELF.cpp Modified: lldb/trunk/unitte

[Lldb-commits] [PATCH] D37651: Fix for bug 34532 - A few rough corners related to post-mortem debugging (core/minidump)

2017-09-13 Thread Adrian McCarthy via Phabricator via lldb-commits
amccarth accepted this revision. amccarth added a comment. LGTM. Thanks for adding the tests. https://reviews.llvm.org/D37651 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D37651: Fix for bug 34532 - A few rough corners related to post-mortem debugging (core/minidump)

2017-09-13 Thread Leonard Mosescu via Phabricator via lldb-commits
lemo added a comment. @Jim: Good point, I created this bug to track this as you suggested: Bug 34594 - Revisit the failure path for Process::Resume() to avoid leaking Stopped->Running->Stopped events https://reviews.llvm.org/D37651 ___ lldb-commits

[Lldb-commits] [PATCH] D37651: Fix for bug 34532 - A few rough corners related to post-mortem debugging (core/minidump)

2017-09-13 Thread Jim Ingham via Phabricator via lldb-commits
jingham accepted this revision. jingham added a comment. This looks okay for now. It will end up sending a Running & then a Stopped event. That's a little awkward, but that happens in the ordinary course of debugging anyway so it shouldn't freak anybody out. It would be better to find a place

[Lldb-commits] [PATCH] D37651: Fix for bug 34532 - A few rough corners related to post-mortem debugging (core/minidump)

2017-09-13 Thread Leonard Mosescu via Phabricator via lldb-commits
lemo updated this revision to Diff 115068. lemo marked an inline comment as done. lemo added a comment. Adding test coverage https://reviews.llvm.org/D37651 Files: include/lldb/Target/Process.h packages/Python/lldbsuite/test/functionalities/postmortem/elf-core/TestLinuxCore.py packages/