Author: jingham
Date: Wed Jul 19 16:25:42 2017
New Revision: 308549
URL: http://llvm.org/viewvc/llvm-project?rev=308549&view=rev
Log:
Add help text for "expression" telling how to enter multi-line mode.
This seemed natural to us, but wasn't documented anywhere and was
not clear to everybody.
M
clayborg requested changes to this revision.
clayborg added a comment.
So we should just make sure this works:
(lldb) target symbols add --shlib a.out debug_binaries/a.out
The --uuid option is there to help you match up without having to specify the
file path. If I am understanding correctly,
Author: cbieneman
Date: Wed Jul 19 11:57:16 2017
New Revision: 308509
URL: http://llvm.org/viewvc/llvm-project?rev=308509&view=rev
Log:
Fix GreenDragon bots
This commit removes a very old deprecated API that was causing compile failures
for LLDB on Darwin. Since the comment says we only needed t
jingham added a comment.
This isn't about this patch, but replying to:
> debugserver replies to the k packet instead of just dropping the connection -
> stopping code adjusted, although we should probably consider aligning the
> behavior of the two stubs in this case
Especially when dealing wi
jingham requested changes to this revision.
jingham added a comment.
This revision now requires changes to proceed.
This seems like an okay change. You want to make sure that passing the file
name and UUID into AddModuleSymbols doesn't override a UUID mismatch against
the symbol file however yo
clayborg added a comment.
I am not sure how you expect to submit any patches then. Patches must be tested
prior to submission.
https://reviews.llvm.org/D33213
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/m
eugene added a comment.
In https://reviews.llvm.org/D35607#814560, @labath wrote:
> Btw, will this work correctly if we are cross-debugging from a mac? (because
> then we will use the fancy DownloadObjectAndSymbolFile implementation)
Yeah, you're right. I'll move this logic to the CommandObjec
Author: compnerd
Date: Wed Jul 19 08:46:21 2017
New Revision: 308489
URL: http://llvm.org/viewvc/llvm-project?rev=308489&view=rev
Log:
silence a couple of -Wqual-cast warning from GCC (NFC)
Cast to `const uint8_t *` instead of `uint8_t *` to avoid the warning
from GCC.
EmulationStateARM.cpp:20
labath added a comment.
@beanz: It looks like you're doing some debugserver work. :) Any thoughts on
this?
https://reviews.llvm.org/D35311
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb
labath added a comment.
Btw, will this work correctly if we are cross-debugging from a mac? (because
then we will use the fancy DownloadObjectAndSymbolFile implementation)
https://reviews.llvm.org/D35607
___
lldb-commits mailing list
lldb-commits@l
This revision was automatically updated to reflect the committed changes.
Closed by commit rL308480: Expose hit count via SBBreakpointLocation. (authored
by brucem).
Repository:
rL LLVM
https://reviews.llvm.org/D31283
Files:
lldb/trunk/include/lldb/API/SBBreakpointLocation.h
lldb/trunk/p
Author: brucem
Date: Wed Jul 19 07:31:19 2017
New Revision: 308480
URL: http://llvm.org/viewvc/llvm-project?rev=308480&view=rev
Log:
Expose hit count via SBBreakpointLocation.
Summary:
SBBreakpointLocation exposed the ignore count, but didn't expose
the hit count. Both values were exposed by SBBr
brucem updated this revision to Diff 107297.
brucem added a comment.
Update per comments.
https://reviews.llvm.org/D31283
Files:
include/lldb/API/SBBreakpointLocation.h
packages/Python/lldbsuite/test/functionalities/breakpoint/breakpoint_hit_count/Makefile
packages/Python/lldbsuite/test
krytarowski added a comment.
I don't have particular opinion. This change makes code cleaner.
https://reviews.llvm.org/D35618
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
labath created this revision.
The NativeThread class is useless without the containing process (and in
some places it is already assuming the process is always around). This
makes it clear that the NativeProcessProtocol is the object owning the
threads, and makes the destruction order deterministi
labath created this revision.
Herald added subscribers: mgorny, srhines.
Herald added a reviewer: EricWF.
https://reviews.llvm.org/D35615
Files:
packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libcxx/tuple/Makefile
packages/Python/lldbsuite/test/functionalit
labath accepted this revision.
labath added a comment.
The test looks well written. I've added a couple of suggestions you can
consider including.
Comment at:
packages/Python/lldbsuite/test/functionalities/breakpoint/breakpoint_hit_count/TestBreakpointHitCount.py:15
+
+my
brucem added a reviewer: labath.
brucem added a comment.
Pavel, since Jim was okay with this before apart from it not having a test,
want to take a quick look now? Thanks!
https://reviews.llvm.org/D31283
___
lldb-commits mailing list
lldb-commits@l
brucem updated this revision to Diff 107271.
brucem added a comment.
Add a test.
https://reviews.llvm.org/D31283
Files:
include/lldb/API/SBBreakpointLocation.h
packages/Python/lldbsuite/test/functionalities/breakpoint/breakpoint_hit_count/Makefile
packages/Python/lldbsuite/test/function
This revision was automatically updated to reflect the committed changes.
Closed by commit rL308426: Fix typos in documentation. (authored by brucem).
Repository:
rL LLVM
https://reviews.llvm.org/D31282
Files:
lldb/trunk/scripts/interface/SBBreakpoint.i
lldb/trunk/scripts/interface/SBModul
Author: brucem
Date: Wed Jul 19 02:35:58 2017
New Revision: 308426
URL: http://llvm.org/viewvc/llvm-project?rev=308426&view=rev
Log:
Fix typos in documentation.
Reviewers: lldb-commits
Subscribers: lldb-commits
Differential Revision: https://reviews.llvm.org/D31282
Modified:
lldb/trunk/scr
This revision was automatically updated to reflect the committed changes.
Closed by commit rL308425: Update API headers. (authored by brucem).
Repository:
rL LLVM
https://reviews.llvm.org/D35614
Files:
lldb/trunk/include/lldb/API/SBAttachInfo.h
lldb/trunk/include/lldb/API/SBBreakpoint.h
Author: brucem
Date: Wed Jul 19 02:30:04 2017
New Revision: 308425
URL: http://llvm.org/viewvc/llvm-project?rev=308425&view=rev
Log:
Update API headers.
Summary:
* Provide API doc for SBProcess::SaveCore.
* Fix typo in SBAttachInfo doc comments.
* SBBreakpointList: Name some variables same as C++
labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
thanks
https://reviews.llvm.org/D35614
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/l
labath added a reviewer: jingham.
labath added a comment.
I think Jim (or maybe Greg?) should take a look at this.
Right now I'll just comment on the test.
Comment at: packages/Python/lldbsuite/test/linux/add-symbols/Makefile:1
+all: clean
+ mkdir debug_binaries
brucem created this revision.
- Provide API doc for SBProcess::SaveCore.
- Fix typo in SBAttachInfo doc comments.
- SBBreakpointList: Name some variables same as C++.
https://reviews.llvm.org/D35614
Files:
include/lldb/API/SBAttachInfo.h
include/lldb/API/SBBreakpoint.h
include/lldb/API/SB
labath added a comment.
In https://reviews.llvm.org/D33213#814041, @DemiMarie wrote:
> In https://reviews.llvm.org/D33213#813037, @clayborg wrote:
>
> > Before any changes are submitted, we assume you are getting a clean test
> > suite run.
>
>
> On my system, I get build failures in clang.
I
27 matches
Mail list logo
