bgianfo updated this revision to Diff 99844.
bgianfo marked 3 inline comments as done.
bgianfo added a comment.
This iteration addresses Jim's feedback.
I've updated all of the code to match the surrounding style where
I missed it originally. (branches/variable names)
I also moved the command un
jingham requested changes to this revision.
jingham added a comment.
This revision now requires changes to proceed.
The idea is great. I think it is a little confusing that you would do:
(lldb) thread backtrace all
to get all threads but
(lldb) thread unique-stacks
to backtrace the unique s
bgianfo created this revision.
This patch introduces a new thread command "unique-stacks".
The command is based off of "thread backtrace all" but will instead
find all threads which share matching call stacks and de-duplicate
their output, listing call stack and all the threads which share it.
Thi
scott.smith marked an inline comment as done.
scott.smith added a comment.
In https://reviews.llvm.org/D32820#759141, @emaste wrote:
> > Without tcmalloc, on Ubuntu 14.04, 40 core VM: 13%
> > With tcmalloc, on Ubuntu 14.04, 40 core VM: 24% (built using cmake ...
> > -DCMAKE_EXE_LINKER_FLAGS=-lt
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
Close, some minor fixes.
Comment at:
source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp:3293
+ if (custom_params_sp) {
+if (custom
jmajors added a comment.
Addressed more feedback.
https://reviews.llvm.org/D32930
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
jmajors updated this revision to Diff 99788.
jmajors marked 11 inline comments as done.
jmajors added a comment.
CR feedback.
https://reviews.llvm.org/D32930
Files:
unittests/CMakeLists.txt
unittests/tools/CMakeLists.txt
unittests/tools/lldb-server/CMakeLists.txt
unittests/tools/lldb-se
Lgtm
On Mon, May 22, 2017 at 6:49 AM Pavel Labath via Phabricator <
revi...@reviews.llvm.org> wrote:
> labath created this revision.
>
> A change in swig 3.0.9 has caused it to generate modules incompatible
> with us using them as __init__.py (bug #769). Swig 3.0.11 adds a setting
> to help
> fix
ravitheja added inline comments.
Comment at: include/lldb/Host/common/NativeProcessProtocol.h:352
+ lldb::tid_t thread = LLDB_INVALID_THREAD_ID) {
+return Status("Not implemented");
+ }
krytarowski wrote:
> This is Linuxism. Not ever
labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
Committed as r303553. Thanks for the patch.
https://reviews.llvm.org/D33347
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://list
Author: labath
Date: Mon May 22 09:13:38 2017
New Revision: 303553
URL: http://llvm.org/viewvc/llvm-project?rev=303553&view=rev
Log:
Fix incorrect Status -> Error rename in IOHandler
Change 302872 was a massive rename of the Error class to Status.
The change included an incorrect rename of the "
krytarowski added inline comments.
Comment at: include/lldb/Host/common/NativeProcessProtocol.h:352
+ lldb::tid_t thread = LLDB_INVALID_THREAD_ID) {
+return Status("Not implemented");
+ }
This is Linuxism. Not every OS can trace on p
labath added inline comments.
Comment at:
packages/Python/lldbsuite/test/functionalities/process_attach/TestProcessAttach.py:47
+exe = os.path.join('.','newdir','proc_attach')
+self.addTearDownHook(lambda: shutil.rmtree(os.path.join(os.getcwd(
+
-
labath created this revision.
A change in swig 3.0.9 has caused it to generate modules incompatible
with us using them as __init__.py (bug #769). Swig 3.0.11 adds a setting to help
fix this problem, so use that. Support for older versions of swig remains
unaffected.
https://reviews.llvm.org/D334
labath added a comment.
Thank you for taking the time to write the test. Just a couple of more comments
on things I noticed when going through this again:
Comment at:
source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp:3172
+ if (custom_params)
+json_packe
labath added a comment.
Ok, so the comments below are basically a collection of nits. The only two
major issues that still need addressing are:
- getting rid of the sleep in the startup code
- deciding on the naming of members
Comment at: unittests/tools/lldb-server/tests/Mes
ravitheja added a comment.
Sorry I had to update, since the Error class has been changed to Status.
https://reviews.llvm.org/D32585
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
ravitheja updated this revision to Diff 99716.
ravitheja added a comment.
Adding unit tests and making the packets fully JSON.
https://reviews.llvm.org/D32585
Files:
docs/lldb-gdb-remote.txt
include/lldb/API/SBTrace.h
include/lldb/Core/TraceOptions.h
include/lldb/Host/common/NativeProce
18 matches
Mail list logo
