labath added inline comments.
================
Comment at:
packages/Python/lldbsuite/test/functionalities/process_attach/TestProcessAttach.py:47
+ exe = os.path.join('.','newdir','proc_attach')
+ self.addTearDownHook(lambda: shutil.rmtree(os.path.join(os.getcwd())))
+
----------------
emaste wrote:
> shouldn't this be ... `rmtree(os.path.join(os.getcwd(), 'newdir'))` instead?
Probably not because he does a os.chdir(newdir) below. However, that does not
make this a good idea, as you will delete an unexpected directory if the test
fails before you get a chance to chdir. I like the Ed's earlier suggestion to
launch the process from a separate directory more than this.
Repository:
rL LLVM
https://reviews.llvm.org/D32522
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
