jmajors updated this revision to Diff 99365.
jmajors marked 15 inline comments as done.
jmajors added a comment.
Moved asserts to the TEST(), where they'll actually do something.
Made TestClient members warn if their return values go unused.
https://reviews.llvm.org/D32930
Files:
unittests/CM
Yes, though the original code handled the unsuccessful completion cases
slightly differently. I'm not sure how significant that is without pondering
it further and I'm in the middle of something else right now.
Jim
> On May 17, 2017, at 1:31 PM, Pavel Labath via Phabricator
> wrote:
>
> lab
labath added a comment.
I'm not sure I understand what you're saying. Did you mean to say that I should
add the "thread plan didn't successfully complete." (line 5281) block to the
"Halt" branch as well ? (possibly by including it into the factored out
function)
https://reviews.llvm.org/D3328
jingham requested changes to this revision.
jingham added a comment.
This revision now requires changes to proceed.
The first code site did: checking for thread plan success, then check for hit
breakpoint, then for anything else (thread plan failed or other stop reason.)
The code in the first o
Author: ted
Date: Wed May 17 12:48:55 2017
New Revision: 303278
URL: http://llvm.org/viewvc/llvm-project?rev=303278&view=rev
Log:
Fix error string set in AddName to take a StringRef.
Modified:
lldb/trunk/source/Breakpoint/Breakpoint.cpp
Modified: lldb/trunk/source/Breakpoint/Breakpoint.cpp
zturner added inline comments.
Comment at: source/Utility/Status.cpp:81-88
+Status::operator llvm::Error() {
+ if (Success())
+return llvm::Error::success();
+ if (m_type == ErrorType::eErrorTypePOSIX)
+return llvm::errorCodeToError(std::error_code(m_code,
std::generic
labath created this revision.
The function had logic to handle the case when the expression terminated
while we were trying to halt the process, but it failed to take into
account the possibility that the expression stopped because it hit a
breakpoint. This was caused by the fact that the handling
labath updated this revision to Diff 99283.
labath added a comment.
use a separate function instead of a conversion operator
https://reviews.llvm.org/D33241
Files:
include/lldb/Utility/Status.h
source/Utility/Status.cpp
unittests/Utility/StatusTest.cpp
Index: unittests/Utility/StatusTest
Author: labath
Date: Wed May 17 06:47:44 2017
New Revision: 303248
URL: http://llvm.org/viewvc/llvm-project?rev=303248&view=rev
Log:
Make TestConflictingSymbol run on non-darwin targets
For remote targets we need to call registerSharedLibrariesWithTarget to
make sure they are installed alongside
Having the construction accept an Error is probably fine, because you have
to std::move it anyway, which means you know you're giving up ownership
On Wed, May 17, 2017 at 3:08 AM Pavel Labath via Phabricator <
revi...@reviews.llvm.org> wrote:
> labath added a comment.
>
> In https://reviews.llvm.o
labath added a comment.
In https://reviews.llvm.org/D33241#756921, @zturner wrote:
> Mostly just that implicit conversion operators are a very subtle source of
> bugs, and you can't even find where they're being used because it's
> impossible to grep for it.
I agree, and that's why I made the
This revision was automatically updated to reflect the committed changes.
Closed by commit rL303239: [RuntimeDyld] Fix debug section relocation (pr20457)
(authored by labath).
Changed prior to commit:
https://reviews.llvm.org/D32899?vs=98967&id=99257#toc
Repository:
rL LLVM
https://reviews.
12 matches
Mail list logo
