Author: jingham
Date: Fri Mar 31 17:39:55 2017
New Revision: 299276
URL: http://llvm.org/viewvc/llvm-project?rev=299276&view=rev
Log:
DisassembleRange can return an empty DisassemblerSP
check for it.
Modified:
lldb/trunk/source/Target/StackFrame.cpp
Modified: lldb/trunk/source/Target/Stack
Author: penryu
Date: Fri Mar 31 16:03:58 2017
New Revision: 299261
URL: http://llvm.org/viewvc/llvm-project?rev=299261&view=rev
Log:
add more RegisterContext files to xcode project
Modified:
lldb/trunk/lldb.xcodeproj/project.pbxproj
Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj
URL:
h
Author: tberghammer
Date: Fri Mar 31 15:48:00 2017
New Revision: 299259
URL: http://llvm.org/viewvc/llvm-project?rev=299259&view=rev
Log:
Stop calling ValueObject::SetName from synthetic child providers
Summary:
Calling ValueObject::SetName from a sythetic child provider would change
the underyin
This revision was automatically updated to reflect the committed changes.
Closed by commit rL299259: Stop calling ValueObject::SetName from synthetic
child providers (authored by tberghammer).
Changed prior to commit:
https://reviews.llvm.org/D31371?vs=93528&id=93704#toc
Repository:
rL LLVM
labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
Thank you
In https://reviews.llvm.org/D31451#715664, @eugene wrote:
> In https://reviews.llvm.org/D31451#715649, @tberghammer wrote:
>
> > Because of this I think some targeted micro benchmark
This revision was automatically updated to reflect the committed changes.
Closed by commit rL299251: Add support for sythetic operator dereference
(authored by tberghammer).
Changed prior to commit:
https://reviews.llvm.org/D31368?vs=93529&id=93701#toc
Repository:
rL LLVM
https://reviews.ll
Author: tberghammer
Date: Fri Mar 31 15:23:22 2017
New Revision: 299251
URL: http://llvm.org/viewvc/llvm-project?rev=299251&view=rev
Log:
Add support for sythetic operator dereference
Summary:
After this change a sythetic child provider can generate a special child
named "$$dereference$$" what if
This revision was automatically updated to reflect the committed changes.
Closed by commit rL299249: Do not dereference std::unique_ptr by default
(authored by tberghammer).
Changed prior to commit:
https://reviews.llvm.org/D31366?vs=93039&id=93699#toc
Repository:
rL LLVM
https://reviews.ll
Author: tberghammer
Date: Fri Mar 31 15:07:20 2017
New Revision: 299249
URL: http://llvm.org/viewvc/llvm-project?rev=299249&view=rev
Log:
Do not dereference std::unique_ptr by default
Summary:
Displaying the object pointed by the unique_ptr can cause an infinite
recursion when we have a pointer l
eugene added a subscriber: labath.
eugene marked 2 inline comments as done.
eugene added a comment.
In https://reviews.llvm.org/D31451#715649, @tberghammer wrote:
> Because of this I think some targeted micro benchmark will be much more
> useful to measure the performance of this code then an en
eugene updated this revision to Diff 93694.
eugene marked an inline comment as done.
https://reviews.llvm.org/D31451
Files:
source/Plugins/Language/CPlusPlus/CMakeLists.txt
source/Plugins/Language/CPlusPlus/CPlusPlusLanguage.cpp
source/Plugins/Language/CPlusPlus/CPlusPlusLanguage.h
source
eugene updated this revision to Diff 93693.
eugene marked 3 inline comments as done.
eugene added a comment.
Addressing review commnets
https://reviews.llvm.org/D31451
Files:
source/Plugins/Language/CPlusPlus/CMakeLists.txt
source/Plugins/Language/CPlusPlus/CPlusPlusLanguage.cpp
source/Pl
tberghammer added a comment.
One note on benchmarking: A did some performance profiling on LLDB using a
similar approach to what Pavel suggested and if I remember correctly only ~10%
of the time was spent on C++ name parsing (~15% was C++ demangling, ~50% was
debug_info parsing, rest of them wa
This revision was automatically updated to reflect the committed changes.
Closed by commit rL299239: Verify memory address range validity in
GDBRemoteCommunicationClient (authored by sas).
Changed prior to commit:
https://reviews.llvm.org/D31485?vs=93674&id=93685#toc
Repository:
rL LLVM
htt
Author: sas
Date: Fri Mar 31 13:00:48 2017
New Revision: 299239
URL: http://llvm.org/viewvc/llvm-project?rev=299239&view=rev
Log:
Verify memory address range validity in GDBRemoteCommunicationClient
Summary:
This aims to verify the validity of the response from the debugging
server in GDBRemoteCo
xiaobai updated this revision to Diff 93674.
xiaobai added a comment.
Removed extra code in unit test
https://reviews.llvm.org/D31485
Files:
source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp
unittests/Process/gdb-remote/GDBRemoteCommunicationClientTest.cpp
Index: unittest
xiaobai marked an inline comment as done.
xiaobai added a comment.
I'll resubmit after removing the extra code in the test and get somebody to
commit for me.
Comment at:
unittests/Process/gdb-remote/GDBRemoteCommunicationClientTest.cpp:373
+
+ result = std::async(std::launch
labath added a comment.
In https://reviews.llvm.org/D31451#714850, @eugene wrote:
> I did some micro-benchmarking and on average new parser is ~3 time slower
> than the old one. (new parser - ~200k string/s, old parser - ~700k string/s)
> clang::Lexer appears to be the slowest part of it.
>
>
Author: nitesh.jain
Date: Fri Mar 31 06:14:02 2017
New Revision: 299200
URL: http://llvm.org/viewvc/llvm-project?rev=299200&view=rev
Log:
[LLDB][MIPS] Core Dump Support.
Reviewers: labath, emaste
Subscribers: jaydeep, bhushan, lldb-commits, slthakur
Differential Revision: https://reviews.llvm.o
This revision was automatically updated to reflect the committed changes.
Closed by commit rL299200: [LLDB][MIPS] Core Dump Support. (authored by
nitesh.jain).
Changed prior to commit:
https://reviews.llvm.org/D30457?vs=92768&id=93616#toc
Repository:
rL LLVM
https://reviews.llvm.org/D30457
This revision was automatically updated to reflect the committed changes.
Closed by commit rL299199: [LLDB][MIPS] Fix Core file Architecture and OS
information. (authored by nitesh.jain).
Changed prior to commit:
https://reviews.llvm.org/D31280?vs=93130&id=93615#toc
Repository:
rL LLVM
http
Author: nitesh.jain
Date: Fri Mar 31 06:06:25 2017
New Revision: 299199
URL: http://llvm.org/viewvc/llvm-project?rev=299199&view=rev
Log:
[LLDB][MIPS] Fix Core file Architecture and OS information.
Reviewers: labath, clayborg
Subscribers: jaydeep, bhushan, lldb-commits, slthakur
Differential Re
This revision was automatically updated to reflect the committed changes.
Closed by commit rL299196: [LLDB][MIPS] Check if memory_info.GetName() is empty
before finding… (authored by nitesh.jain).
Changed prior to commit:
https://reviews.llvm.org/D30454?vs=91855&id=93614#toc
Repository:
rL L
Author: nitesh.jain
Date: Fri Mar 31 05:55:55 2017
New Revision: 299196
URL: http://llvm.org/viewvc/llvm-project?rev=299196&view=rev
Log:
[LLDB][MIPS] Check if memory_info.GetName() is empty before finding
corresponding module.
Reviewers: labath, clayborg
Subscribers: jaydeep, bhushan, lldb-com
labath accepted this revision.
labath added a comment.
Thank you for adding the test. Lgtm, assuming the second getmemoryregioninfo
call is accidental.
Comment at:
unittests/Process/gdb-remote/GDBRemoteCommunicationClientTest.cpp:373
+
+ result = std::async(std::launch::asyn
On czw, 2017-03-30 at 13:55 -0700, Chris Bieneman wrote:
> I had a talk with Lang about the ExecutionEngine library structuring, and it
> sounds like there are some problems there that need to be worked out.
>
> Luckily for this specific case, I think the solution is actually quite simple:
>
> `
26 matches
Mail list logo
