labath accepted this revision.
labath added a comment.
Thank you for adding the test. Lgtm, assuming the second getmemoryregioninfo
call is accidental.
================
Comment at:
unittests/Process/gdb-remote/GDBRemoteCommunicationClientTest.cpp:373
+
+ result = std::async(std::launch::async, [&] {
+ return client.GetMemoryRegionInfo(addr, region_info);
----------------
This seems out of place. Should we delete it?
https://reviews.llvm.org/D31485
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
