zturner created this revision.
The only real consumer of this is the `Process` class, so it makes sense (both
conceptually and from a layering standpoint) to hide this in the Process plugin.
This is intended to be NFC.
https://reviews.llvm.org/D31172
Files:
lldb/include/lldb/Core/ArchSpec.h
I found it, but in the future would you mind including a link to the
buildbot?
On Mon, Mar 20, 2017 at 9:57 PM Jason Molenda via lldb-commits <
lldb-commits@lists.llvm.org> wrote:
> Author: jmolenda
> Date: Mon Mar 20 23:45:10 2017
> New Revision: 298338
>
> URL: http://llvm.org/viewvc/llvm-proje
Author: zturner
Date: Tue Mar 21 00:47:57 2017
New Revision: 298340
URL: http://llvm.org/viewvc/llvm-project?rev=298340&view=rev
Log:
Resubmit r298334 after fixing OSX build errors.
Hopefully this works, I can't test since I don't have Mac
hardware, however.
Modified:
lldb/trunk/include/lldb
Author: jmolenda
Date: Mon Mar 20 23:45:10 2017
New Revision: 298338
URL: http://llvm.org/viewvc/llvm-project?rev=298338&view=rev
Log:
Revert r298334 until Zachary has a chance to fix the buildbot failure
on macosx.
Modified:
lldb/trunk/include/lldb/Host/FileSystem.h
lldb/trunk/source/Hos
Author: jmolenda
Date: Mon Mar 20 23:34:17 2017
New Revision: 298337
URL: http://llvm.org/viewvc/llvm-project?rev=298337&view=rev
Log:
Fix two places where an arm instruction emulation method
can dereference misaligned memory.
,
Modified:
lldb/trunk/source/Plugins/Instruction/ARM/Emulation
This revision was automatically updated to reflect the committed changes.
Closed by commit rL298334: Delete various lldb FileSystem functions. (authored
by zturner).
Changed prior to commit:
https://reviews.llvm.org/D3?vs=92236&id=92426#toc
Repository:
rL LLVM
https://reviews.llvm.org/D
Author: zturner
Date: Mon Mar 20 23:01:59 2017
New Revision: 298335
URL: http://llvm.org/viewvc/llvm-project?rev=298335&view=rev
Log:
Delete some dead code in HostInfo.
Modified:
lldb/trunk/include/lldb/Host/HostInfoBase.h
lldb/trunk/include/lldb/Host/freebsd/HostInfoFreeBSD.h
lldb/tr
Author: zturner
Date: Mon Mar 20 23:01:04 2017
New Revision: 298334
URL: http://llvm.org/viewvc/llvm-project?rev=298334&view=rev
Log:
Delete various lldb FileSystem functions.
Use LLVM's equivalent versions instead.
Differential Revision: https://reviews.llvm.org/D3
Modified:
lldb/trunk
Author: jmolenda
Date: Mon Mar 20 21:59:15 2017
New Revision: 298333
URL: http://llvm.org/viewvc/llvm-project?rev=298333&view=rev
Log:
Initialize m_allow_cxx, m_allow_objc. These ivars in the base class are not
initialized in the ctor and they're only initialized to 'true' in
ClangUserExpressio
Author: jingham
Date: Mon Mar 20 21:13:50 2017
New Revision: 298331
URL: http://llvm.org/viewvc/llvm-project?rev=298331&view=rev
Log:
FindTypes should find "struct TypeName" as well as "TypeName".
This fixes a bug introduced by r291559. The Module's FindType was
passing the original name not th
This revision was automatically updated to reflect the committed changes.
Closed by commit rL298325: Delete LLDB's MD5 code. Use LLVM instead. (authored
by zturner).
Changed prior to commit:
https://reviews.llvm.org/D31108?vs=9&id=92405#toc
Repository:
rL LLVM
https://reviews.llvm.org/D
Author: zturner
Date: Mon Mar 20 18:55:20 2017
New Revision: 298326
URL: http://llvm.org/viewvc/llvm-project?rev=298326&view=rev
Log:
[Support] Fill the file_status struct with link count.
Differential Revision: https://reviews.llvm.org/D31110
Modified:
lldb/trunk/source/Host/common/File.cpp
Author: zturner
Date: Mon Mar 20 18:54:54 2017
New Revision: 298325
URL: http://llvm.org/viewvc/llvm-project?rev=298325&view=rev
Log:
Delete LLDB's MD5 code. Use LLVM instead.
Differential Revision: https://reviews.llvm.org/D31108
Modified:
lldb/trunk/include/lldb/Host/FileSystem.h
lldb/
Author: zturner
Date: Mon Mar 20 18:54:26 2017
New Revision: 298324
URL: http://llvm.org/viewvc/llvm-project?rev=298324&view=rev
Log:
[analyze-project-deps.py] Add the ability to list all cycles.
This analyzes the dependency graph and computes all minimal
cycles. Equivalent cycles that differ on
Author: zturner
Date: Mon Mar 20 18:33:18 2017
New Revision: 298322
URL: http://llvm.org/viewvc/llvm-project?rev=298322&view=rev
Log:
Add a function to MD5 a file's contents.
In doing so, clean up the MD5 interface a little. Most
existing users only care about the lower 8 bytes of an MD5,
but fo
krytarowski added inline comments.
Comment at: source/Plugins/Process/elf-core/ProcessElfCore.cpp:588
+ }
+} else if (strncmp(note.n_name.c_str(), "OpenBSD", 7) == 0) {
+ m_os = llvm::Triple::OpenBSD;
kettenis wrote:
> krytarowski wrote:
> > `note.n
zturner updated this revision to Diff 92373.
zturner added a comment.
See what you think about this. I've created a folder called `Mocks` under
`Utility`, and created a new target out of it. `UtilityTests` links against
it, and so does `InterpreterTests`. To do this I had to add the lldb proj
Author: jingham
Date: Mon Mar 20 14:21:31 2017
New Revision: 298290
URL: http://llvm.org/viewvc/llvm-project?rev=298290&view=rev
Log:
Get ObjectFileMachO to handle @executable_path
Only do this when we are debugging an executable, since we
don't have a good way to trace from an ObjectFile back to
Author: jingham
Date: Mon Mar 20 14:19:03 2017
New Revision: 298289
URL: http://llvm.org/viewvc/llvm-project?rev=298289&view=rev
Log:
Fix a problem with line tables & .o files that start with code with no line
table entries.
If you have code before the first line table entry when debugging with
krytarowski created this revision.
krytarowski added a project: LLDB.
NetBSD is an ELF platform and it uses Elf Auxiliary Vector like Linux and other
modern BSDs.
While there enable QPassSignals for the NetBSD port as well.
Sponsored by
Repository:
rL LLVM
https://reviews.llvm.org/D31146
sas added a comment.
In https://reviews.llvm.org/D31086#705159, @labath wrote:
> In https://reviews.llvm.org/D31086#704518, @sas wrote:
>
> > The second behavioral change seems good but the first thing you described
> > is a bit odd. Creating folders with 770 does not seem like a common
> > beh
krytarowski added a comment.
I have got a few local changes that conflict with
https://reviews.llvm.org/D31131, this is why I will hold on them unless
@kettenis does not intend to land his patch in the coming days.
Repository:
rL LLVM
https://reviews.llvm.org/D31138
_
krytarowski created this revision.
krytarowski added a project: LLDB.
Herald added a subscriber: mgorny.
This is the base for introduction of further features to support Process
Tracing on NetBSD, in local and remote setup.
This code contains stubs of the needed functions. Their bodies will be a
I thought about something like that too. Let me try to get all these other
patches landed first then I'll think about what to do.
On Mon, Mar 20, 2017 at 9:25 AM Pavel Labath wrote:
> Aha, I see that now. What do you think about creating a test-only module
> that both unit tests can depend on?
Aha, I see that now. What do you think about creating a test-only module
that both unit tests can depend on? The llvm folder-globbing means we would
have to put it in a subfolder (unittests/Utility/lib ?), which makes is
somewhat annoying, but I still think that's better than having the test
code i
Author: labath
Date: Mon Mar 20 11:07:17 2017
New Revision: 298261
URL: http://llvm.org/viewvc/llvm-project?rev=298261&view=rev
Log:
Fix remote test suite directory creation
r298203 make SBPlatform::MakeDirectory less recursive, which breaks the
test suite creation of test directory hierarchy cre
krytarowski created this revision.
krytarowski added a project: LLDB.
NetBSD native threads are printed as 64-bit unsigned integers.
The underlying system type of a thread identity is lwpid_t of type int32_t. For
consistency with Linux and FreeBSD share the 64-bit unsigned integer type.
Reposi
The reason was because two different tests from two different unittest
executables need it, but we have no good way to share code across unittests
like this. Open to suggestions though
On Mon, Mar 20, 2017 at 4:02 AM Pavel Labath via Phabricator <
revi...@reviews.llvm.org> wrote:
> labath added in
krytarowski added inline comments.
Comment at: include/lldb/Host/HostInfo.h:55
+#elif defined(__OpenBSD__)
+#include "lldb/Host/openbsd/HostInfoOpenBSD.h"
+#define HOST_INFO_TYPE HostInfoOpenBSD
kettenis wrote:
> krytarowski wrote:
> > I would sort includes here.
kettenis marked 2 inline comments as done.
kettenis added a comment.
Will revise the diff based on your comments. Thanks!
Comment at: include/lldb/Host/Config.h:35
+
+#include "lldb/Host/openbsd/Config.h"
krytarowski wrote:
> krytarowski wrote:
> > Missing in
labath added inline comments.
Comment at: lldb/include/lldb/Utility/TildeExpressionResolver.h:62
+
+class MockTildeExpressionResolver : public TildeExpressionResolver {
+ llvm::StringRef CurrentUser;
I find it very strange to see the Mock object in a regular hea
labath added a comment.
In https://reviews.llvm.org/D31086#704518, @sas wrote:
> The second behavioral change seems good but the first thing you described is
> a bit odd. Creating folders with 770 does not seem like a common behavior,
> and 700 or 755 is usually more standard.
Don't forget th
labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
cool
https://reviews.llvm.org/D3
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lld
labath accepted this revision.
labath added a comment.
cool
https://reviews.llvm.org/D31108
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
labath added a comment.
Looks like a great start. If you want to continue and get live process
debugging working as well, you should definitely sync up with kamil (i.e. don't
start from ProcessFreeBSD, his process plugin should be a much better starting
point).
In terms of this patch, I have a
35 matches
Mail list logo
