labath added inline comments.

================
Comment at: lldb/include/lldb/Utility/TildeExpressionResolver.h:62
+
+class MockTildeExpressionResolver : public TildeExpressionResolver {
+  llvm::StringRef CurrentUser;
----------------
I find it very strange to see the Mock object in a regular header file (and I 
also don't see a reason why we would need that). Could we get rid of this? 
(perhaps by declaring it in a test-only header file if necessary)


https://reviews.llvm.org/D31129



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to