[Lldb-commits] [lldb] r291949 - Fix TestRegisterVariables for linux arm/arm64 gcc ver > 5

2017-01-13 Thread Omair Javaid via lldb-commits
Author: omjavaid Date: Fri Jan 13 13:28:42 2017 New Revision: 291949 URL: http://llvm.org/viewvc/llvm-project?rev=291949&view=rev Log: Fix TestRegisterVariables for linux arm/arm64 gcc ver > 5 We are going to turn off buffer overflow introduced by gcc by turning off FORTIFY_SOURCE. Differential

[Lldb-commits] [PATCH] D28666: Fix TestRegisterVariables for linux arm/arm64 gcc ver > 5

2017-01-13 Thread Muhammad Omair Javaid via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL291949: Fix TestRegisterVariables for linux arm/arm64 gcc ver > 5 (authored by omjavaid). Changed prior to commit: https://reviews.llvm.org/D28666?vs=84257&id=84342#toc Repository: rL LLVM https://r

[Lldb-commits] [PATCH] D25756: FreeBSD ARM support for software single step.

2017-01-13 Thread Dmitry Mikulin via Phabricator via lldb-commits
dmikulin added a comment. @emaste , any chance to get this committed soon? Repository: rL LLVM https://reviews.llvm.org/D25756 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D28666: Fix TestRegisterVariables for linux arm/arm64 gcc ver > 5

2017-01-13 Thread Todd Fiala via lldb-commits
LGTM. Jim and I also thought this test was incredibly brittle. You really want assembly or something that guarantees that variables will be in registers. On Fri, Jan 13, 2017 at 1:43 AM Pavel Labath via Phabricator < revi...@reviews.llvm.org> wrote: > labath accepted this revision. > > labath ad

[Lldb-commits] [PATCH] D28677: FileSpec: Fix PrependPathComponent("/")

2017-01-13 Thread Pavel Labath via Phabricator via lldb-commits
labath created this revision. labath added reviewers: clayborg, zturner. labath added a subscriber: lldb-commits. PrependPathComponent was unconditionally inserting path separators between the path components. This is not correct if the prepended path is "/", which caused problems down the line. F

[Lldb-commits] [PATCH] D28616: Remove a couple of Stream flags

2017-01-13 Thread Pavel Labath via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL291895: Remove a couple of Stream flags (authored by labath). Changed prior to commit: https://reviews.llvm.org/D28616?vs=84143&id=84267#toc Repository: rL LLVM https://reviews.llvm.org/D28616 Files

[Lldb-commits] [lldb] r291895 - Remove a couple of Stream flags

2017-01-13 Thread Pavel Labath via lldb-commits
Author: labath Date: Fri Jan 13 04:41:59 2017 New Revision: 291895 URL: http://llvm.org/viewvc/llvm-project?rev=291895&view=rev Log: Remove a couple of Stream flags Summary: I came across this while trying to understand what Log::Debug does. It turns out it does not do anything, as there is no in

[Lldb-commits] [PATCH] D28666: Fix TestRegisterVariables for linux arm/arm64 gcc ver > 5

2017-01-13 Thread Pavel Labath via Phabricator via lldb-commits
labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Seems reasonable. Maybe add a comment explaining why is that macro defined. This test is incredibly brittle. I think we should find a better way to test the feature, but I don't really have a

[Lldb-commits] [PATCH] D28666: Fix TestRegisterVariables for linux arm/arm64 gcc ver > 5

2017-01-13 Thread Muhammad Omair Javaid via Phabricator via lldb-commits
omjavaid created this revision. omjavaid added reviewers: tfiala, labath. omjavaid added a subscriber: lldb-commits. Herald added subscribers: rengolin, aemerson. TestRegisterVariables fails with https://reviews.llvm.org/owners/package/1/ level when using gcc version 5.0 or above on arm/arm64 lin

[Lldb-commits] [lldb] r291889 - Fix log typo in ABISysV_arm64.cpp

2017-01-13 Thread Omair Javaid via lldb-commits
Author: omjavaid Date: Fri Jan 13 03:06:58 2017 New Revision: 291889 URL: http://llvm.org/viewvc/llvm-project?rev=291889&view=rev Log: Fix log typo in ABISysV_arm64.cpp This commit fixes a typo in ABISysV_arm64.cpp. Log was reporting a call to ABISysV_x86_64::PrepareTrivialCall. Modified: