LGTM. Jim and I also thought this test was incredibly brittle. You really want assembly or something that guarantees that variables will be in registers.
On Fri, Jan 13, 2017 at 1:43 AM Pavel Labath via Phabricator < revi...@reviews.llvm.org> wrote: > labath accepted this revision. > > labath added a comme > > This revision is now accepted and ready to land. > > > > Seems reasonable. Maybe add a comment explaining why is that macro defined. > > > > This test is incredibly brittle. I think we should find a better way to > test the feature, but I don't really have a good idea so far... > > > > > > https://reviews.llvm.org/D28666 > > > > > > > >
_______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
