Author: jingham
Date: Thu Aug 25 20:27:50 2016
New Revision: 279800
URL: http://llvm.org/viewvc/llvm-project?rev=279800&view=rev
Log:
Make all the Function implementations different so the compiler won't share
them.
Clang on ARM64 was making the three Function methods with identical bodies have
Author: enrico
Date: Thu Aug 25 17:11:01 2016
New Revision: 279784
URL: http://llvm.org/viewvc/llvm-project?rev=279784&view=rev
Log:
Add a notification message in 'type lookup' when the current language doesn't
yield results and one has to go across multiple languages to scan for types
Fixes rda
mgorny added a comment.
That won't work since it would require source dir to be still available when
building LLDB. The point of stand-alone build is to avoid that, and after
applying this patch (and the regex fix), I'm able to achieve that. Using
LLVM_MAIN_SRC_DIR would be a regression.
Repo
mgorny added a comment.
In https://reviews.llvm.org/D23881#525411, @krytarowski wrote:
> In https://reviews.llvm.org/D23881#525405, @mgorny wrote:
>
> > In https://reviews.llvm.org/D23881#525401, @krytarowski wrote:
> >
> > > The proper way to fix it is to install CheckAtomic from LLVM/Clang.
> >
mgorny created this revision.
mgorny added a reviewer: dawn.
mgorny added a subscriber: lldb-commits.
Herald added a subscriber: ki.stfu.
Remove MIUtilParse once https://reviews.llvm.org/D23882 is accepted.
https://reviews.llvm.org/D23883
Files:
tools/lldb-mi/CMakeLists.txt
tools/lldb-mi/MIU
mgorny created this revision.
mgorny added reviewers: krytarowski, Eugene.Zelenko.
mgorny added a subscriber: lldb-commits.
Add cmake/modules directory to cmake module search path as otherwise CMake
fails to find CheckAtomic module when performing standalone build.
// Note: I don't have commit a
mgorny created this revision.
mgorny added a reviewer: dawn.
mgorny added a subscriber: lldb-commits.
Herald added a subscriber: ki.stfu.
Replace uses of the local MIUtilParse::CRegexParser class with the LLVM support
class llvm::Regex. This reduces duplication of code, and makes it possible to
mgorny added a comment.
In https://reviews.llvm.org/D23881#525401, @krytarowski wrote:
> The proper way to fix it is to install CheckAtomic from LLVM/Clang.
>
> See https://reviews.llvm.org/D22999
Wasn't that rejected?
Repository:
rL LLVM
https://reviews.llvm.org/D23881
krytarowski added a comment.
In https://reviews.llvm.org/D23881#525420, @mgorny wrote:
> In https://reviews.llvm.org/D23881#525411, @krytarowski wrote:
>
> > In https://reviews.llvm.org/D23881#525405, @mgorny wrote:
> >
> > > In https://reviews.llvm.org/D23881#525401, @krytarowski wrote:
> > >
>
krytarowski abandoned this revision.
krytarowski added a comment.
Will be addressed in LLVM/Clang.
Repository:
rL LLVM
https://reviews.llvm.org/D22999
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman
krytarowski added a comment.
In https://reviews.llvm.org/D23881#525405, @mgorny wrote:
> In https://reviews.llvm.org/D23881#525401, @krytarowski wrote:
>
> > The proper way to fix it is to install CheckAtomic from LLVM/Clang.
> >
> > See https://reviews.llvm.org/D22999
>
>
> Wasn't that rejected?
joerg accepted this revision.
joerg added a reviewer: joerg.
joerg added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D23830
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org
tfiala created this revision.
tfiala added reviewers: clayborg, labath, jasonmolenda.
tfiala added a subscriber: lldb-commits.
This change does the following:
* Adds three new unit test entries to test handling of $JSON-asyc: packets.
Thanks to Pavel for making that whole section of code easily
krytarowski added a comment.
The proper way to fix it is to install CheckAtomic from LLVM/Clang.
See https://reviews.llvm.org/D22999
Repository:
rL LLVM
https://reviews.llvm.org/D23881
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
ht
Eugene.Zelenko added a comment.
I think will be better to use LLVM_MAIN_SRC_DIR.
https://reviews.llvm.org/D23881
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
dvlahovski added a comment.
I changed all of the `llvm::Optional` returning functions to
return only `const type *`
and signalize for 'failure' by returning a `nullptr`. In the cases where I
return objects (e.g. vector of threads)
I'm still using the `llvm::Optional` pattern.
I also think that u
dvlahovski updated this revision to Diff 69254.
dvlahovski added a comment.
Changed the constructing pattern of MinidumpParser
Now there is a static Create method that returns
and llvm::Optional MinidumpParser.
https://reviews.llvm.org/D23545
Files:
cmake/LLDBDependencies.cmake
source/Plug
labath created this revision.
labath added reviewers: ovyalov, clayborg.
labath added a subscriber: lldb-commits.
Herald added subscribers: danalbert, tberghammer.
Oleksiy is no longer active in LLDB, I'd like to formally assume ownership of
the linux and
android parts.
https://reviews.llvm.org/
Author: labath
Date: Thu Aug 25 03:34:57 2016
New Revision: 279725
URL: http://llvm.org/viewvc/llvm-project?rev=279725&view=rev
Log:
gdb-remote: Make the sequence mutex non-recursive
Summary:
This is a preparatory commit for D22914, where I'd like to replace this mutex
by an R/W lock
(which is a
This revision was automatically updated to reflect the committed changes.
Closed by commit rL279725: gdb-remote: Make the sequence mutex non-recursive
(authored by labath).
Changed prior to commit:
https://reviews.llvm.org/D23802?vs=69088&id=69208#toc
Repository:
rL LLVM
https://reviews.llv
labath added a subscriber: labath.
labath closed this revision.
labath added a comment.
committed in r279724.
https://reviews.llvm.org/D23825
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/ll
Author: labath
Date: Thu Aug 25 03:22:14 2016
New Revision: 279724
URL: http://llvm.org/viewvc/llvm-project?rev=279724&view=rev
Log:
Fix warnings preventing copy elision.
Summary:
Moving a temporary object prevents copy elision, which is exactly
what clang points out by warning about this pattern
22 matches
Mail list logo
