[Lldb-commits] [lldb] r272445 - Add missing #include for linux.

2016-06-10 Thread Greg Clayton via lldb-commits
Author: gclayton Date: Fri Jun 10 18:53:06 2016 New Revision: 272445 URL: http://llvm.org/viewvc/llvm-project?rev=272445&view=rev Log: Add missing #include for linux. Modified: lldb/trunk/source/Target/ThreadCollection.cpp Modified: lldb/trunk/source/Target/ThreadCollection.cpp URL: http

[Lldb-commits] [lldb] r272444 - On MacOSX, the threads can appear out of order at times depending on the order in which the kernel returns thread IDs to debugserver. To avoid thread lists changing ord

2016-06-10 Thread Greg Clayton via lldb-commits
Author: gclayton Date: Fri Jun 10 18:23:34 2016 New Revision: 272444 URL: http://llvm.org/viewvc/llvm-project?rev=272444&view=rev Log: On MacOSX, the threads can appear out of order at times depending on the order in which the kernel returns thread IDs to debugserver. To avoid thread lists chang

[Lldb-commits] [lldb] r272434 - Fixed C++ template integer parameter types to work correctly when the integer type is signed.

2016-06-10 Thread Greg Clayton via lldb-commits
Author: gclayton Date: Fri Jun 10 15:56:09 2016 New Revision: 272434 URL: http://llvm.org/viewvc/llvm-project?rev=272434&view=rev Log: Fixed C++ template integer parameter types to work correctly when the integer type is signed. Prior to this we would display the typename for "TestObj<-1>" as "

[Lldb-commits] [lldb] r272423 - Fixed a few places that were building a regex from an identifier without escaping the identifier text.

2016-06-10 Thread Greg Clayton via lldb-commits
Author: gclayton Date: Fri Jun 10 15:09:33 2016 New Revision: 272423 URL: http://llvm.org/viewvc/llvm-project?rev=272423&view=rev Log: Fixed a few places that were building a regex from an identifier without escaping the identifier text. Modified: lldb/trunk/examples/python/crashlog.py

Re: [Lldb-commits] [PATCH] D20368: Remove Platform usages from NativeProcessLinux

2016-06-10 Thread Pavel Labath via lldb-commits
labath added inline comments. Comment at: source/Plugins/Process/Linux/NativeRegisterContextLinux_mips64.cpp:438 @@ +437,3 @@ +// The auxiliary vector consists of a sequence of key-value pairs, where key and value are of +// the pointer size for the architecture that the

Re: [Lldb-commits] [PATCH] D21221: Fix for PrintStackTraces

2016-06-10 Thread Jim Ingham via lldb-commits
jingham added a subscriber: jingham. jingham added a comment. I agree with Pavel. Remember that most stops in the course of stepping will require an unwind (to tell step-in vrs. lateral step vrs. step out). This can happen many times in the course of a "user level" step. So for stepping, par

Re: [Lldb-commits] [PATCH] D21221: Fix for PrintStackTraces

2016-06-10 Thread Pavel Labath via lldb-commits
labath added a comment. So, I'll let Jason be the definitive judge here, but I have to say I don't like this solution. Computing 10 frames significantly increases the amount of processing needed to get some result. Most importantly, it increases the latency, as it will cause a lot more data to

[Lldb-commits] [lldb] r272407 - SBThread also had some places where it got the ExecutionContext w/o

2016-06-10 Thread Jim Ingham via lldb-commits
Author: jingham Date: Fri Jun 10 12:22:26 2016 New Revision: 272407 URL: http://llvm.org/viewvc/llvm-project?rev=272407&view=rev Log: SBThread also had some places where it got the ExecutionContext w/o taking the API lock. Modified: lldb/trunk/source/API/SBThread.cpp Modified: lldb/trunk/so

Re: [Lldb-commits] [PATCH] Updated documentation for SBAddress

2016-06-10 Thread John Lindal via lldb-commits
I never heard back on this. Should I file a ticket? Thanks, John On Thu, Apr 7, 2016 at 4:59 PM, John Lindal wrote: > The patch is based off the latest code in the github mirror. It includes > some documentation changes for other classes, but the primary change is for > SBAddress. I intend t

Re: [Lldb-commits] [PATCH] D20368: Remove Platform usages from NativeProcessLinux

2016-06-10 Thread Nitesh Jain via lldb-commits
nitesh.jain added inline comments. Comment at: source/Plugins/Process/Linux/NativeRegisterContextLinux_mips64.cpp:438 @@ +437,3 @@ +// The auxiliary vector consists of a sequence of key-value pairs, where key and value are of +// the pointer size for the architecture tha