Author: ovyalov
Date: Fri Apr 8 22:08:02 2016
New Revision: 265869
URL: http://llvm.org/viewvc/llvm-project?rev=265869&view=rev
Log:
Fix TestBreakpointSetRestart failure on Android.
Modified:
lldb/trunk/packages/Python/lldbsuite/test/functionalities/breakpoint/breakpoint_set_restart/TestBr
zturner accepted this revision.
zturner added a comment.
This revision is now accepted and ready to land.
Ahh, you're right, I didn't notice that.
http://reviews.llvm.org/D18912
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.
amccarth added inline comments.
Comment at: packages/Python/lldbsuite/test/lldbtest.py:1994
@@ +1993,3 @@
+# failure and retry.
+def remove_file(file, num_retries = 1, sleep_duration = 0.5):
+while True:
zturner wrote:
> I think the default for `num_retries` s
zturner added inline comments.
Comment at: packages/Python/lldbsuite/test/lldbtest.py:1994
@@ +1993,3 @@
+# failure and retry.
+def remove_file(file, num_retries = 1, sleep_duration = 0.5):
+while True:
I think the default for `num_retries` should be 0. Usual
Author: enrico
Date: Fri Apr 8 17:49:31 2016
New Revision: 265865
URL: http://llvm.org/viewvc/llvm-project?rev=265865&view=rev
Log:
Remove what I believe are the last known instances of formatters that run code
Modified:
lldb/trunk/packages/Python/lldbsuite/test/functionalities/data-formatt
amccarth updated this revision to Diff 53100.
amccarth added a comment.
Consolidated the os.remove and os.unlink calls with a function to do the
retries. Tested on Windows.
http://reviews.llvm.org/D18912
Files:
packages/Python/lldbsuite/test/lldbtest.py
Index: packages/Python/lldbsuite/tes
ChuckR added a subscriber: ChuckR.
ChuckR closed this revision.
ChuckR added a comment.
closed with http://reviews.llvm.org/rL265858
http://reviews.llvm.org/D18880
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-b
clayborg added a comment.
In http://reviews.llvm.org/D18848#395933, @zturner wrote:
> I mean for example if someone calls `FindTypes(..., "char", ...);`
>
> Should a `TypeSP` go into the map?
No you don't have to make one up if you don't have one. At least this is what
the DWARF parser does. T
Author: chuckr
Date: Fri Apr 8 17:17:53 2016
New Revision: 265858
URL: http://llvm.org/viewvc/llvm-project?rev=265858&view=rev
Log:
-thread-info in lldbmi does not conform to protocol. Should end with current
thread id
-thread-info in lldbmi does not conform to protocol. Should end with
current
zturner added a comment.
How about add a function to `lldbsuite\support\fs.py`?
def remove_file(file, num_retries, sleep_duration):
Then just call this everywhere you need to. Could even nuke this whole
`RemoveTempFile` method.
http://reviews.llvm.org/D18912
amccarth created this revision.
amccarth added a reviewer: zturner.
amccarth added a subscriber: lldb-commits.
This solves a flaky test on Windows.
We have similar logic elsewhere for log files. I considered trying to combine
them, but since they are methods of different objects, there wasn't r
zturner added a comment.
I mean for example if someone calls `FindTypes(..., "char", ...);
Should a `TypeSP` go into the map?
http://reviews.llvm.org/D18848
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mai
Author: enrico
Date: Fri Apr 8 16:24:24 2016
New Revision: 265849
URL: http://llvm.org/viewvc/llvm-project?rev=265849&view=rev
Log:
Remove even more of the data formatters that silently run code
Fixes
Modified:
lldb/trunk/include/lldb/DataFormatters/FormattersHelpers.h
lldb/trunk/pac
ovyalov closed this revision.
ovyalov added a comment.
Submitted as http://reviews.llvm.org/rL265843
http://reviews.llvm.org/D18886
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: ovyalov
Date: Fri Apr 8 15:44:28 2016
New Revision: 265843
URL: http://llvm.org/viewvc/llvm-project?rev=265843&view=rev
Log:
Reset continue_after_async only if neither SIGINIT nor SIGSTOP received.
http://reviews.llvm.org/D18886
Added:
lldb/trunk/packages/Python/lldbsuite/test/fun
zturner added a comment.
Greg, what should happen when you look up a builtin type like "char" or
"float"? Is there supposed to be a unique `TypeSP` for this somewhere, with a
unique uid?
http://reviews.llvm.org/D18848
___
lldb-commits mailing lis
ovyalov added a comment.
In http://reviews.llvm.org/D18886#395216, @labath wrote:
> Does this fix an existing test or is a new issue? If it's new (it sounds like
> it is, as I don't see any test failures), could you also add a test for this.
> It shouldn't be too difficult to write one... Would
ovyalov updated this revision to Diff 53054.
ovyalov added a comment.
Added new TestBreakpointSetRestart test to cover the addressed issue.
http://reviews.llvm.org/D18886
Files:
packages/Python/lldbsuite/test/functionalities/breakpoint/breakpoint_set_restart/Makefile
packages/Python/lldbs
tfiala closed this revision.
tfiala added a comment.
Closed with LLDB svn trunk r265829.
http://reviews.llvm.org/D18904
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: tfiala
Date: Fri Apr 8 13:58:07 2016
New Revision: 265829
URL: http://llvm.org/viewvc/llvm-project?rev=265829&view=rev
Log:
Fix #ifdef __APPLE__ code is the swig Python bindings
This code was getting evaluated unintentionally at binding
generation time instead of binding file compilation
tfiala created this revision.
tfiala added a reviewer: clayborg.
tfiala added a subscriber: lldb-commits.
The swig call generates our Python bindings for LLDB. Fix a #if __APPLE___
directive in the type map file to be evaluated at LLDBWrapPython.cpp build time
rather than generation time.
http
Author: tfiala
Date: Fri Apr 8 13:06:11 2016
New Revision: 265821
URL: http://llvm.org/viewvc/llvm-project?rev=265821&view=rev
Log:
fix missing import of 'time' in lldbutil.wait_for_file_on_target
This triggers in some timeout scenarios in the LLDB test suite.
Fixes:
https://bugs.swift.org/brow
Author: enrico
Date: Fri Apr 8 12:55:59 2016
New Revision: 265818
URL: http://llvm.org/viewvc/llvm-project?rev=265818&view=rev
Log:
Append a missing \n
Modified:
lldb/trunk/source/Commands/CommandObjectType.cpp
Modified: lldb/trunk/source/Commands/CommandObjectType.cpp
URL:
http://llvm.org
Author: enrico
Date: Fri Apr 8 12:56:57 2016
New Revision: 265820
URL: http://llvm.org/viewvc/llvm-project?rev=265820&view=rev
Log:
Cleanups to command alias to refer to itself as 'command alias' and not allow
to make aliases starting with a - as that isn't really supported, and is most
often a
Author: enrico
Date: Fri Apr 8 12:56:26 2016
New Revision: 265819
URL: http://llvm.org/viewvc/llvm-project?rev=265819&view=rev
Log:
Add help for our regular expression commands when aliased
Modified:
lldb/trunk/source/Interpreter/CommandInterpreter.cpp
Modified: lldb/trunk/source/Interprete
tfiala added a subscriber: tfiala.
tfiala added a comment.
The exponential back off code forgot to import 'time'. This code will
trigger (and has on our end) a python exception for 'time' missing.
I'm fixing this now.
Repository:
rL LLVM
http://reviews.llvm.org/D18789
___
The exponential back off code forgot to import 'time'. This code will
trigger (and has on our end) a python exception for 'time' missing.
I'm fixing this now.
On Tue, Apr 5, 2016 at 7:13 AM, Tamas Berghammer via lldb-commits <
lldb-commits@lists.llvm.org> wrote:
> This revision was automaticall
zturner accepted this revision.
zturner added a reviewer: zturner.
zturner added a comment.
This revision is now accepted and ready to land.
Looks fine to me. TBH I haven't seen any of the lldb-mi owners around in
months, so I'm not sure if they're still active
http://reviews.llvm.org/D18880
Author: ldrumm
Date: Fri Apr 8 11:52:40 2016
New Revision: 265808
URL: http://llvm.org/viewvc/llvm-project?rev=265808&view=rev
Log:
Remove bad indentation introduced in 263859
This commit touches whitespace only.
This commit was the original intention of the botched 265797
Modified:
lldb/
Author: ldrumm
Date: Fri Apr 8 11:35:58 2016
New Revision: 265799
URL: http://llvm.org/viewvc/llvm-project?rev=265799&view=rev
Log:
Revert bad commit 265797.
Modified:
lldb/trunk/include/lldb/Expression/LLVMUserExpression.h
Modified: lldb/trunk/include/lldb/Expression/LLVMUserExpression.h
U
Author: ldrumm
Date: Fri Apr 8 11:30:55 2016
New Revision: 265797
URL: http://llvm.org/viewvc/llvm-project?rev=265797&view=rev
Log:
Fix indentation for commit 263859.
Modified:
lldb/trunk/include/lldb/Expression/LLVMUserExpression.h
Modified: lldb/trunk/include/lldb/Expression/LLVMUserExpre
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Looks good.
http://reviews.llvm.org/D18886
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/li
jacdavis updated this revision to Diff 53031.
jacdavis added a comment.
last diff missed lldb-mi changes
http://reviews.llvm.org/D18880
Files:
packages/Python/lldbsuite/test/tools/lldb-mi/threadinfo/Makefile
packages/Python/lldbsuite/test/tools/lldb-mi/threadinfo/TestMiThreadInfo.py
packa
jacdavis updated this revision to Diff 53028.
jacdavis added a comment.
Ran formatting tool with lldb format. pthread linker option is still required
for C++11 threads so left it in. New test still disabled for windows.
http://reviews.llvm.org/D18880
Files:
Makefile
TestMiThreadInfo.py
t
Author: tberghammer
Date: Fri Apr 8 09:31:13 2016
New Revision: 265787
URL: http://llvm.org/viewvc/llvm-project?rev=265787&view=rev
Log:
Fix-up LLDB build after rL13179
Modified:
lldb/trunk/source/Symbol/ClangASTContext.cpp
Modified: lldb/trunk/source/Symbol/ClangASTContext.cpp
URL:
http:/
labath added a subscriber: labath.
labath added a comment.
Does this fix an existing test or is a new issue? If it's new (it sounds like
it is, as I don't see any test failures), could you also add a test for this.
It shouldn't be too difficult to write one... Would something like this:
dbg.S
36 matches
Mail list logo
