[Lldb-commits] [lldb] r265200 - Add some unit tests for ClangASTContext.

2016-04-01 Thread Zachary Turner via lldb-commits
Author: zturner Date: Fri Apr 1 18:20:35 2016 New Revision: 265200 URL: http://llvm.org/viewvc/llvm-project?rev=265200&view=rev Log: Add some unit tests for ClangASTContext. In doing so, two bugs were uncovered (and fixed). The first bug is that ClangASTContext::RemoveFastQualifiers() was broke

[Lldb-commits] [lldb] r265196 - Fixed an issue where if we have DWARF in an executable that has multiple languages where these languages use different type systems, you can end up trying to find the a

2016-04-01 Thread Greg Clayton via lldb-commits
Author: gclayton Date: Fri Apr 1 17:57:22 2016 New Revision: 265196 URL: http://llvm.org/viewvc/llvm-project?rev=265196&view=rev Log: Fixed an issue where if we have DWARF in an executable that has multiple languages where these languages use different type systems, you can end up trying to fin

Re: [Lldb-commits] [PATCH] D18519: Allow building LLDB on Windows with MinGW 64/4.9.2 and later

2016-04-01 Thread Zachary Turner via lldb-commits
zturner added a comment. A few minor points left. Most are just CMake indentation issues, so should be easy to fix. A few code changes though. Comment at: CMakeLists.txt:3-5 @@ -2,1 +2,5 @@ +if(MINGW_DEBUG) +# force debugging info into lldb sources +message("-- Buil

Re: [Lldb-commits] [PATCH] D18689: Make FileSpec handling platform-independent

2016-04-01 Thread Zachary Turner via lldb-commits
zturner added a comment. Ugh. The only better way I can think of to do this would be to go into LLVM and rip out all the preprocessor defines, and compile `_windows` and `_posix` versions of every function unconditionally, and then only use the preprocessor defines to do something like: #if

[Lldb-commits] [lldb] r265188 - skip and xfail two std::list-related libcxx tests that fail on OS X with TOT libcxx

2016-04-01 Thread Todd Fiala via lldb-commits
Author: tfiala Date: Fri Apr 1 16:36:58 2016 New Revision: 265188 URL: http://llvm.org/viewvc/llvm-project?rev=265188&view=rev Log: skip and xfail two std::list-related libcxx tests that fail on OS X with TOT libcxx Enrico has a bug on him to make this work across older libcxx list and newer li

[Lldb-commits] [lldb] r265181 - Remove more of the code-running ObjC data formatter support

2016-04-01 Thread Enrico Granata via lldb-commits
Author: enrico Date: Fri Apr 1 15:33:22 2016 New Revision: 265181 URL: http://llvm.org/viewvc/llvm-project?rev=265181&view=rev Log: Remove more of the code-running ObjC data formatter support Modified: lldb/trunk/packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-

[Lldb-commits] [lldb] r265175 - mark TestCallWithTimeout.py XFAIL on macosx.

2016-04-01 Thread Todd Fiala via lldb-commits
Author: tfiala Date: Fri Apr 1 13:42:45 2016 New Revision: 265175 URL: http://llvm.org/viewvc/llvm-project?rev=265175&view=rev Log: mark TestCallWithTimeout.py XFAIL on macosx. This test is failing on the CI but not locally for me. Needs investigation. tracked by: https://llvm.org/bugs/show_bu

Re: [Lldb-commits] [PATCH] D18464: Implement `target modules dump headers`

2016-04-01 Thread Greg Clayton via lldb-commits
clayborg added a comment. In http://reviews.llvm.org/D18464#389612, @zturner wrote: > FWIW I believe we do actually want many of the PE headers, although I have to > say I don't like the format of the output.It seems like we could break > this up into smaller chunks like section headers, pe

Re: [Lldb-commits] [PATCH] D18692: Fix a cornercase in breakpoint reporting

2016-04-01 Thread Jim Ingham via lldb-commits
jingham added a subscriber: jingham. jingham added a comment. The only worry I have about this is - thread A is stopped at a breakpoint, and then we stop on thread B instead, then we report a breakpoint, great! - The user steps thread B, which we do by suspending thread B and stepping A. - Then

[Lldb-commits] [lldb] r265165 - Guard xunit result test class and test method name access to prevent testbot breakage

2016-04-01 Thread Todd Fiala via lldb-commits
Author: tfiala Date: Fri Apr 1 12:59:51 2016 New Revision: 265165 URL: http://llvm.org/viewvc/llvm-project?rev=265165&view=rev Log: Guard xunit result test class and test method name access to prevent testbot breakage http://llvm.org/bugs/show_bug.cgi?id=27179 Modified: lldb/trunk/packages

Re: [Lldb-commits] [PATCH] D18646: Fix DWO breakage in r264909

2016-04-01 Thread Jim Ingham via lldb-commits
> On Apr 1, 2016, at 3:43 AM, Tamas Berghammer wrote: > > tberghammer added a comment. > > This assert is NOT verifying the debug info itself. It is verifying that LLDB > asked the right SymbolFileDWARFDwo to find a DIE based on a DIERef. > Independently of the debug info (what can be garbage

Re: [Lldb-commits] [PATCH] D18464: Implement `target modules dump headers`

2016-04-01 Thread Zachary Turner via lldb-commits
zturner added a subscriber: zturner. zturner added a comment. FWIW I believe we do actually want many of the PE headers, although I have to say I don't like the format of the output.It seems like we could break this up into smaller chunks like section headers, pe headers, binary headers, deb

Re: [Lldb-commits] [PATCH] D18697: Fix a bug in linux core file handling

2016-04-01 Thread Greg Clayton via lldb-commits
clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. See inlined comments. Comment at: source/Plugins/Process/elf-core/ProcessElfCore.cpp:644-647 @@ +643,6 @@ +{ +info.Clear(); +info.SetProcessID(GetID());

Re: [Lldb-commits] [PATCH] D18464: Implement `target modules dump headers`

2016-04-01 Thread Greg Clayton via lldb-commits
clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. I would limit this scope to dumping ObjectFiles since that seems to be what you want. So this command should probably change from: (lldb) target modules dump headers to: (l

Re: [Lldb-commits] [PATCH] D18692: Fix a cornercase in breakpoint reporting

2016-04-01 Thread Greg Clayton via lldb-commits
clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Looks fine. We should probably put the code that checks for a breakpoint at the thread PC into a function since it is done about 5 times in this function. http://reviews.llvm.org/D18692

Re: [Lldb-commits] [PATCH] D18697: Fix a bug in linux core file handling

2016-04-01 Thread Zachary Turner via lldb-commits
What if you are simultaneously debugging 2 processes with the same pid? Does this fail? On Fri, Apr 1, 2016 at 9:06 AM Pavel Labath wrote: > labath created this revision. > labath added reviewers: clayborg, zturner. > labath added a subscriber: lldb-commits. > > There was a bug in linux core file

[Lldb-commits] [PATCH] D18697: Fix a bug in linux core file handling

2016-04-01 Thread Pavel Labath via lldb-commits
labath created this revision. labath added reviewers: clayborg, zturner. labath added a subscriber: lldb-commits. There was a bug in linux core file handling, where if there was a running process with the same process id as the id in the core file, the core file debugging would fail, as we would

Re: [Lldb-commits] [PATCH] D18464: Implement `target modules dump headers`

2016-04-01 Thread Adrian McCarthy via lldb-commits
amccarth added a comment. Ping. http://reviews.llvm.org/D18464 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D18692: Fix a cornercase in breakpoint reporting

2016-04-01 Thread Pavel Labath via lldb-commits
labath updated this revision to Diff 52357. labath added a comment. I've realized that some foreign stubs may not send the "reason" field, so I limit the scope of this change to cases where "signal" is zero as well. http://reviews.llvm.org/D18692 Files: source/Plugins/Process/gdb-remote/Proc

[Lldb-commits] [lldb] r265140 - Fix clean rule for a makefile

2016-04-01 Thread Pavel Labath via lldb-commits
Author: labath Date: Fri Apr 1 07:59:37 2016 New Revision: 265140 URL: http://llvm.org/viewvc/llvm-project?rev=265140&view=rev Log: Fix clean rule for a makefile The test was failing on windows because the clean rule (which is executed even if the test is skipped) returned an error there. Modi

[Lldb-commits] [PATCH] D18692: Fix a cornercase in breakpoint reporting

2016-04-01 Thread Pavel Labath via lldb-commits
labath created this revision. labath added a reviewer: clayborg. labath added a subscriber: lldb-commits. This resolves a similar problem as D16720 (which handled the case when we single-step onto a breakpoint), but this one deals with involutary stops: when we stop a thread (e.g. because anothe

[Lldb-commits] [PATCH] D18689: Make FileSpec handling platform-independent

2016-04-01 Thread Pavel Labath via lldb-commits
labath created this revision. labath added a reviewer: zturner. labath added a subscriber: lldb-commits. Even though FileSpec attempted to handle both kinds of path syntaxes (posix and windows) on both platforms, it relied on the llvm path library to do its work, whose behavior differed on diffe

Re: [Lldb-commits] [PATCH] D18646: Fix DWO breakage in r264909

2016-04-01 Thread Tamas Berghammer via lldb-commits
tberghammer added a comment. This assert is NOT verifying the debug info itself. It is verifying that LLDB asked the right SymbolFileDWARFDwo to find a DIE based on a DIERef. Independently of the debug info (what can be garbage) passed in to LLDB this assert should never fire if LLDB has no maj

[Lldb-commits] [lldb] r265124 - Change a recently added assert into lldbassert

2016-04-01 Thread Pavel Labath via lldb-commits
Author: labath Date: Fri Apr 1 04:57:30 2016 New Revision: 265124 URL: http://llvm.org/viewvc/llvm-project?rev=265124&view=rev Log: Change a recently added assert into lldbassert Modified: lldb/trunk/source/Plugins/SymbolFile/DWARF/SymbolFileDWARFDwo.cpp Modified: lldb/trunk/source/Plugins/