Author: eugenezelenko
Date: Wed Feb 24 20:08:17 2016
New Revision: 261817
URL: http://llvm.org/viewvc/llvm-project?rev=261817&view=rev
Log:
Fix Clang-tidy modernize-use-nullptr and modernize-use-default warnings in
source/Commands/CommandObjectType.cpp; other minor fixes.
Modified:
lldb/trun
We should have a different bug for this since the reason is different. Also
let's try to follow up with clang-cl people as soon as we can to determine
the expected behavior
On Wed, Feb 24, 2016 at 4:28 PM Adrian McCarthy via lldb-commits <
lldb-commits@lists.llvm.org> wrote:
> Author: amccarth
> D
Author: gclayton
Date: Wed Feb 24 18:56:47 2016
New Revision: 261812
URL: http://llvm.org/viewvc/llvm-project?rev=261812&view=rev
Log:
Fix "target modules add -s " to work if the file doesn't exist
locally on the current machine.
Modified:
lldb/trunk/source/Commands/CommandObjectTarget.cp
Author: amccarth
Date: Wed Feb 24 18:24:07 2016
New Revision: 261810
URL: http://llvm.org/viewvc/llvm-project?rev=261810&view=rev
Log:
XFail TestInlines.py on Windows with clang.
Test expects the breakpoint to resolve to three locations, but clang on windows
yields only 2.
llvm.org/pr26710
Mod
This revision was automatically updated to reflect the committed changes.
Closed by commit rL261808: Get register context for the 32-bit process in a
WoW64 process minidump (authored by amccarth).
Changed prior to commit:
http://reviews.llvm.org/D17465?vs=48863&id=48989#toc
Repository:
rL LL
Author: amccarth
Date: Wed Feb 24 18:23:27 2016
New Revision: 261808
URL: http://llvm.org/viewvc/llvm-project?rev=261808&view=rev
Log:
Get register context for the 32-bit process in a WoW64 process minidump
32-bit processes on 64-bit Windows run in a layer called WoW64
(Windows-on-Windows64). If
zturner added a comment.
http://lab.llvm.org:8011/builders/lldb-x86_64-ubuntu-14.04-cmake/builds/11757/steps/test1/logs/stdio
There's the logs for the test that failed.
http://reviews.llvm.org/D17492
___
lldb-commits mailing list
lldb-commits@lists
zturner added a comment.
The non-Windows version of the test actually fails for some reason. I think
it's more likely to be a probelm in the test and not in the C++ side of the
patch, but I'm not sure. Do you by any chance have a Linux box to test on?
(It's not a big problem if you don't, I'
Author: zturner
Date: Wed Feb 24 16:41:04 2016
New Revision: 261800
URL: http://llvm.org/viewvc/llvm-project?rev=261800&view=rev
Log:
xfail case sensitivity test on Linux.
There are two tests in this file. One which only runs on Windows
and tests that you can set a breakpoint with mismatched cas
Author: zturner
Date: Wed Feb 24 16:19:23 2016
New Revision: 261795
URL: http://llvm.org/viewvc/llvm-project?rev=261795&view=rev
Log:
Update the website with lots of new info about building / testing.
Modified:
lldb/trunk/www/build.html
lldb/trunk/www/test.html
Modified: lldb/trunk/www/b
amccarth added inline comments.
Comment at:
source/Plugins/Process/Windows/MiniDump/ProcessWinMiniDump.cpp:238-240
@@ +237,5 @@
+
+// NOTE: We don't currently use the TEB for anything
else. If we need it in
+// the future, the 32-bit TEB
zturner accepted this revision.
This revision is now accepted and ready to land.
Comment at: source/Plugins/Process/Windows/Common/NtStructures.h:18
@@ +17,3 @@
+// only about the position of the TlsSlots.
+struct TEB64
+{
Just as a general tip for future referenc
dawn accepted this revision.
dawn added a comment.
This revision is now accepted and ready to land.
lgtm other than nitpick on formatting. And sorry for delayed review - been
sick.
Comment at:
source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp:559-560
@@ -558,5 +
Author: zturner
Date: Wed Feb 24 15:26:47 2016
New Revision: 261771
URL: http://llvm.org/viewvc/llvm-project?rev=261771&view=rev
Log:
Some fixes for case insensitive paths on Windows.
Paths on Windows are not case-sensitive. Because of this, if a file
is called main.cpp, you should be able to se
Author: gclayton
Date: Wed Feb 24 14:47:13 2016
New Revision: 261768
URL: http://llvm.org/viewvc/llvm-project?rev=261768&view=rev
Log:
Removed unused functions.
Modified:
lldb/trunk/tools/debugserver/source/MacOSX/MachTask.h
lldb/trunk/tools/debugserver/source/MacOSX/MachTask.mm
Modifie
zturner added a comment.
Ahh that could be. In any case when i view the full diff it looks ok. I'll
commit later today, thanks!
http://reviews.llvm.org/D17492
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/ma
Ahh that could be. In any case when i view the full diff it looks ok. I'll
commit later today, thanks!
On Wed, Feb 24, 2016 at 8:00 AM Petr Hons wrote:
> Honsik added a comment.
>
> I have generated it against master branch. I used git reset HEAD~1,
> modified, commited and created patch.
>
> May
Yes, exactly.
Jim
> On Feb 24, 2016, at 4:11 AM, Tamas Berghammer wrote:
>
> tberghammer added a comment.
>
> In http://reviews.llvm.org/D17535#360519, @bhushan wrote:
>
>> In MIPS, we can not put a breakpoint in middle of an atomic sequence.
>> If we do so (and that breakpoint is hit) then c
jingham added a subscriber: jingham.
jingham added a comment.
Yes, exactly.
Jim
Repository:
rL LLVM
http://reviews.llvm.org/D17535
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-comm
tberghammer added a comment.
In http://reviews.llvm.org/D17450#357477, @clayborg wrote:
> We should probably make it such that if a section has the type
> eSectionTypeAbsoluteAddress that we do the right thing inside the following
> functions:
> Section::GetLoadBaseAddress(...);
> Section::Sl
tberghammer updated this revision to Diff 48947.
tberghammer marked an inline comment as done.
http://reviews.llvm.org/D17450
Files:
include/lldb/lldb-enumerations.h
source/Plugins/JITLoader/GDB/JITLoaderGDB.cpp
source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp
source/Plugins/ObjectFile/Mac
Honsik added a comment.
I have generated it against master branch. I used git reset HEAD~1, modified,
commited and created patch.
Maybe the problem was I used the Arcanist for the first diff and then I used
web interface, as you have suggested.
http://reviews.llvm.org/D17492
__
zturner added a subscriber: zturner.
zturner added a comment.
Sorry that comment was a mistake. When you uploaded the most recent diff,
did you generate the diff against your first patch? Or against tip of
trunk? I think you may have generated it against your first patch, but
Phabricator gets c
Sorry that comment was a mistake. When you uploaded the most recent diff,
did you generate the diff against your first patch? Or against tip of
trunk? I think you may have generated it against your first patch, but
Phabricator gets confused and shows the wrong thing in that case.
It should be f
Author: aidandodds
Date: Wed Feb 24 08:17:33 2016
New Revision: 261741
URL: http://llvm.org/viewvc/llvm-project?rev=261741&view=rev
Log:
[Renderscript] Change expression strings to use portable format specifiers.
Mips64 tests were failing on windows because the sscanf implementation differs
betw
tberghammer updated this revision to Diff 48908.
tberghammer added a comment.
I added the memory optimization to represent the case when no DW_AT_start_scope
is specified as an empty range map. This way the memory impact for C/C++ will
be only an empty std::vector per variable.
Regarding the lo
Author: omjavaid
Date: Wed Feb 24 06:17:43 2016
New Revision: 261734
URL: http://llvm.org/viewvc/llvm-project?rev=261734&view=rev
Log:
Fix test for homogeneity in case of aggregate consisting of containerized
vector types
Details can be found here:
Differential revision: http://reviews.llvm.org
This revision was automatically updated to reflect the committed changes.
Closed by commit rL261734: Fix test for homogeneity in case of aggregate
consisting of containerized… (authored by omjavaid).
Changed prior to commit:
http://reviews.llvm.org/D17501?vs=48663&id=48909#toc
Repository:
rL
tberghammer added a comment.
In http://reviews.llvm.org/D17535#360519, @bhushan wrote:
> In MIPS, we can not put a breakpoint in middle of an atomic sequence.
> If we do so (and that breakpoint is hit) then continuing from breakpoint
> address will cause "SC" to fail due to a breakpoint excepti
bhushan added a comment.
In MIPS, we can not put a breakpoint in middle of an atomic sequence.
If we do so (and that breakpoint is hit) then continuing from breakpoint
address will cause "SC" to fail due to a breakpoint exception.
SC fails when there’s been any exception serviced since the LL. Th
Honsik added a comment.
The testsuite passed the same way as master, but no UNEXPECTED SUCCESS.
Please fix the miss spelling directly.
Thanks.
Comment at: source/Host/common/FileSpec.cpp:517
@@ -511,2 +516,2 @@
// If full is false, then if either directory is empty, then
31 matches
Mail list logo
