bhushan created this revision.
bhushan added reviewers: clayborg, tberghammer.
bhushan added subscribers: lldb-commits, jaydeep, nitesh.jain, mohit.bhakkad,
sagar.
bhushan set the repository for this revision to rL LLVM.
This patch handles atomic sequences during single step.
LLDB should treat a
Author: compnerd
Date: Mon Feb 22 22:56:31 2016
New Revision: 261612
URL: http://llvm.org/viewvc/llvm-project?rev=261612&view=rev
Log:
RenderScript: silence some -Wmissing-brace warnings
Silence some -Wmissing-brace warnings on Linux with clang 3.7.
Modified:
lldb/trunk/source/Plugins/Langu
Hello everyone,
LLVM buildmaster will be updated and restarted in few minutes.
Thank you for understanding.
Thanks
Galina
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
sas added a subscriber: sas.
sas added a comment.
Ah, sounds like a cool change. Should we wait until your stuff goes in or
are you still ok with submitting my patch in the meantime?
http://reviews.llvm.org/D17425
___
lldb-commits mailing list
lldb-
Author: eugenezelenko
Date: Mon Feb 22 19:43:44 2016
New Revision: 261602
URL: http://llvm.org/viewvc/llvm-project?rev=261602&view=rev
Log:
Fix Clang-tidy modernize-use-nullptr and modernize-use-default warnings in some
files in source/Commands; other minor fixes.
Modified:
lldb/trunk/source
cameron314 added inline comments.
Comment at: lldb/trunk/source/Host/common/FileSpec.cpp:1179
@@ +1178,3 @@
+
+char child_path[PATH_MAX];
+const int child_path_len = ::snprintf (child_path,
sizeof(child_path), "%s\\%s", dir_path, fileName.c_str());
---
Author: spyffe
Date: Mon Feb 22 18:52:34 2016
New Revision: 261599
URL: http://llvm.org/viewvc/llvm-project?rev=261599&view=rev
Log:
Actually commit the test for r261598.
Added:
lldb/trunk/packages/Python/lldbsuite/test/lang/c/inlines/TestInlines.py
Modified:
lldb/trunk/packages/Python/ll
Author: spyffe
Date: Mon Feb 22 18:51:52 2016
New Revision: 261598
URL: http://llvm.org/viewvc/llvm-project?rev=261598&view=rev
Log:
Fixed a problem where the DWARF for inline functions was mis-parsed.
Inline functions in DWARF have AT_abstract_origin set, but we only handled that
if the function
On Mon, Feb 22, 2016 at 4:14 PM, Adrian McCarthy wrote:
> It looks like this patch reorders the #includes in a way that seems contrary
> to general practice. In particular, if foo.cpp has a header foo.h, then it
> should include foo.h before any other files. This helps ensure that foo.h
> can st
It looks like this patch reorders the #includes in a way that seems
contrary to general practice. In particular, if foo.cpp has a header
foo.h, then it should include foo.h before any other files. This helps
ensure that foo.h can stand alone and won't require clients to have to
figure out what el
zturner updated this revision to Diff 48751.
zturner added a comment.
Updated with more info about using VS and ninja together, and a note about
`python_d` on Windows.
http://reviews.llvm.org/D17521
Files:
www/build.html
www/test.html
Index: www/test.html
=
amccarth added inline comments.
Comment at: lldb/trunk/source/Host/common/FileSpec.cpp:1179
@@ +1178,3 @@
+
+char child_path[PATH_MAX];
+const int child_path_len = ::snprintf (child_path,
sizeof(child_path), "%s\\%s", dir_path, fileName.c_str());
-
cameron314 added inline comments.
Comment at: lldb/trunk/source/Core/Disassembler.cpp:881
@@ -878,3 +880,3 @@
}
-
-FILE *test_file = fopen (file_name, "r");
+FILE *test_file = nullptr;
+#if _WIN32
zturner wrote:
> cameron314 wrote:
> > cameron
Author: eugenezelenko
Date: Mon Feb 22 17:46:47 2016
New Revision: 261593
URL: http://llvm.org/viewvc/llvm-project?rev=261593&view=rev
Log:
Fix Clang-tidy modernize-use-nullptr and modernize-use-default warnings in
source/Commands/CommandObjectCommands.cpp; other minor fixes.
Modified:
lldb/
zturner added a comment.
In http://reviews.llvm.org/D17521#359245, @Honsik wrote:
> Hello, newcomer here.
>
> Thanks zturner for you support.
> Shouldn't best workflow for VS also be mentioned? Like one solution for code
> editing generated by CMake -G "Visual Studio 14" that lacks directory
>
amccarth added inline comments.
Comment at: lldb/trunk/source/Host/common/FileSpec.cpp:1179
@@ +1178,3 @@
+
+char child_path[PATH_MAX];
+const int child_path_len = ::snprintf (child_path,
sizeof(child_path), "%s\\%s", dir_path, fileName.c_str());
-
Honsik added a comment.
Hello, newcomer here.
Thanks zturner for you support.
Shouldn't best workflow for VS also be mentioned? Like one solution for code
editing generated by CMake -G "Visual Studio 14" that lacks directory structure
(mostly CMake + VS issue) and another with custom project co
cameron314 added inline comments.
Comment at: lldb/trunk/tools/driver/Driver.cpp:1289
@@ +1288,3 @@
+// Indicate that all our output is in UTF-8
+SetConsoleCP(CP_UTF8);
+#endif
zturner wrote:
> Is this going to affect the state of the console even after qu
Hello everyone,
Below are some buildbot numbers for the last week of 2/14/2016 - 2/20/2016.
Thanks
Galina
"Status change ratio" by active builder (percent of builds that changed the
builder status from greed to red or from red to green):
buildername
Hello everyone,
Below are some buildbot numbers for the week of 2/07/2016 - 2/13/2016.
Thanks
Galina
"Status change ratio" by active builder (percent of builds that changed the
builder status from greed to red or from red to green):
buildername
zturner added inline comments.
Comment at: lldb/trunk/source/Core/Disassembler.cpp:881
@@ -878,3 +880,3 @@
}
-
-FILE *test_file = fopen (file_name, "r");
+FILE *test_file = nullptr;
+#if _WIN32
cameron314 wrote:
> cameron314 wrote:
> > zturner
amccarth added a comment.
Could you post the patch with full context? It's easier to see the changes in
context.
The information looks right. It's nice to see all the build-Python-yourself
stuff simplified away.
Comment at: www/build.html:63
@@ -64,1 +62,3 @@
+
cameron314 added a comment.
I've addressed more feedback. I'm working on a second version of the patch with
a lot less `#ifdefs` and nicer wrappers (and better error handling where
possible).
Comment at: lldb/trunk/source/Commands/CommandCompletions.cpp:171
@@ -168,1 +170,3 @@
zturner updated this revision to Diff 48737.
zturner added a comment.
Update to include full context.
http://reviews.llvm.org/D17521
Files:
www/build.html
www/test.html
Index: www/test.html
===
--- www/test.html
+++ www/test.h
zturner created this revision.
zturner added reviewers: amccarth, Honsik.
zturner added a subscriber: lldb-commits.
Lots of new info about how to build / test on Windows.
1. Update for VS 2015 and Python 3.5
2. Remove old info about building with Python 2.7
3. Reformat the testing page to make it
zturner added a comment.
This probably seems like a lot of comments, but most of them are pretty minor.
Overall this looks like a good patch. When running the test suite with this
patch, did any tests start showing up as Unexpected Success?
Comment at: packages/Python/lldbsu
amccarth updated this revision to Diff 48712.
amccarth added a comment.
Addressed first round of comments.
http://reviews.llvm.org/D17465
Files:
source/Plugins/Process/Windows/Common/NtStructures.h
source/Plugins/Process/Windows/MiniDump/ProcessWinMiniDump.cpp
Index: source/Plugins/Process
amccarth marked an inline comment as done.
amccarth added a comment.
In http://reviews.llvm.org/D17465#357569, @zturner wrote:
> I'll have to look at this more carefully next week.
Take your time, I'm still working on adding some tests for this.
> I'm guessing the same logic can eventually b
Author: eugenezelenko
Date: Mon Feb 22 13:02:01 2016
New Revision: 261555
URL: http://llvm.org/viewvc/llvm-project?rev=261555&view=rev
Log:
Fix Clang-tidy modernize-use-nullptr and modernize-use-default warnings in
source/Commands/CommandObjectPlatform.cpp; other minor fixes.
Add missing break f
Hi Bhushan,
This looks more like new functionality than a regression fix from 3.7.
As such, I'd rather not merge it to 3.8 this late in the process.
Thanks,
Hans
On Sun, Feb 21, 2016 at 9:08 PM, Bhushan Attarde
wrote:
> Hi Hans,
>
> Could you please add this (r261206) to the release branch?
>
>
ovyalov accepted this revision.
This revision is now accepted and ready to land.
Comment at: source/Plugins/Process/Linux/NativeThreadLinux.cpp:250
@@ +249,3 @@
+log->Printf("NativeThreadLinux::%s Unable to get cpu affinity for
thread %" PRIx64 ": %s", __FUNCTION__,
+
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Looks fine to me.
http://reviews.llvm.org/D17501
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mail
clayborg added a comment.
I would rather do this by modifying the expression locations if at all
possible. I would like to not having to modify each variable to contain a
RangeList as this is extra data per variable. I would be fine if we just add a
new enumeration to the DWARFExpression like S
tberghammer accepted this revision.
tberghammer added a comment.
LGTM
http://reviews.llvm.org/D17510
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
ovyalov accepted this revision.
ovyalov added a comment.
This revision is now accepted and ready to land.
LGTM
http://reviews.llvm.org/D17510
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/ll
This revision was automatically updated to reflect the committed changes.
Closed by commit rL261536: Refactor GetSoftwareBreakpointTrapOpcode (authored
by aidandodds).
Changed prior to commit:
http://reviews.llvm.org/D17395?vs=48324&id=48700#toc
Repository:
rL LLVM
http://reviews.llvm.org/D
Author: aidandodds
Date: Mon Feb 22 11:29:56 2016
New Revision: 261536
URL: http://llvm.org/viewvc/llvm-project?rev=261536&view=rev
Log:
Refactor GetSoftwareBreakpointTrapOpcode
This patch aims to reduce the code duplication among all of the platforms in
GetSoftwareBreakpointTrapOpcode by pushin
labath created this revision.
labath added reviewers: tberghammer, ovyalov.
labath added a subscriber: lldb-commits.
Herald added subscribers: srhines, danalbert, tberghammer.
Signalfd is not used in the code anymore, and given that the same functionality
can be achieved
with the new MainLoop cla
labath created this revision.
labath added reviewers: tberghammer, ovyalov.
labath added a subscriber: lldb-commits.
Herald added subscribers: srhines, danalbert, tberghammer, rengolin, aemerson.
On arm64, linux<=4.4 and Android<=M there is a bug, which prevents
single-stepping from working when
labath updated this revision to Diff 48690.
labath added a comment.
Avoid an unused function warning on non-arm64 arches.
http://reviews.llvm.org/D17509
Files:
source/Plugins/Process/Linux/CMakeLists.txt
source/Plugins/Process/Linux/NativeProcessLinux.cpp
source/Plugins/Process/Linux/Nati
omjavaid added a comment.
Just to mention this simplifies vector return type handling for ARM. A patch
implementing that is following up if this gets approves.
http://reviews.llvm.org/D17501
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
omjavaid created this revision.
omjavaid added a reviewer: clayborg.
omjavaid added a subscriber: lldb-commits.
Herald added a subscriber: aemerson.
This patch ClangASTContext::IsHomogeneousAggregate test for homogeneity in
light of Arm procedure call standard definition of a homogeneous aggregat
tberghammer requested a review of this revision.
tberghammer added a comment.
There is a (minor) difference between a variable being out of scope and having
no location information. Being out of scope means that the variable hasn't
declared yet while having no location information means that the
Author: labath
Date: Mon Feb 22 03:51:32 2016
New Revision: 261519
URL: http://llvm.org/viewvc/llvm-project?rev=261519&view=rev
Log:
Mark TestMiBreak.test_lldbmi_break_insert_function_pending as flaky on linux
Test has become flaky again. Attempts to investigate the triggering commit have
failed
44 matches
Mail list logo
