Re: [Lldb-commits] [PATCH] D16872: Move some of the common decorators to decorators.py

zturner added a comment. Perhaps one possibility to avoid the massive changes to every test file required by changes like this is to make a module like `test_imports.py`, and have that file import all of these things, and then have each test just import `test_imports`. That way we don't have t

Re: [Lldb-commits] [PATCH] D16746: Use an artifical namespace so that member vars do not hide local vars.

sivachandra added a comment. Thanks a lot for the review. I have changed the arg name as suggested. I will put this patch in tomorrow morning so that I can monitor the bots afterwards. http://reviews.llvm.org/D16746 ___ lldb-commits mailing list ll

Re: [Lldb-commits] [PATCH] D16746: Use an artifical namespace so that member vars do not hide local vars.

sivachandra updated this revision to Diff 46861. sivachandra added a comment. Address the arg name change comment. http://reviews.llvm.org/D16746 Files: include/lldb/Symbol/ClangASTContext.h include/lldb/Symbol/CompilerDeclContext.h include/lldb/Symbol/TypeSystem.h packages/Python/lldb

Re: [Lldb-commits] [PATCH] D16746: Use an artifical namespace so that member vars do not hide local vars.

spyffe accepted this revision. spyffe added a comment. This revision is now accepted and ready to land. I suggested a name change; just fix that and I think we're good to go. Comment at: source/Symbol/ClangASTContext.cpp:1893 @@ +1892,3 @@ +{ +ClangASTContext *ast_ctx = Clan

[Lldb-commits] [PATCH] D16872: Move some of the common decorators to decorators.py

zturner created this revision. zturner added reviewers: labath, tberghammer, tfiala. zturner added a subscriber: lldb-commits. Herald added subscribers: srhines, danalbert, tberghammer. This creates the `decorators.py` module and moves some of the low level common decorators there. There are man

[Lldb-commits] [lldb] r259738 - Fix a little threading thinko in StartPrivateStateThread - don't pass stack variables

Author: jingham Date: Wed Feb 3 19:34:33 2016 New Revision: 259738 URL: http://llvm.org/viewvc/llvm-project?rev=259738&view=rev Log: Fix a little threading thinko in StartPrivateStateThread - don't pass stack variables as args to a pthread_create function... Modified: lldb/trunk/include/l

Re: [Lldb-commits] [PATCH] D16746: Use an artifical namespace so that member vars do not hide local vars.

sivachandra added inline comments. Comment at: source/Plugins/ExpressionParser/Clang/ClangExpressionDeclMap.cpp:1381 @@ +1380,3 @@ +clang::NamespaceDecl *namespace_decl = ClangASTContext::GetUniqueNamespaceDeclaration( +m_ast_context,

Re: [Lldb-commits] [PATCH] D16746: Use an artifical namespace so that member vars do not hide local vars.

sivachandra updated this revision to Diff 46852. sivachandra added a comment. Address Sean's comment. http://reviews.llvm.org/D16746 Files: include/lldb/Symbol/ClangASTContext.h include/lldb/Symbol/CompilerDeclContext.h include/lldb/Symbol/TypeSystem.h packages/Python/lldbsuite/test/la

[Lldb-commits] [PATCH] D16868: [lldb] Fix invalid shift operator overload in Scalar

mamai created this revision. mamai added a reviewer: sagar. mamai added a subscriber: lldb-commits. mamai set the repository for this revision to rL LLVM. This also fixes an infinite recursion between lldb_private::operator>> () and Scalar::operator>>= (). Repository: rL LLVM http://reviews.l

Re: [Lldb-commits] [PATCH] D16830: Move some android platform functions to lldbplatformutil

zturner added a comment. r259724 Repository: rL LLVM http://reviews.llvm.org/D16830 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] r259724 - Fix missing module qualification of subprocess.PIPE.

Author: zturner Date: Wed Feb 3 16:53:18 2016 New Revision: 259724 URL: http://llvm.org/viewvc/llvm-project?rev=259724&view=rev Log: Fix missing module qualification of subprocess.PIPE. Modified: lldb/trunk/packages/Python/lldbsuite/test/lldbplatformutil.py Modified: lldb/trunk/packages/Pyt

Re: [Lldb-commits] [PATCH] D16830: Move some android platform functions to lldbplatformutil

I ahad 3 CLs in progress locally and I guess I messed up a merge. There's supposed to be a subprocess.PIPE instead of just PIPE. I'll check in a fix shortly. On Wed, Feb 3, 2016 at 2:51 PM Siva Chandra wrote: > This change broke Android testsuite run: > > http://lab.llvm.org:8011/builders/lldb

Re: [Lldb-commits] [PATCH] D16830: Move some android platform functions to lldbplatformutil

This change broke Android testsuite run: http://lab.llvm.org:8011/builders/lldb-x86_64-ubuntu-14.04-android/builds/5147 On Wed, Feb 3, 2016 at 11:20 AM, Zachary Turner via lldb-commits wrote: > zturner added a comment. > > In http://reviews.llvm.org/D16830#343232, @zturner wrote: > >> In http://r

Re: [Lldb-commits] [PATCH] D16861: Pass socket scheme as part of debug server listen URL

ovyalov closed this revision. ovyalov added a comment. Submitted as http://reviews.llvm.org/rL259714 http://reviews.llvm.org/D16861 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] r259714 - Pass socket scheme as part of debug server listen URL.

Author: ovyalov Date: Wed Feb 3 16:02:43 2016 New Revision: 259714 URL: http://llvm.org/viewvc/llvm-project?rev=259714&view=rev Log: Pass socket scheme as part of debug server listen URL. http://reviews.llvm.org/D16861 Modified: lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommun

Re: [Lldb-commits] [lldb] r259611 - The compiler may use "line number 0" to indicate compiler generated goo that it can't

> On Feb 3, 2016, at 1:58 PM, Zachary Turner wrote: > > I was thinking of a really trivial function that just returned an int or > something. But then again, I don't really know how to write LLVM IR myself > so I was just going off of what other people told me would be possible. I > could b

Re: [Lldb-commits] [lldb] r259611 - The compiler may use "line number 0" to indicate compiler generated goo that it can't

I was thinking of a really trivial function that just returned an int or something. But then again, I don't really know how to write LLVM IR myself so I was just going off of what other people told me would be possible. I could be wrong :) Maybe not worth worrying about if clang never generates

Re: [Lldb-commits] [lldb] r259611 - The compiler may use "line number 0" to indicate compiler generated goo that it can't

For context, here are the relevant LLVM discussions: http://reviews.llvm.org/D16569 (D16569: Emit line 0 line information for interesting 'orphan’ instructions) http://reviews.llvm.org/D9887 [DebugInfo][FastISel] Prevent using debug

Re: [Lldb-commits] [lldb] r259611 - The compiler may use "line number 0" to indicate compiler generated goo that it can't

I asked around a little bit, and it seems like you do this by hand-writing some LLVM IR (limiting yourself to a subset that is sufficiently platform independent) and having clang link that in alongside a regular executable. Then call your LLVM IR function from C++ and step over it. Would that work

Re: [Lldb-commits] [lldb] r259611 - The compiler may use "line number 0" to indicate compiler generated goo that it can't

(Also, if clang is not generating code like this currently, maybe it's not a priority, but seems worth mentioning the technique anyway, since it could have a lot of use for these types of scenarios) On Wed, Feb 3, 2016 at 12:54 PM Zachary Turner wrote: > I asked around a little bit, and it seems

[Lldb-commits] [lldb] r259689 - Fix sign conversion warnings in LLDB Python unittests

Author: rnk Date: Wed Feb 3 14:48:09 2016 New Revision: 259689 URL: http://llvm.org/viewvc/llvm-project?rev=259689&view=rev Log: Fix sign conversion warnings in LLDB Python unittests Modified: lldb/trunk/unittests/ScriptInterpreter/Python/PythonDataObjectsTests.cpp Modified: lldb/trunk/uni

[Lldb-commits] [lldb] r259686 - [NetBSD] Remove dead code.

Author: davide Date: Wed Feb 3 14:13:50 2016 New Revision: 259686 URL: http://llvm.org/viewvc/llvm-project?rev=259686&view=rev Log: [NetBSD] Remove dead code. PR: http://reviews.llvm.org/D16818 Modified: lldb/trunk/source/Plugins/Process/Utility/RegisterContextNetBSD_x86_64.cpp

[Lldb-commits] [lldb] r259685 - Remove a stray ;.

Author: jingham Date: Wed Feb 3 13:49:03 2016 New Revision: 259685 URL: http://llvm.org/viewvc/llvm-project?rev=259685&view=rev Log: Remove a stray ;. Modified: lldb/trunk/source/Target/Thread.cpp Modified: lldb/trunk/source/Target/Thread.cpp URL: http://llvm.org/viewvc/llvm-project/lldb/t

[Lldb-commits] [lldb] r259684 - The SetStopInfo from a Mach Exception was setting the stop

Author: jingham Date: Wed Feb 3 13:45:31 2016 New Revision: 259684 URL: http://llvm.org/viewvc/llvm-project?rev=259684&view=rev Log: The SetStopInfo from a Mach Exception was setting the stop reason to None when we stop due to a trace, then noticed that we were on a breakpoint that was not valid

Re: [Lldb-commits] [PATCH] D16830: Move some android platform functions to lldbplatformutil

zturner added a comment. In http://reviews.llvm.org/D16830#343232, @zturner wrote: > In http://reviews.llvm.org/D16830#342842, @tberghammer wrote: > > > Looks reasonable and I agree with Pavel in the idea of moving the android > > related utility functions into their own file for better separati

[Lldb-commits] [lldb] r259680 - Move some android platform functions to lldbplatformutil.

Author: zturner Date: Wed Feb 3 13:12:30 2016 New Revision: 259680 URL: http://llvm.org/viewvc/llvm-project?rev=259680&view=rev Log: Move some android platform functions to lldbplatformutil. My eventual goal is to move all of the test decorators to their own module such as `decorators.py`. But

Re: [Lldb-commits] [PATCH] D16830: Move some android platform functions to lldbplatformutil

This revision was automatically updated to reflect the committed changes. Closed by commit rL259680: Move some android platform functions to lldbplatformutil. (authored by zturner). Changed prior to commit: http://reviews.llvm.org/D16830?vs=46721&id=46806#toc Repository: rL LLVM http://revi

[Lldb-commits] [PATCH] D16861: Pass socket scheme as part of debug server listen URL

ovyalov created this revision. ovyalov added reviewers: sivachandra, tberghammer. ovyalov added a subscriber: lldb-commits. Pass socket scheme as part of debug server listen URL in order to fix custom protocols like unix-abstract. http://reviews.llvm.org/D16861 Files: source/Plugins/Process/g

Re: [Lldb-commits] [PATCH] D16814: Fix handling of the arm IT instruction in the unwinder

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. Yes, it was probably too complex. My main objection was the use of the UINT32_MAX as a magic number. Your UnconditionalCondition solution clears this up. Comme

Re: [Lldb-commits] [PATCH] D16840: [LLDB][MIPS] Generalise MIPS arch names

zturner added a comment. Correction: If he's using expectedFailureAll, only the 'triple=' keyword will take a regex. Repository: rL LLVM http://reviews.llvm.org/D16840 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.or

Re: [Lldb-commits] [PATCH] D16840: [LLDB][MIPS] Generalise MIPS arch names

I know this is super confusing but `expectedFailureAll` doesn't yet support regular expressions. I'm working on this code as we speak, so it will soon. But what you're probably thinking of is `skipUnlessArch` (but ironically not `skipIfArch` or `expectedFailureArch`). AH. Anyway, that's

Re: [Lldb-commits] [PATCH] D16840: [LLDB][MIPS] Generalise MIPS arch names

clayborg accepted this revision. clayborg added a comment. I believe we recently switched "archs" so that we auto detect the type so you could use a regular expression. See above inlined comments. Good to go unless you want to adopt any of my inlined suggestions. Comment at:

Re: [Lldb-commits] [PATCH] D16830: Move some android platform functions to lldbplatformutil

zturner marked 2 inline comments as done. zturner added a comment. In http://reviews.llvm.org/D16830#342842, @tberghammer wrote: > Looks reasonable and I agree with Pavel in the idea of moving the android > related utility functions into their own file for better separation I thought about cre

Re: [Lldb-commits] [PATCH] D16853: Use BKPT instead of UDF for arm/thumb breakpoints

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. There are immediate values you can play around with inside the BKPT instruction of both ARM and Thumb versions so that the two least significant bytes are the same: static const

Re: [Lldb-commits] [PATCH] D16858: Add verbose logging support to gdb-remote tests

tfiala accepted this revision. tfiala added a comment. This revision is now accepted and ready to land. LGTM. BTW I was planning on re-organizing the lldb-server/debugserver tests sometime in the near future to break them into many different directories and pull off the dsym/dwarf/dwo changes f

Re: [Lldb-commits] [PATCH] D16814: Fix handling of the arm IT instruction in the unwinder

labath added a comment. I agree that we should not over-engineer things. I'll leave the decision up to others... http://reviews.llvm.org/D16814 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo

[Lldb-commits] [PATCH] D16858: Add verbose logging support to gdb-remote tests

labath created this revision. labath added reviewers: tfiala, tberghammer. labath added a subscriber: lldb-commits. gdb-remote tests are not able to use the same logging mechanisms as the rest of our tests, and currently we get no host logs from them, even though the tests themselves have loggin

Re: [Lldb-commits] [PATCH] D16825: [Windows] Set correct thread stop info when single-step lands on a breakpoint

Ah, I missed the "not_in" in that decorator. Thanks. On Wed, Feb 3, 2016 at 1:38 AM, Pavel Labath wrote: > On 2 February 2016 at 23:08, Adrian McCarthy via lldb-commits > wrote: > > Thanks for the confirmation. I'm still not sure how > TestConsecutiveBreakpoints.py used to work on Windows, bu

Re: [Lldb-commits] [PATCH] D16840: [LLDB][MIPS] Generalise MIPS arch names

Looks fine to me On Tue, Feb 2, 2016 at 11:57 PM Nitesh Jain wrote: > nitesh.jain updated this revision to Diff 46750. > nitesh.jain added a comment. > > Update the diff with suggested changes > > > Repository: > rL LLVM > > http://reviews.llvm.org/D16840 > > Files: > > packages/Python/lldbsui

[Lldb-commits] [PATCH] D16853: Use BKPT instead of UDF for arm/thumb breakpoints

tberghammer created this revision. tberghammer added reviewers: clayborg, omjavaid. tberghammer added a subscriber: lldb-commits. Herald added subscribers: rengolin, aemerson. Use BKPT instead of UDF for arm/thumb breakpoints The UDF instruction is deprecated in armv7 and in case of thumb2 instru

Re: [Lldb-commits] [PATCH] D16746: Use an artifical namespace so that member vars do not hide local vars.

sivachandra added a comment. In http://reviews.llvm.org/D16746#342507, @spyffe wrote: > Siva, I've inlined my comments. I believe there's a misunderstanding about > what role //this// has in the patched version of > GetUniqueNamespaceDeclaration. In fact, as I argue in my inline comment, > /

Re: [Lldb-commits] [PATCH] D15527: Add ability to override JIT expr compiler options.

This revision was automatically updated to reflect the committed changes. Closed by commit rL259644: Add ability to override JIT expr compiler options. (authored by aidandodds). Changed prior to commit: http://reviews.llvm.org/D15527?vs=45588&id=46769#toc Repository: rL LLVM http://reviews.

[Lldb-commits] [lldb] r259644 - Add ability to override JIT expr compiler options.

Author: aidandodds Date: Wed Feb 3 06:33:05 2016 New Revision: 259644 URL: http://llvm.org/viewvc/llvm-project?rev=259644&view=rev Log: Add ability to override JIT expr compiler options. Runtimes should be able to pass custom compilation options to the JIT for their stack frame. This patch adds

Re: [Lldb-commits] [PATCH] D16830: Move some android platform functions to lldbplatformutil

tberghammer accepted this revision. tberghammer added a comment. Looks reasonable and I agree with Pavel in the idea of moving the android related utility functions into their own file for better separation Comment at: packages/Python/lldbsuite/test/lldbplatformutil.py:73-81 @@

[Lldb-commits] [lldb] r259642 - Remove skipUnlessListedRemote test decorator

Author: labath Date: Wed Feb 3 05:51:25 2016 New Revision: 259642 URL: http://llvm.org/viewvc/llvm-project?rev=259642&view=rev Log: Remove skipUnlessListedRemote test decorator This decorator was used in only one test, and it's behaviour was quite complicated. It skipped if: - test was remote -

Re: [Lldb-commits] [PATCH] D16814: Fix handling of the arm IT instruction in the unwinder

tberghammer updated this revision to Diff 46764. tberghammer added a comment. Create a typedef for the condition type and a static const value for the unconditional condition. http://reviews.llvm.org/D16814 Files: include/lldb/Core/EmulateInstruction.h include/lldb/Symbol/UnwindPlan.h so

[Lldb-commits] [lldb] r259638 - Fix an off-by-one in SocketTest::DecodeHostAndPort

Author: labath Date: Wed Feb 3 05:12:23 2016 New Revision: 259638 URL: http://llvm.org/viewvc/llvm-project?rev=259638&view=rev Log: Fix an off-by-one in SocketTest::DecodeHostAndPort 65535 is still a valid port. This should fix the android failures we were getting when we chose to connect over

Re: [Lldb-commits] [PATCH] D16830: Move some android platform functions to lldbplatformutil

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Seems to be working after applying the fixes below. I was considering whether this shouldn't be moved to an even more platform-specific file (say `androidutil.py` or something), but I'll leave

Re: [Lldb-commits] [PATCH] D16825: [Windows] Set correct thread stop info when single-step lands on a breakpoint

On 2 February 2016 at 23:08, Adrian McCarthy via lldb-commits wrote: > Thanks for the confirmation. I'm still not sure how > TestConsecutiveBreakpoints.py used to work on Windows, but I believe this is > the right fix. The test used to be marked with "@expectedFailureAll("llvm.org/pr23478", os

[Lldb-commits] [lldb] r259634 - [RenderScript] Use LLVM DWARF language enum

Author: ewancrawford Date: Wed Feb 3 03:17:03 2016 New Revision: 259634 URL: http://llvm.org/viewvc/llvm-project?rev=259634&view=rev Log: [RenderScript] Use LLVM DWARF language enum A DWARF language vender extension for RenderScript was added to LLVM in r259348(http://reviews.llvm.org/D16409) W

Re: [Lldb-commits] [PATCH] D16766: [RenderScript] Use LLVM DWARF language enum

This revision was automatically updated to reflect the committed changes. Closed by commit rL259634: [RenderScript] Use LLVM DWARF language enum (authored by EwanCrawford). Changed prior to commit: http://reviews.llvm.org/D16766?vs=46656&id=46755#toc Repository: rL LLVM http://reviews.llvm.