sivachandra added a comment. In http://reviews.llvm.org/D16746#342507, @spyffe wrote:
> Siva, I've inlined my comments. I believe there's a misunderstanding about > what role //this// has in the patched version of > GetUniqueNamespaceDeclaration. In fact, as I argue in my inline comment, > //this// is unused. That's confusing code. You can achieve the same effect > by leaving the code as is and just passing the right thing in for //this//. This comment clears it up for me. I now follow and agree with the rest of your inline comments. Will send the updated patch as soon as I can get to this. Thanks, Siva Chandra http://reviews.llvm.org/D16746 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
