Re: [Lldb-commits] [lldb] r257644 - Fix an issue where scripted commands would not actually print any of their output if an immediate output file was set in the result object via a Python file object

Please see attached log file. Thanks, Ying On Wed, Jan 13, 2016 at 5:39 PM, Enrico Granata wrote: > From the buildbot log it’s quite hard to tell what could be going on > > Is there any chance you guys could run the test by hand with the “-t -v” > flags to the dotest.py driver and attach the ou

Re: [Lldb-commits] [lldb] r257644 - Fix an issue where scripted commands would not actually print any of their output if an immediate output file was set in the result object via a Python file object

From the buildbot log it’s quite hard to tell what could be going on Is there any chance you guys could run the test by hand with the “-t -v” flags to the dotest.py driver and attach the output of the run? That might help figure out where the issue lies > On Jan 13, 2016, at 5:35 PM, Ying Chen

Re: [Lldb-commits] [lldb] r257644 - Fix an issue where scripted commands would not actually print any of their output if an immediate output file was set in the result object via a Python file object

Hello Enrico, The new test has been failing on Ubuntu buildbot. But it's passing on some offline Ubuntu machines, I don't understand what caused the difference. Could you please help to take a look? http://lab.llvm.org:8011/builders/lldb-x86_64-ubuntu-14.04-cmake/builds/10299 Thanks, Ying On We

[Lldb-commits] [lldb] r257717 - change Xcode test run default to ignore xpass on Xunit output

Author: tfiala Date: Wed Jan 13 17:55:16 2016 New Revision: 257717 URL: http://llvm.org/viewvc/llvm-project?rev=257717&view=rev Log: change Xcode test run default to ignore xpass on Xunit output The Green Dragon LLVM builders are starting to parse xunit output on LLDB Xcode builders. By default

Re: [Lldb-commits] [PATCH] D15527: Add ability to override JIT expr compiler options.

spyffe added a comment. What I'm getting at here is: OverrideExprOptions just subclasses clang::TargetOptions if I'm not mistaken. What I might suggest is virtual bool OverrideExprOptions (clang::TargetOptions &options) { return false; // return true if you actually modified "options" } Yo

Re: [Lldb-commits] [lldb] r257691 - Include IR/DerivedTypes.h instead of IR/Type.h to match LLVM change r256406.

On Wed, Jan 13, 2016 at 2:40 PM, Hans Wennborg via lldb-commits wrote: > Author: hans > Date: Wed Jan 13 16:40:24 2016 > New Revision: 257691 > > URL: http://llvm.org/viewvc/llvm-project?rev=257691&view=rev > Log: > Include IR/DerivedTypes.h instead of IR/Type.h to match LLVM change r256406. Merg

Re: [Lldb-commits] [lldb] r257692 - Fix -Wformat-pedantic warning

On Wed, Jan 13, 2016 at 2:40 PM, Hans Wennborg via lldb-commits wrote: > Author: hans > Date: Wed Jan 13 16:40:26 2016 > New Revision: 257692 > > URL: http://llvm.org/viewvc/llvm-project?rev=257692&view=rev > Log: > Fix -Wformat-pedantic warning Merged to 3.8 in r257706. _

[Lldb-commits] [lldb] r257692 - Fix -Wformat-pedantic warning

Author: hans Date: Wed Jan 13 16:40:26 2016 New Revision: 257692 URL: http://llvm.org/viewvc/llvm-project?rev=257692&view=rev Log: Fix -Wformat-pedantic warning /work/llvm-3.8/llvm.src/tools/lldb/source/API/SBProcess.cpp:1003:73: error: format specifies type 'void *' but the argument has type 'l

[Lldb-commits] [lldb] r257691 - Include IR/DerivedTypes.h instead of IR/Type.h to match LLVM change r256406.

Author: hans Date: Wed Jan 13 16:40:24 2016 New Revision: 257691 URL: http://llvm.org/viewvc/llvm-project?rev=257691&view=rev Log: Include IR/DerivedTypes.h instead of IR/Type.h to match LLVM change r256406. This is similar to r256407 and fixes the following warning: In file included from /work

Re: [Lldb-commits] [PATCH] D15527: Add ability to override JIT expr compiler options.

ldrumm updated this revision to Diff 44794. ldrumm added a comment. Responding to Sean Callanan's suggestions in previous differential RE accepting an existing set of TargetOptions as the basis to configure a custom set. http://reviews.llvm.org/D15527 Files: include/lldb/Target/LanguageRunti

[Lldb-commits] [lldb] r257690 - Revert changes to TestProcessLaunch.py as they are breaking a build.

Author: zturner Date: Wed Jan 13 16:32:31 2016 New Revision: 257690 URL: http://llvm.org/viewvc/llvm-project?rev=257690&view=rev Log: Revert changes to TestProcessLaunch.py as they are breaking a build. Modified: lldb/trunk/packages/Python/lldbsuite/test/functionalities/process_launch/TestPr

Re: [Lldb-commits] [PATCH] D16155: possible ambiguous resolution of clang::ArrayType/llvm::ArrayType in ClangAstContext

spyffe accepted this revision. spyffe added a comment. This revision is now accepted and ready to land. This looks fine. Thanks for paying attention to the details! http://reviews.llvm.org/D16155 ___ lldb-commits mailing list lldb-commits@lists.llv

[Lldb-commits] [PATCH] D16155: possible ambigous resolution of clang::ArrayType/llvm::ArrayType in ClangAstContext

ldrumm created this revision. ldrumm added a reviewer: spyffe. ldrumm added a subscriber: lldb-commits. source/Symbol/ClangASTContext.cpp has `using namespace llvm; using namespace clang;` Both [llvm](http://llvm.org/docs/doxygen/html/classllvm_1_1ArrayType.html) and [clang](http://clang.llvm.o

[Lldb-commits] [lldb] r257684 - Rename MSVC top-level folder to avoid name collision.

Author: zturner Date: Wed Jan 13 16:00:44 2016 New Revision: 257684 URL: http://llvm.org/viewvc/llvm-project?rev=257684&view=rev Log: Rename MSVC top-level folder to avoid name collision. If you have two folders with the same name but different cases, MSBuild gets confused and generates an error

Re: [Lldb-commits] [PATCH] D16150: Fix project name conflict for MSBuild

This revision was automatically updated to reflect the committed changes. Closed by commit rL257684: Rename MSVC top-level folder to avoid name collision. (authored by zturner). Changed prior to commit: http://reviews.llvm.org/D16150?vs=44775&id=44787#toc Repository: rL LLVM http://reviews.

Re: [Lldb-commits] [PATCH] D16150: Fix project name conflict for MSBuild

jonathanmeier added a comment. Could you please commit that for me? I don't have write access to the repository. http://reviews.llvm.org/D16150 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo

[Lldb-commits] [lldb] r257670 - Get rid of const char** typemaps.

Author: zturner Date: Wed Jan 13 15:21:54 2016 New Revision: 257670 URL: http://llvm.org/viewvc/llvm-project?rev=257670&view=rev Log: Get rid of const char** typemaps. We already have char** typemaps which were near copy-pastes of the const char** versions. This way we have only one version that

[Lldb-commits] [lldb] r257669 - Fix TestProcessLaunch for Python 3.

Author: zturner Date: Wed Jan 13 15:21:49 2016 New Revision: 257669 URL: http://llvm.org/viewvc/llvm-project?rev=257669&view=rev Log: Fix TestProcessLaunch for Python 3. There were a number of problems preventing this from working: 1. The SWIG typemaps for converting Python lists to and from C++

[Lldb-commits] [lldb] r257671 - Fix some compiler warnings with MSVC 2015.

Author: zturner Date: Wed Jan 13 15:22:00 2016 New Revision: 257671 URL: http://llvm.org/viewvc/llvm-project?rev=257671&view=rev Log: Fix some compiler warnings with MSVC 2015. Modified: lldb/trunk/source/DataFormatters/StringPrinter.cpp lldb/trunk/source/Expression/ExpressionSourceCode.c

Re: [Lldb-commits] [PATCH] D16149: Delete char const** swig typemaps

granata.enrico accepted this revision. granata.enrico added a comment. This revision is now accepted and ready to land. Ops, sorry, didn't notice the tid_t type map was actually added back later on in the patch. My bad. I'm going to accept this for now, with the caveat that we'll need to work t

Re: [Lldb-commits] [PATCH] D16149: Delete char const** swig typemaps

zturner added a comment. I just moved tid to the bottom because it was in the middle of the in, out, and typecheck versions of the char** typemap. So I wanted to group them all together. Anyway, yea this didn't seem too controversial to me but I figured I'd throw it up here for review in case

Re: [Lldb-commits] [PATCH] D16149: Delete char const** swig typemaps

granata.enrico added a comment. Did you mean to delete the tid_t typemap as well? Assuming there truly are identical typemaps and these are just copies, and everything works just as well when they are removed, I have no objection http://reviews.llvm.org/D16149 __

Re: [Lldb-commits] [PATCH] D16150: Fix project name conflict for MSBuild

zturner accepted this revision. zturner added a comment. This revision is now accepted and ready to land. looks good, thanks http://reviews.llvm.org/D16150 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailm

Re: [Lldb-commits] [PATCH] D16107: Fix for Bug 25338

ovyalov added a comment. If vdso bug pertains to ELF format then it looks reasonable to keep the fix within ObjectFileELF. I experimented a while ago with making ObjectFileELF to read from arbitrary offsets - please see http://reviews.llvm.org/D16151 as reflection of this idea (patch is pretty

[Lldb-commits] [PATCH] D16150: Fix project name conflict for MSBuild

jonathanmeier created this revision. jonathanmeier added a reviewer: zturner. jonathanmeier added a subscriber: lldb-commits. CMake allows case sensitive folder naming when setting the folder property of a target. However MSBuild doesn't like that. It complains about having two projects named th

[Lldb-commits] [PATCH] D16149: Delete char const** swig typemaps

zturner created this revision. zturner added a reviewer: granata.enrico. zturner added a subscriber: lldb-commits. We already have char** typemaps and they are exact copy-pastes. No reason to have both, I tested this and diffed the generated code and it doesn't seem to be any different with thi

[Lldb-commits] [lldb] r257656 - Mark these tests on FreeBSD and Linux as non-flakey. We don't know that they are

Author: enrico Date: Wed Jan 13 13:29:52 2016 New Revision: 257656 URL: http://llvm.org/viewvc/llvm-project?rev=257656&view=rev Log: Mark these tests on FreeBSD and Linux as non-flakey. We don't know that they are Modified: lldb/trunk/packages/Python/lldbsuite/test/functionalities/command_sc

Re: [Lldb-commits] [lldb] r257644 - Fix an issue where scripted commands would not actually print any of their output if an immediate output file was set in the result object via a Python file object

> On Jan 13, 2016, at 11:26 AM, Zachary Turner wrote: > > Thanks! btw would having the command write its output to a file instead of > stdout solve the pexpect problme as well? > That’s possible - but I would need to play with it a little bit to convince myself that it really is a faithful

[Lldb-commits] [lldb] r257653 - Fixed a problem where the Xcode build put lldb's __init__.py in the wrong place.

Author: spyffe Date: Wed Jan 13 13:23:30 2016 New Revision: 257653 URL: http://llvm.org/viewvc/llvm-project?rev=257653&view=rev Log: Fixed a problem where the Xcode build put lldb's __init__.py in the wrong place. Most of the time CONFIGURATION_BUILD_DIR and BUILT_PRODUCTS_DIR are the same, but t

Re: [Lldb-commits] [lldb] r257644 - Fix an issue where scripted commands would not actually print any of their output if an immediate output file was set in the result object via a Python file object

Thanks! btw would having the command write its output to a file instead of stdout solve the pexpect problme as well? On Wed, Jan 13, 2016 at 11:22 AM Enrico Granata wrote: > > On Jan 13, 2016, at 10:34 AM, Zachary Turner wrote: > > > > On Wed, Jan 13, 2016 at 10:25 AM Enrico Granata > wrote:

Re: [Lldb-commits] [lldb] r257644 - Fix an issue where scripted commands would not actually print any of their output if an immediate output file was set in the result object via a Python file object

> On Jan 13, 2016, at 10:34 AM, Zachary Turner wrote: > > > > On Wed, Jan 13, 2016 at 10:25 AM Enrico Granata > wrote: >> On Jan 13, 2016, at 10:21 AM, Zachary Turner > > wrote: >> >> >> On Wed, Jan 13, 2016 at 10:15 AM Enrico Granata vi

Re: [Lldb-commits] [lldb] r257644 - Fix an issue where scripted commands would not actually print any of their output if an immediate output file was set in the result object via a Python file object

On Wed, Jan 13, 2016 at 10:25 AM Enrico Granata wrote: > On Jan 13, 2016, at 10:21 AM, Zachary Turner wrote: > > > On Wed, Jan 13, 2016 at 10:15 AM Enrico Granata via lldb-commits < > lldb-commits@lists.llvm.org> wrote: > >> + >> +class CommandScriptImmediateOutputTestCase (PExpectTest): >> > Do

Re: [Lldb-commits] [lldb] r257644 - Fix an issue where scripted commands would not actually print any of their output if an immediate output file was set in the result object via a Python file object

> On Jan 13, 2016, at 10:21 AM, Zachary Turner wrote: > > > On Wed, Jan 13, 2016 at 10:15 AM Enrico Granata via lldb-commits > mailto:lldb-commits@lists.llvm.org>> wrote: > + > +class CommandScriptImmediateOutputTestCase (PExpectTest): > Does the bug that you were trying to fix occur only when

Re: [Lldb-commits] [lldb] r257644 - Fix an issue where scripted commands would not actually print any of their output if an immediate output file was set in the result object via a Python file object

On Wed, Jan 13, 2016 at 10:15 AM Enrico Granata via lldb-commits < lldb-commits@lists.llvm.org> wrote: > + > +class CommandScriptImmediateOutputTestCase (PExpectTest): > Does the bug that you were trying to fix occur only when using the command_script.py file from the lldb command line? If you lo

[Lldb-commits] [lldb] r257644 - Fix an issue where scripted commands would not actually print any of their output if an immediate output file was set in the result object via a Python file object

Author: enrico Date: Wed Jan 13 12:11:45 2016 New Revision: 257644 URL: http://llvm.org/viewvc/llvm-project?rev=257644&view=rev Log: Fix an issue where scripted commands would not actually print any of their output if an immediate output file was set in the result object via a Python file object

Re: [Lldb-commits] [PATCH] D16128: Fix TestProcessLaunch.test_environment_with_special_char for Python 3

labath added a comment. In http://reviews.llvm.org/D16128#325814, @labath wrote: > > There's lots of tests currently that redirect stdio, are those all broken > > on Linux currently? > > > The redirection works on linux, it's just not 100% reliable in tests. The > thing is that inferior stdio a

Re: [Lldb-commits] [PATCH] D16128: Fix TestProcessLaunch.test_environment_with_special_char for Python 3

labath added a comment. In http://reviews.llvm.org/D16128#325804, @zturner wrote: > Yea, supporting GetStdio is really difficult on Windows. We might try to do > it again someday. Putting it in a char[] variable and reading the variable > seems like a decent solution, I will try that. Thank

Re: [Lldb-commits] [PATCH] D16128: Fix TestProcessLaunch.test_environment_with_special_char for Python 3

zturner added a comment. Yea, supporting GetStdio is really difficult on Windows. We might try to do it again someday. Putting it in a char[] variable and reading the variable seems like a decent solution, I will try that. There's lots of tests currently that redirect stdio, are those all bro

Re: [Lldb-commits] [PATCH] D16049: [LLDB][MIPS] A small fix in GetBreakableLoadAddress() for MIPS

zturner added a comment. In the future when you update the diff of a review, you need to base the diff against the original code, not against your first diff. So the new diff should be a superset of your old diff. Comment at: packages/Python/lldbsuite/test/lldbtest.py:1221-12

Re: [Lldb-commits] [PATCH] D16107: Fix for Bug 25338

ravitheja added a comment. Yes the vdso is fine, last year I did discuss this and we here decided that at the moment we can only offer this solution. http://reviews.llvm.org/D16107 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://li

[Lldb-commits] [lldb] r257603 - Silence an incorrect dwarf parsing warning

Author: tberghammer Date: Wed Jan 13 08:58:48 2016 New Revision: 257603 URL: http://llvm.org/viewvc/llvm-project?rev=257603&view=rev Log: Silence an incorrect dwarf parsing warning We have a check what warns if the offset of a class member is greater then or equal to the size of the class. The wa

Re: [Lldb-commits] [PATCH] D16107: Fix for Bug 25338

ravitheja added a comment. Hi Oleyksiy, actually the problem is not with the Elf Format but its a problem with the ObjectFileElf itself which cannot handle reading from arbitrary offsets in the Elf. Now the ideal solution would be to fix that but as we had discussed last year we agreed to alloc

Re: [Lldb-commits] [PATCH] D16107: Fix for Bug 25338

tberghammer added a comment. Based on your description the vdso file itself looks like a valid elf file to me. If the ObjectFileELF plugin is buggy (it is certainly is as it can't handle the vdso) then I think we should fix that instead of building up a new approach just to work around one of o

Re: [Lldb-commits] [PATCH] D16107: Fix for Bug 25338

ravitheja added a comment. Hi Tamas, a modified algorithm may work in this case for now, but this issue may still reoccur for some other Elf Format . http://reviews.llvm.org/D16107 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://li

Re: [Lldb-commits] [PATCH] D15915: [LLDB][MIPS] Fix TestDisassembleRawData.py

sagar closed this revision. sagar added a comment. Committed in revision 257587 on behalf of Nitesh Jain. Repository: rL LLVM http://reviews.llvm.org/D15915 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/m

[Lldb-commits] [lldb] r257587 - [LLDB][MIPS] Fix TestDisassembleRawData.py

Author: slthakur Date: Wed Jan 13 05:22:56 2016 New Revision: 257587 URL: http://llvm.org/viewvc/llvm-project?rev=257587&view=rev Log: [LLDB][MIPS] Fix TestDisassembleRawData.py Patch by Nitesh Jain. Summary: This patch adds check for the correctness of disassembling instruction for MIPS target

Re: [Lldb-commits] [PATCH] D16049: [LLDB][MIPS] A small fix in GetBreakableLoadAddress() for MIPS

bhushan updated this revision to Diff 44723. bhushan added a comment. This diff adds a testcase to test this patch. The test gets all assembly instructions from the function and finds out the address of instruction in delay slot. Then it tries to place a breakpoint on that address and verifies i

Re: [Lldb-commits] [PATCH] D16128: Fix TestProcessLaunch.test_environment_with_special_char for Python 3

labath added a subscriber: labath. labath requested changes to this revision. labath added a reviewer: labath. labath added a comment. This revision now requires changes to proceed. This will make the test fail on remote platforms, as the redirected file needs to be transferred in before you can