[Lldb-commits] [PATCH] D16155: possible ambigous resolution of clang::ArrayType/llvm::ArrayType in ClangAstContext

[Luke Drummond via lldb-commits]

ldrumm created this revision.
ldrumm added a reviewer: spyffe.
ldrumm added a subscriber: lldb-commits.

source/Symbol/ClangASTContext.cpp has `using namespace llvm; using namespace 
clang;` Both 
[llvm](http://llvm.org/docs/doxygen/html/classllvm_1_1ArrayType.html) and 
[clang](http://clang.llvm.org/doxygen/classclang_1_1ArrayType.html) have an 
`ArrayType` class, which can cause resolution to fail when llvm headers that 
are implicitly included name this  type.

http://reviews.llvm.org/D16155

Files:
  source/Symbol/ClangASTContext.cpp

Index: source/Symbol/ClangASTContext.cpp
===================================================================
--- source/Symbol/ClangASTContext.cpp
+++ source/Symbol/ClangASTContext.cpp
@@ -2105,14 +2105,14 @@
             if (element_count == 0)
             {
                 return CompilerType (ast, ast->getIncompleteArrayType 
(GetQualType(element_type),
-                                                                       
ArrayType::Normal,
+                                                                       
clang::ArrayType::Normal,
                                                                        0));
             }
             else
             {
                 return CompilerType (ast, ast->getConstantArrayType 
(GetQualType(element_type),
                                                                      
ap_element_count,
-                                                                     
ArrayType::Normal,
+                                                                     
clang::ArrayType::Normal,
                                                                      0));
             }
         }



Index: source/Symbol/ClangASTContext.cpp
===================================================================
--- source/Symbol/ClangASTContext.cpp
+++ source/Symbol/ClangASTContext.cpp
@@ -2105,14 +2105,14 @@
             if (element_count == 0)
             {
                 return CompilerType (ast, ast->getIncompleteArrayType (GetQualType(element_type),
-                                                                       ArrayType::Normal,
+                                                                       clang::ArrayType::Normal,
                                                                        0));
             }
             else
             {
                 return CompilerType (ast, ast->getConstantArrayType (GetQualType(element_type),
                                                                      ap_element_count,
-                                                                     ArrayType::Normal,
+                                                                     clang::ArrayType::Normal,
                                                                      0));
             }
         }

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits