jasonmolenda updated this revision to Diff 44189.
jasonmolenda added a comment.
Updated to address Jim's first round of comments.
1. fix typeo in comment
2. update change argument name from "private_step_out" to
"continue_to_next_branch"
3. Change continue_to_next_branch argument to have a def
jasonmolenda added a comment.
Thanks for the comments. As for calling Clear() on the instruction list
manually, I was aping the dtor on ThreadPlanStepRange which reads,
// FIXME: The DisassemblerLLVMC has a reference cycle and won't go away if it
has any active instructions.
// I'll fix th
amccarth added a comment.
PTAL: I've enhanced the test to do a couple extra checks that
TestBuiltinTrap.py was doing, and I've eliminated that old test.
I believe it should work on Linux as well as Windows, but I'm not set up with a
Linux machine right now. If someone could try this patch on
amccarth updated this revision to Diff 44179.
amccarth added a comment.
Herald added subscribers: srhines, danalbert, tberghammer.
I've rolled bits of TestBuiltinTrap.py into the new test and deleted the old
one.
This still works on Windows. I'm not set up to test it on Linux.
http://reviews.
sivachandra added a comment.
Thanks a lot Dwan Perchik, for persisting on my behalf.
And thanks to Sean and Greg for taking a look.
I second Dwan's earlier comment about Greg's code reviews. He has been the best
reviewer I have worked with, internally and externally.
Will commit this change sh
spyffe accepted this revision.
spyffe added a comment.
This revision is now accepted and ready to land.
The expression parser side fixes look fine to me, and they remove some hacks
and make things slightly more elegant.
Obviously the ideal would be to have GCC generate full debug info, but to me
clayborg resigned from this revision.
clayborg removed a reviewer: clayborg.
clayborg added a comment.
I looked at this before, and resigned to let Sean Callanan comment on the fix
since this is in his area of expertise: the expression parser.
http://reviews.llvm.org/D12809
_
dawn added a reviewer: clayborg.
dawn added a subscriber: clayborg.
dawn added a comment.
Adding Greg - he is an excellent reviewer and quite responsive (poor guy - ends
up with way more than his fair share of reviews as a result :( ).
@clayborg would you be willing to be a 2nd pair of eyes here
dawn added a comment.
@spyffe I think this review is waiting on you since you had previously rejected
it. Can you please have a look? It continues to show up on my "Blocking
Others" list and there's nothing more I can do on my side. Please review or
resign out of curtesy to sivachandra??? T
Author: tfiala
Date: Wed Jan 6 13:16:45 2016
New Revision: 256961
URL: http://llvm.org/viewvc/llvm-project?rev=256961&view=rev
Log:
fixup lldbinline-style tests to clean up Makefiles and *.d files
The lldbinline inline-test mechanism will create a Makefile
if one does not exist in the test direc
Author: aidandodds
Date: Wed Jan 6 09:43:52 2016
New Revision: 256941
URL: http://llvm.org/viewvc/llvm-project?rev=256941&view=rev
Log:
[Renderscript] Fix stack argument inspection.
Function arguments that were spilled and passed on the stack were incorrectly
read.
The value was written back in
labath added a comment.
It's looking good now, thanks.
Repository:
rL LLVM
http://reviews.llvm.org/D15886
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: labath
Date: Wed Jan 6 08:15:32 2016
New Revision: 256935
URL: http://llvm.org/viewvc/llvm-project?rev=256935&view=rev
Log:
Remove XTIMEOUT from TestMultithreaded on linux
instead, mark the test as expected flaky, which will trigger a rerun in case
the test hangs.
Modified:
lldb/t
bhushan added a comment.
Hi Pavel,
Could you please confirm if http://reviews.llvm.org/rL256929 resolves the
build warnings?
Repository:
rL LLVM
http://reviews.llvm.org/D15886
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://li
Author: bhushan.attarde
Date: Wed Jan 6 06:08:22 2016
New Revision: 256929
URL: http://llvm.org/viewvc/llvm-project?rev=256929&view=rev
Log:
Fix build warnings after rL256915
Modified:
lldb/trunk/source/Plugins/Instruction/MIPS/EmulateInstructionMIPS.cpp
Modified: lldb/trunk/source/Plugins/
Author: labath
Date: Wed Jan 6 05:40:06 2016
New Revision: 256928
URL: http://llvm.org/viewvc/llvm-project?rev=256928&view=rev
Log:
Fix a bug in lldbutil.expect_state_changes
The logic for skipping over the stop-and-restart events was incorrect as it was
also skipping the
expectations. Implemen
This revision was automatically updated to reflect the committed changes.
Closed by commit rL256927: Add LogDump methods to lldb_private::StringList.
(authored by EwanCrawford).
Changed prior to commit:
http://reviews.llvm.org/D15773?vs=44000&id=44104#toc
Repository:
rL LLVM
http://reviews.
Author: ewancrawford
Date: Wed Jan 6 05:06:30 2016
New Revision: 256927
URL: http://llvm.org/viewvc/llvm-project?rev=256927&view=rev
Log:
Add LogDump methods to lldb_private::StringList.
This patch eases the printing of iterable string containers.
Author: Luke Drummond
Differential Revision: h
labath added a subscriber: labath.
labath added a comment.
Hi, the new check you have added to TestMiSymbol fails on linux: all the source
lines are listed twice for some reason. I don't know if this is expected
behavior (and the test needs to be fixed) or it's an bug (and the code needs to
be
labath added a subscriber: labath.
labath added a comment.
Hi, this introduces loads of new compiler warnings like:
lldb/source/Plugins/Instruction/MIPS/EmulateInstructionMIPS.cpp:1434:14:
warning: variable 'target' is used uninitialized whenever 'if' condition is
false [-Wsometimes-uninitial
Author: labath
Date: Wed Jan 6 03:48:54 2016
New Revision: 256925
URL: http://llvm.org/viewvc/llvm-project?rev=256925&view=rev
Log:
XFAIL TestMiSymbol on linux
new test introduced in r256863 fails on linux.
Modified:
lldb/trunk/packages/Python/lldbsuite/test/tools/lldb-mi/symbol/TestMiSymb
labath added a subscriber: labath.
labath added a comment.
Yes, please don't insert new decorators, we have enough as it is. You can
achieve the behavior you want with the correct arguments to expectedFailureAll
decorator.
http://reviews.llvm.org/D15893
_
bhushan closed this revision.
bhushan added a comment.
Closed by commit http://reviews.llvm.org/rL256915
Repository:
rL LLVM
http://reviews.llvm.org/D15886
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/ma
23 matches
Mail list logo
