Re: [Lldb-commits] [PATCH] D15708: Advance the return-address breakpoint location to the end of the next source line, or the next branching instruction, when stepping over a func call

[Jason Molenda via lldb-commits]

jasonmolenda added a comment.

Thanks for the comments.  As for calling Clear() on the instruction list 
manually, I was aping the dtor on ThreadPlanStepRange which reads,

  // FIXME: The DisassemblerLLVMC has a reference cycle and won't go away if it 
has any active instructions.
  // I'll fix that but for now, just clear the list and it will go away nicely.
  for (size_t i = 0; i < num_instruction_ranges; i++)
  {
      if (m_instruction_ranges[i])
          m_instruction_ranges[i]->GetInstructionList().Clear();
  }

I should probably check that this is the case before I copy the hack.

I'll see if I can consolidate the disassembly into one big of shared code.


Repository:
  rL LLVM

http://reviews.llvm.org/D15708



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits