nitesh.jain created this revision.
nitesh.jain added reviewers: jaydeep, clayborg, ovyalov.
nitesh.jain added subscribers: bhushan, sagar, mohit.bhakkad, lldb-commits.
nitesh.jain set the repository for this revision to rL LLVM.
This patch check whether first register is readable.
Repository:
r
nitesh.jain created this revision.
nitesh.jain added reviewers: clayborg, ovyalov, jaydeep.
nitesh.jain added subscribers: bhushan, sagar, mohit.bhakkad, lldb-commits.
nitesh.jain set the repository for this revision to rL LLVM.
The "break" is opcode for breakpoint instruction.
Repository:
rL L
sagar created this revision.
sagar added reviewers: clayborg, tberghammer.
sagar added subscribers: nitesh.jain, jaydeep, bhushan, mohit.bhakkad,
lldb-commits.
sagar set the repository for this revision to rL LLVM.
Herald added a subscriber: dsanders.
This patch will clear bug 25194 - LLDB-Server
Thanks! Do you think you could add a test that does specifically that?
Set two breakpoints back to back, even in the same function, ane ensure
that the second one gets hit. If your theory is right this test will fail
on Windows and Linux (and then we'll have to xfail it) but at least we'll
have a
Okay, I think I fixed this, the fix is: r253008. That passes cleanly on Linux
for me, but I don't have a windows machine handy to test.
What was happening is that originally lldb had a bug where if you were stopped
on a breakpoint and then the next instruction also had a breakpoint, the plan
t
Author: jingham
Date: Thu Nov 12 21:37:48 2015
New Revision: 253008
URL: http://llvm.org/viewvc/llvm-project?rev=253008&view=rev
Log:
Fix commit 252963 to work around a bug on some platforms where they don't
correctly handle stepping over one breakpoint directly onto another breakpoint.
This i
dawn created this revision.
dawn added reviewers: tberghammer, clayborg, tfiala.
dawn added a subscriber: lldb-commits.
dawn set the repository for this revision to rL LLVM.
Other compilers (and older Clang compilers) use data4/data8 forms to specify
addresses in DWARF. This patch fixes lldb to
Author: jmolenda
Date: Thu Nov 12 20:02:30 2015
New Revision: 253004
URL: http://llvm.org/viewvc/llvm-project?rev=253004&view=rev
Log:
Add PythonTestSuite.cpp to project file for lldb-gtest.
Modified:
lldb/trunk/lldb.xcodeproj/project.pbxproj
Modified: lldb/trunk/lldb.xcodeproj/project.pbxpr
Author: zturner
Date: Thu Nov 12 19:50:19 2015
New Revision: 253002
URL: http://llvm.org/viewvc/llvm-project?rev=253002&view=rev
Log:
Fix a bug in PythonExceptionState and add unittest coverage.
I forgot to reset the restore flag when calling member function
`Acquire`. The newly added unittest s
Author: jmolenda
Date: Thu Nov 12 19:43:49 2015
New Revision: 252998
URL: http://llvm.org/viewvc/llvm-project?rev=252998&view=rev
Log:
Add PythonExceptionState.cppto the xocde project file.
Modified:
lldb/trunk/lldb.xcodeproj/project.pbxproj
Modified: lldb/trunk/lldb.xcodeproj/project.pbxpro
Author: zturner
Date: Thu Nov 12 19:24:58 2015
New Revision: 252995
URL: http://llvm.org/viewvc/llvm-project?rev=252995&view=rev
Log:
Update .gitignore to exclude pyproj folder (used for Python IDE)
Modified:
lldb/trunk/.gitignore
Modified: lldb/trunk/.gitignore
URL:
http://llvm.org/viewvc/
Author: zturner
Date: Thu Nov 12 19:24:52 2015
New Revision: 252994
URL: http://llvm.org/viewvc/llvm-project?rev=252994&view=rev
Log:
Introduce a `PythonExceptionState` class.
This is a helper class which supports a number of
features including exception to string formatting with
backtrace handli
Author: zturner
Date: Thu Nov 12 19:24:35 2015
New Revision: 252993
URL: http://llvm.org/viewvc/llvm-project?rev=252993&view=rev
Log:
gtest - Make a `PythonTestSuite` base class for setup / teardown.
This allows other potential unit test suites (of which one is
forthcoming in a subsequent patch)
Author: zturner
Date: Thu Nov 12 19:24:25 2015
New Revision: 252992
URL: http://llvm.org/viewvc/llvm-project?rev=252992&view=rev
Log:
Delete `PyObjectToString` and use `PythonObject::Str()`.
The latter function, from PythonDataObjects, is Python 3 ready and
the former was not.
Modified:
lldb
Ahh, seems it wasn't just Windows that was affected by this. Makes me feel
a little better :)
Posting the link to the buildbot failures here so that Jim can get full
logs if it helps.
http://lab.llvm.org:8011/builders/lldb-x86_64-ubuntu-14.04-cmake/builds/8391
On Thu, Nov 12, 2015 at 4:37 PM Yin
I went ahead and created two logs. One for the working case and one for
the non-working case. I'm attaching instead of inlining, let me know if
this doesn't work:
Might help to diff them.
doesnt_work.log
Description: Binary data
works.log
Description: Binary data
Here's the log. Disassembly of those two functions was posted earlier.
Let me know if you need anything else:
ThreadPlanStepRange::SetNextBranchBreakpoint - Setting breakpoint -1 (site
2) to run to address 0x94902e
Thread::PushPlan(0x0654FBB0): "Stepping in through line with-debug.c:12.",
tid = 0
I'm going to try the "with patch" version again with logging enabled as you
suggest. Will update soon
On Thu, Nov 12, 2015 at 4:36 PM Jim Ingham wrote:
> If you can debug a failing case, and do whatever step operation got you to
> the wrong place, then run up to that step, and do:
>
> (lldb) lo
I reverted this patch for now.
Please resubmit if you have a fix.
Thanks,
Ying
On Thu, Nov 12, 2015 at 4:36 PM, Jim Ingham via lldb-commits <
lldb-commits@lists.llvm.org> wrote:
> If you can debug a failing case, and do whatever step operation got you to
> the wrong place, then run up to that st
If you can debug a failing case, and do whatever step operation got you to the
wrong place, then run up to that step, and do:
(lldb) log enable -f lldb step
and then do the step, then send me that log plus the disassembly for the
function you were stepping in and the output of:
(lldb) image d
Author: chying
Date: Thu Nov 12 18:31:21 2015
New Revision: 252980
URL: http://llvm.org/viewvc/llvm-project?rev=252980&view=rev
Log:
Revert "Another little stepping optimization: if any of the source step
commands are running through a range "
- Revert because this commit introduce several failu
The error messages are always different because the error message is
printed by the test. I'm going to try to load up the executable
for TestStepNoDebug in the debugger and get a disassembly and do the step
On Thu, Nov 12, 2015 at 4:01 PM Jim Ingham wrote:
> Is the line they stepped to - instea
Is the line they stepped to - instead of the expected line - always line 0?
Jim
> On Nov 12, 2015, at 3:52 PM, Zachary Turner wrote:
>
> Hi Jim,
>
> This breaks about 12 tests on Windows. The patch looks simple, but this
> isn't really my area, is there anything I can give you to help diagno
Hi Jim,
This breaks about 12 tests on Windows. The patch looks simple, but this
isn't really my area, is there anything I can give you to help diagnose
what might be wrong? The following tests fail:
FAIL: LLDB (suite) :: Test-rdar-9974002.py (Windows zturner-win81 8
6.2.9200 AMD64 Intel64 Famil
Author: jingham
Date: Thu Nov 12 16:32:09 2015
New Revision: 252963
URL: http://llvm.org/viewvc/llvm-project?rev=252963&view=rev
Log:
Another little stepping optimization: if any of the source step commands are
running through a range
of addresses, and the range has no branches, instead of runni
dawn added a comment.
See inline comment.
Comment at: source/Symbol/ClangASTContext.cpp:9191
@@ -9189,2 +9190,3 @@
+continue;
searched.insert(it->second);
symbol_file->ParseDeclsForContext(CompilerDeclContext(this,
it->secon
Author: amccarth
Date: Thu Nov 12 15:16:15 2015
New Revision: 252950
URL: http://llvm.org/viewvc/llvm-project?rev=252950&view=rev
Log:
Implement RegisterContext for Mini Dumps.
Differential Revision: http://reviews.llvm.org/D14591
Added:
lldb/trunk/source/Plugins/Process/Windows/MiniDump/x64
This revision was automatically updated to reflect the committed changes.
amccarth marked an inline comment as done.
Closed by commit rL252950: Implement RegisterContext for Mini Dumps. (authored
by amccarth).
Changed prior to commit:
http://reviews.llvm.org/D14591?vs=39978&id=40082#toc
Reposi
Author: zturner
Date: Thu Nov 12 14:11:02 2015
New Revision: 252939
URL: http://llvm.org/viewvc/llvm-project?rev=252939&view=rev
Log:
Finish PyCallable -> PythonCallable conversion.
This finishes the effort to port python-wrapper.swig code over to
using PythonDataObjects.
Also included in this p
amccarth marked 3 inline comments as done.
Comment at:
packages/Python/lldbsuite/test/functionalities/postmortem/minidump/TestMiniDump.py:40
@@ +39,3 @@
+thread = self.process.GetThreadAtIndex(0)
+# The crash is in main, so there should be one frame on the stack.
Author: aidandodds
Date: Thu Nov 12 11:39:42 2015
New Revision: 252914
URL: http://llvm.org/viewvc/llvm-project?rev=252914&view=rev
Log:
Allow renderscript runtime to read MIPS target arguments.
Modified:
lldb/trunk/source/Plugins/LanguageRuntime/RenderScript/RenderScriptRuntime/RenderScript
Author: zturner
Date: Thu Nov 12 11:01:48 2015
New Revision: 252909
URL: http://llvm.org/viewvc/llvm-project?rev=252909&view=rev
Log:
Fix non-Windows build after r252906.
Modified:
lldb/trunk/scripts/Python/python-wrapper.swig
lldb/trunk/scripts/lldb.swig
lldb/trunk/source/Plugins/Scr
zturner added inline comments.
Comment at:
packages/Python/lldbsuite/test/functionalities/postmortem/minidump/TestMiniDump.py:40
@@ +39,3 @@
+thread = self.process.GetThreadAtIndex(0)
+# The crash is in main, so there should be one frame on the stack.
+sel
Author: zturner
Date: Thu Nov 12 10:23:16 2015
New Revision: 252906
URL: http://llvm.org/viewvc/llvm-project?rev=252906&view=rev
Log:
Begin converting uses of PyCallable to PythonCallable.
PyCallable is a class that exists solely within the swig wrapper
code. PythonCallable is a more generic imp
This revision was automatically updated to reflect the committed changes.
Closed by commit rL252898: Use uniqueness of C++ fully-qualified names to
resolve conflicts (authored by artagnon).
Changed prior to commit:
http://reviews.llvm.org/D14549?vs=39841&id=40044#toc
Repository:
rL LLVM
htt
Author: artagnon
Date: Thu Nov 12 08:44:24 2015
New Revision: 252898
URL: http://llvm.org/viewvc/llvm-project?rev=252898&view=rev
Log:
Use uniqueness of C++ fully-qualified names to resolve conflicts
A very expected layout: source tree is in ~/src/llvm, the build directory is in
~/src/llvm-build,
tberghammer created this revision.
tberghammer added reviewers: clayborg, granata.enrico.
tberghammer added a subscriber: lldb-commits.
Remove a broken hack from Scalar::ULongLong and fix a test
Change Test-rdar-12481949.py to expect GetValueAsUnsigned() to return
0x if the variable is an
dean added a subscriber: dean.
dean added a comment.
Hi,
is there any update related to this patch? I don't see any activity from the
last two weeks.
@Greg Clayton: you have inserted two reviewers but they don't seem to have
commented on it. Can you please give a look?
Thanks
Repository:
r
Hi,
is there any update related to this patch? I don't see any activity from the
last two weeks.
@Greg Clayton: you have inserted two reviewers but they don't seem to have
commented on it. Can you please give a look?
Thanks
On 02/11/15 05:15, Bhushan Attarde via lldb-commits wrote:
bhushan a
tberghammer abandoned this revision.
tberghammer added a comment.
I haven't noticed we already store the symbol index. Abandon it in favor of the
API you suggested
http://reviews.llvm.org/D14536
___
lldb-commits mailing list
lldb-commits@lists.llvm
abhishek.aggarwal added a comment.
Hello Jason
No problem regarding the delay. Thanks a lot for reviewing the patch. I have
made the changes as suggested by you. I will land it now.
http://reviews.llvm.org/D14226
___
lldb-commits mailing list
lldb
abhishek.aggarwal updated this revision to Diff 40014.
abhishek.aggarwal added a comment.
Removed log and inserted statement terminator
http://reviews.llvm.org/D14226
Files:
packages/Python/lldbsuite/test/api/multithreaded/TestMultithreaded.py
packages/Python/lldbsuite/test/expression_comma
abhishek.aggarwal updated this revision to Diff 40013.
abhishek.aggarwal added a comment.
Used Assert instead of If condition
http://reviews.llvm.org/D14226
Files:
packages/Python/lldbsuite/test/api/multithreaded/TestMultithreaded.py
packages/Python/lldbsuite/test/expression_command/test/Te
43 matches
Mail list logo
