Author: eugenezelenko
Date: Fri Oct 30 20:22:59 2015
New Revision: 251733
URL: http://llvm.org/viewvc/llvm-project?rev=251733&view=rev
Log:
Fix Clang-tidy modernize-use-nullptr warnings in include/lldb/API and
source/API; other minor fixes.
Other fixes should reduce number of readability-redunda
Author: enrico
Date: Fri Oct 30 20:19:27 2015
New Revision: 251732
URL: http://llvm.org/viewvc/llvm-project?rev=251732&view=rev
Log:
Harden this test case to do the right thing in the face of compiler changes
Modified:
lldb/trunk/packages/Python/lldbsuite/test/lang/c/const_variables/TestCons
Author: eugenezelenko
Date: Fri Oct 30 19:43:59 2015
New Revision: 251730
URL: http://llvm.org/viewvc/llvm-project?rev=251730&view=rev
Log:
Fix Clang-tidy modernize-use-override warnings in include/lldb/Expression,
source/Expression and tools/lldb-mi; other minor fixes.
Modified:
lldb/trunk/
> On Oct 30, 2015, at 5:02 PM, Jim Ingham via lldb-commits
> wrote:
>
> bool
> +ValueObject::IsLogicalTrue (Error& error)
> +{
> +Scalar scalar_value;
> +
> +if (!ResolveValue (scalar_value))
> +{
> +error.SetErrorString("failed to get a scalar result");
> +retur
Author: jingham
Date: Fri Oct 30 19:02:18 2015
New Revision: 251727
URL: http://llvm.org/viewvc/llvm-project?rev=251727&view=rev
Log:
Abstract the notion of the truth value of an expression result, for use
in breakpoint conditions.
Modified:
lldb/trunk/include/lldb/Core/ValueObject.h
lldb
Author: jingham
Date: Fri Oct 30 16:43:15 2015
New Revision: 251722
URL: http://llvm.org/viewvc/llvm-project?rev=251722&view=rev
Log:
Make the error return more explicit when an SBValue has no value.
Modified:
lldb/trunk/source/API/SBValue.cpp
Modified: lldb/trunk/source/API/SBValue.cpp
URL:
Author: jingham
Date: Fri Oct 30 16:32:25 2015
New Revision: 251721
URL: http://llvm.org/viewvc/llvm-project?rev=251721&view=rev
Log:
Add a few missing includes.
Modified:
lldb/trunk/include/lldb/API/LLDB.h
Modified: lldb/trunk/include/lldb/API/LLDB.h
URL:
http://llvm.org/viewvc/llvm-projec
Author: jingham
Date: Fri Oct 30 16:32:03 2015
New Revision: 251720
URL: http://llvm.org/viewvc/llvm-project?rev=251720&view=rev
Log:
Fix an error message (the debugger was invalid, not the target.)
Modified:
lldb/trunk/source/API/SBDebugger.cpp
Modified: lldb/trunk/source/API/SBDebugger.cpp
emaste added a subscriber: emaste.
emaste added a comment.
For future diffs please include additional context (e.g. git diff -U9)
Repository:
rL LLVM
http://reviews.llvm.org/D14182
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
htt
mchandler-blizzard created this revision.
mchandler-blizzard added reviewers: labath, ovyalov.
mchandler-blizzard added a subscriber: lldb-commits.
mchandler-blizzard set the repository for this revision to rL LLVM.
Herald added subscribers: srhines, danalbert, tberghammer.
Adds checks for posix f
mchandler-blizzard added inline comments.
Comment at: tools/lldb/source/Host/common/File.cpp:301
@@ -299,1 +300,3 @@
+
+#if LINUX_VERSION_CODE >= KERNEL_VERSION(2,6,23)
if (options & eOpenOptionCloseOnExec)
krytarowski wrote:
> labath wrote:
> > This need
It should already be there. I had a single test in it before (a do-nothing
single test), for maybe 4 or 5 days.
On Fri, Oct 30, 2015 at 9:48 AM, Zachary Turner wrote:
> BTW, can you add EditlineTests.cpp to unittests/Editline/CMakeLists.txt?
> Currently this unittest only appears to be enabled
Note, the other important step was that you had to have an lldb installed in
/usr/bin/lldb that FAILED this test. If you have a more recent lldb there, the
test will succeed, and you won't notice you aren't testing your newly built
sources.
Jim
> On Oct 30, 2015, at 1:25 PM, Enrico Granata vi
Thanks. I'll follow up next week after I do some investigation
On Fri, Oct 30, 2015 at 1:25 PM Enrico Granata wrote:
> I think what I was doing is be in lldb/test and do
>
> $ ./dotest.py ../packages/python/lldbsuite/functionalities/completion
>
> On Oct 30, 2015, at 12:22 PM, Zachary Turner w
I think what I was doing is be in lldb/test and do
$ ./dotest.py ../packages/python/lldbsuite/functionalities/completion
> On Oct 30, 2015, at 12:22 PM, Zachary Turner wrote:
>
> Can you give me a command line which will reproduce the original problem?
> Because I ran through the entire test
sas added a comment.
Thanks for fixing this. Didn't test external LLVM builds.
Repository:
rL LLVM
http://reviews.llvm.org/D14166
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commit
Can you give me a command line which will reproduce the original problem?
Because I ran through the entire test suite and nothing failed, so I want
to make sure we're doing the same thing. I'm still a little confused about
how this happens, but I plan to look into it when I'm back on Monday and
se
> On Oct 29, 2015, at 11:31 PM, Zachary Turner wrote:
>
> Wow. That's a weird problem. Thanks for finding it!
>
> Would it work if we move the definition of the `lldbtest_config` class into
> lldbsuite/test/__init__.py? This way the configuration should be part of the
> global package st
Author: eugenezelenko
Date: Fri Oct 30 13:50:12 2015
New Revision: 251716
URL: http://llvm.org/viewvc/llvm-project?rev=251716&view=rev
Log:
Fix Clang-tidy modernize-use-nullptr warnings in source/Breakpoint; other minor
fixes.
Modified:
lldb/trunk/source/Breakpoint/Breakpoint.cpp
lldb/tr
jingham added a subscriber: jingham.
jingham added a comment.
The substance is fine. I fixed up the grammar a little, maybe something like:
TODO: This condition should be checked in the synchronous part of the
watchpoint code (Watchpoint::ShouldStop), so that
we avoid pulling an event even if
The substance is fine. I fixed up the grammar a little, maybe something like:
TODO: This condition should be checked in the synchronous part of the
watchpoint code (Watchpoint::ShouldStop), so that
we avoid pulling an event even if the watchpoint fails the ignore count
condition. It is moved h
BTW, can you add EditlineTests.cpp to unittests/Editline/CMakeLists.txt?
Currently this unittest only appears to be enabled for the Xcode build (and
it might actually break the CMake build since CMake complains if there is a
cpp file that is not added to a target)
On Fri, Oct 30, 2015 at 9:43 AM T
> Should a unittest really have debug printfs?
Those are behind a define. edit line is inherently about converting input
to output, and when we layer in auto-tabbing, auto-completion, etc. it is
critical in test development to see how these develop. Every single touch
of this test is going to in
> What are all these setenv lines for?
libedit requires a TERM to know how to deal with the screen. We can't talk
to libedit if it can't figure out what kind of terminal it is working with.
> Another option is to use TEST_F instead of TEST(), and then declare a
class with Setup() and TearDown()
Author: abidh
Date: Fri Oct 30 11:20:40 2015
New Revision: 251704
URL: http://llvm.org/viewvc/llvm-project?rev=251704&view=rev
Log:
Remove 2 lines missed in earlier commit (r251636).
Modified:
lldb/trunk/tools/lldb-mi/MICmdCmdStack.cpp
Modified: lldb/trunk/tools/lldb-mi/MICmdCmdStack.cpp
UR
I'm also still a little confused why this worked before my patch. How is
unittest2 importing the individual tests in a way that behaves differently
when dotest is a package (now) versus a standalone script (before)?
On Thu, Oct 29, 2015 at 11:31 PM Zachary Turner wrote:
> Wow. That's a weird p
Author: labath
Date: Fri Oct 30 09:08:19 2015
New Revision: 251699
URL: http://llvm.org/viewvc/llvm-project?rev=251699&view=rev
Log:
Mark another TestEvents test as flaky on linux
I don't think anything has changed recently - the test was always flaky, but
only very rarely. Still, it is causing n
labath created this revision.
labath added reviewers: clayborg, jingham.
labath added a subscriber: lldb-commits.
The code which was preventing the usage of the OS plugin while detach is in
progress also prevented us to update the thread list correctly. This resulted
in an empty thread list, which
mohit.bhakkad updated this revision to Diff 38799.
mohit.bhakkad added a comment.
Changes in this revision:
- changed no-source to no-debuginfo and made it default
- now no-source means display assembly if source file is missing, even if
debug-info is present.
Repository:
rL LLVM
http://rev
mohit.bhakkad added a comment.
I forgot about note part, is it okay to add a TODO before ignore count
condition in source/Target/StopInfo.cpp:
TODO: This condition should be checked in synchronous part of watchpoint code
(Watchpoint::ShouldStop), so that
we avoid pulling an event even if watch
abidh created this revision.
abidh added a reviewer: ki.stfu.
abidh added a subscriber: lldb-commits.
As per the following link, the "--" as separator between options and
parameter can come in any command. Currently, it was being handled in
only one command. I have moved into the base so that any
mohit.bhakkad requested a review of this revision.
mohit.bhakkad added a comment.
> Note, if you end up going with the current patch, isn't quite right, however.
> You need to move the check for the watchpoint ignore count up before
> printing out the old & new values. An ignored watchpoint
32 matches
Mail list logo
