This revision was automatically updated to reflect the committed changes.
Closed by commit rL251386: Fix for Arm watchpoint cache corruption in case of
ptrace failure (authored by omjavaid).
Changed prior to commit:
http://reviews.llvm.org/D14051?vs=38364&id=38502#toc
Repository:
rL LLVM
ht
Author: omjavaid
Date: Tue Oct 27 00:56:56 2015
New Revision: 251386
URL: http://llvm.org/viewvc/llvm-project?rev=251386&view=rev
Log:
Fix for Arm watchpoint cache corruption in case of ptrace failure
Differential revision: http://reviews.llvm.org/D14051
Modified:
lldb/trunk/source/Plugins/
ovyalov created this revision.
ovyalov added reviewers: tberghammer, labath.
ovyalov added a subscriber: lldb-commits.
Herald added subscribers: danalbert, tberghammer.
We can connect to a device using various protocols (tcp, unix domain, abstract).
Instead of adding new URL schemes (e.g., adb-uni
ovyalov retitled this revision from "Add Socket::Create factory method which
uses socket scheme (tcp, unix,..) to find an appropriate implementation class."
to "Add Socket::Create factory method which uses socket protocol to find an
appropriate implementation class.".
ovyalov updated the summary
Author: enrico
Date: Mon Oct 26 20:17:28 2015
New Revision: 251377
URL: http://llvm.org/viewvc/llvm-project?rev=251377&view=rev
Log:
Minor cleanup of SBTypeSummary::CreateWithCallback to take an optional
description argument
Modified:
lldb/trunk/include/lldb/API/SBTypeSummary.h
lldb/trun
Author: enrico
Date: Mon Oct 26 20:10:35 2015
New Revision: 251376
URL: http://llvm.org/viewvc/llvm-project?rev=251376&view=rev
Log:
Add calls to the SB API to access the multi-language formatter category feature
Modified:
lldb/trunk/include/lldb/API/SBTypeCategory.h
lldb/trunk/scripts/in
Author: eugenezelenko
Date: Mon Oct 26 19:45:06 2015
New Revision: 251374
URL: http://llvm.org/viewvc/llvm-project?rev=251374&view=rev
Log:
Fix Clang-tidy modernize-use-override warnings in
source/Plugins/LanguageRuntime and Platform; other minor fixes.
Modified:
lldb/trunk/source/Plugins/L
zturner added a comment.
Do we need this `GetScheme()` method? And instead of having `Create` take a
string, couldn't it just take a `SocketProtocol` instead? It seems like the
logic of converting the string to the enum should be done in the `Acceptor`
class, as this URI format is defined by
ovyalov retitled this revision from "Make Socket to support plugin interface"
to "Add Socket::Create factory method which uses socket scheme (tcp, unix,..)
to find an appropriate implementation class.".
ovyalov updated the summary for this revision.
ovyalov updated this revision to Diff 38484.
h
Author: enrico
Date: Mon Oct 26 18:39:12 2015
New Revision: 251368
URL: http://llvm.org/viewvc/llvm-project?rev=251368&view=rev
Log:
Change TestTypeCompletion to not rely on std::string
On some combination of platform and c++ library, this dependency was causing
the test to fail for reasons tang
FYI: This broke the Windows build (which doesn't have getuid), and the fix
wasn't immediately obvious, so I reverted the change.
Adrian.
On Mon, Oct 26, 2015 at 1:33 PM, Sean Callanan via lldb-commits <
lldb-commits@lists.llvm.org> wrote:
> Author: spyffe
> Date: Mon Oct 26 15:33:24 2015
> New
Author: amccarth
Date: Mon Oct 26 16:38:41 2015
New Revision: 251354
URL: http://llvm.org/viewvc/llvm-project?rev=251354&view=rev
Log:
Revert "Clang module compilation options need to be per-platform."
This reverts commit r251340.
Breaks the Windows build because Windows doesn't have getuid. Th
This revision was automatically updated to reflect the committed changes.
Closed by commit rL251351: Remove some useless typedef's. (authored by sas).
Changed prior to commit:
http://reviews.llvm.org/D14091?vs=38455&id=38464#toc
Repository:
rL LLVM
http://reviews.llvm.org/D14091
Files:
ll
Author: sas
Date: Mon Oct 26 16:32:31 2015
New Revision: 251351
URL: http://llvm.org/viewvc/llvm-project?rev=251351&view=rev
Log:
Remove some useless typedef's.
Summary:
This does not have any functionnal difference but I found myself
searching for 'struct RegisterInfo$' to find a definition and
ovyalov added a comment.
In http://reviews.llvm.org/D14085#275507, @zturner wrote:
> I think most of the time they are used in a Connection class, but I don't
> think it's necessarily guaranteed they will always be that way.
>
> I can think of at least one use case in the future where we will ne
clayborg added a comment.
In http://reviews.llvm.org/D14085#275507, @zturner wrote:
> I think most of the time they are used in a Connection class, but I don't
> think it's necessarily guaranteed they will always be that way.
>
> I can think of at least one use case in the future where we will n
Author: spyffe
Date: Mon Oct 26 15:33:24 2015
New Revision: 251340
URL: http://llvm.org/viewvc/llvm-project?rev=251340&view=rev
Log:
Clang module compilation options need to be per-platform.
On UNIX (but not Darwin) the username needs to be respected when creating a
temporary module directory, s
sas created this revision.
sas added reviewers: clayborg, zturner.
sas added a subscriber: lldb-commits.
This does not have any functionnal difference but I found myself
searching for 'struct RegisterInfo$' to find a definition and couldn't
find it. The version without typedef seems more common so
sas created this revision.
sas added reviewers: dawn, brucem.
sas added a subscriber: lldb-commits.
This breaks when using a symlink from llvm/tools/lldb to the lldb source
tree, instead of cloning directly as a child. With this change, we can
build properly, even when using links.
http://reviews
zturner added a comment.
I think most of the time they are used in a Connection class, but I don't think
it's necessarily guaranteed they will always be that way.
I can think of at least one use case in the future where we will need to open a
socket to a server we don't control and stream some
clayborg added a comment.
The plug-in interface I was thinking of was the Connection class. This would
allow different platforms to support different Connection subclasses for things
like network, serial, USB, Firewire, shared memory, IPC and others. Not sure if
socket is stand alone enough to
zturner added a comment.
I still think implementation should be in Host as well. If the idea is to
simplify the creation scheme, then you could create an enum:
enum class SocketType {
Tcp,
Udp,
UnixDomain
};
and provide a static method on SocketBase like this:
class So
ovyalov added a comment.
In http://reviews.llvm.org/D14085#275442, @zturner wrote:
> I'm not sure I agree with this change. The interface to programming with
> socket is by definition a property of the Host operating system. It seems to
> me like Host was already the correct place for this co
Author: zturner
Date: Mon Oct 26 13:48:24 2015
New Revision: 251329
URL: http://llvm.org/viewvc/llvm-project?rev=251329&view=rev
Log:
Python 3: Convert uses of `callable(x)` to `six.callable(x)`.
Modified:
lldb/trunk/test/dotest.py
lldb/trunk/test/lldbcurses.py
lldb/trunk/test/lldbtes
Author: zturner
Date: Mon Oct 26 13:48:14 2015
New Revision: 251328
URL: http://llvm.org/viewvc/llvm-project?rev=251328&view=rev
Log:
Remove use of octal literals.
Python 3 has a different syntax for octal literals than Python 2
and they are incompatible with each other. Six doesn't provide
a tr
tberghammer created this revision.
tberghammer added a reviewer: clayborg.
tberghammer added a subscriber: lldb-commits.
Some minor improvements on the symtab parsing code
* Remove an unnecessary re-computation on arch spec from the ELF file
* Use a local cache to optimize name based section look
zturner added a subscriber: zturner.
zturner requested changes to this revision.
zturner added a reviewer: zturner.
zturner added a comment.
This revision now requires changes to proceed.
I'm not sure I agree with this change. The interface to programming with
socket is by definition a property
Author: tberghammer
Date: Mon Oct 26 13:10:55 2015
New Revision: 251319
URL: http://llvm.org/viewvc/llvm-project?rev=251319&view=rev
Log:
Fix an API missues in ParseTypeFromDWARF
The arguments for ClangASTContext::CreateMemberPointerType was passed
in in the wrong order.
Modified:
lldb/trunk
ovyalov created this revision.
ovyalov added a reviewer: clayborg.
ovyalov added a subscriber: lldb-commits.
Herald added subscribers: srhines, danalbert, tberghammer.
Make Socket to support plugin interface - moved implementation classes into
source/Plugins/Socket folder and migrated most of use
Author: gclayton
Date: Mon Oct 26 12:52:16 2015
New Revision: 251315
URL: http://llvm.org/viewvc/llvm-project?rev=251315&view=rev
Log:
Fixed the test suite on MacOSX so that
"test/api/multithreaded/TestMultithreaded.py" works without errors.
The problem was that the @skipIfNoSBHeaders on darwin
tfiala added a comment.
In http://reviews.llvm.org/D14060#275211, @labath wrote:
> We have XFAILed MI tests that were failing on our linux build bot. Atm, I am
> seeing expected passes, so I might try enabling them soon...
I have been seeing them fail intermittently on both OS X and Ubuntu
14
labath added inline comments.
Comment at:
source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp:1074-1079
@@ -1073,2 +1073,8 @@
+if (! broadcast_sent)
+{
+BroadcastEvent(eBroadcastBitRunPacketSent, NULL);
+
Author: gclayton
Date: Mon Oct 26 12:16:50 2015
New Revision: 251310
URL: http://llvm.org/viewvc/llvm-project?rev=251310&view=rev
Log:
Re-use prologue parsing code that was already written instead of having two
copies of code that parse line table prologues.
Also since we always read in the DWAR
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Looks good as long as we always want to send the broadcast even if the continue
packet fails to send.
Comment at:
source/Plugins/Process/gdb-remote/GDBRemoteCommunicatio
labath created this revision.
labath added a reviewer: clayborg.
labath added a subscriber: lldb-commits.
Gdb-remote's async thread sent out the eBroadcastBitRunPacketSent message
*before* actually
sending out the continue packet. Since it's this message the actually triggers
the public state
tr
Author: eugenezelenko
Date: Mon Oct 26 12:00:13 2015
New Revision: 251309
URL: http://llvm.org/viewvc/llvm-project?rev=251309&view=rev
Log:
Fix Clang-tidy modernize-use-override warnings in some files in source; other
minor fixes.
Modified:
lldb/trunk/source/Core/IOHandler.cpp
lldb/trunk
Author: zturner
Date: Mon Oct 26 11:50:51 2015
New Revision: 251304
URL: http://llvm.org/viewvc/llvm-project?rev=251304&view=rev
Log:
Python3 - Change `dict.has_key(x)` to `x in dict`
Modified:
lldb/trunk/test/functionalities/tty/TestTerminal.py
lldb/trunk/test/plugins/builder_base.py
Mo
Author: zturner
Date: Mon Oct 26 11:51:20 2015
New Revision: 251306
URL: http://llvm.org/viewvc/llvm-project?rev=251306&view=rev
Log:
Python3 - Change sys.maxint to sys.maxsize.
Python3 has no analogue to sys.maxint since ints in Python 3 have
arbitrary size. However, the distinction was not act
Author: zturner
Date: Mon Oct 26 11:51:28 2015
New Revision: 251307
URL: http://llvm.org/viewvc/llvm-project?rev=251307&view=rev
Log:
Wrap call to zip() in list()
Modified:
lldb/trunk/test/terminal/TestSTTYBeforeAndAfter.py
Modified: lldb/trunk/test/terminal/TestSTTYBeforeAndAfter.py
URL:
h
Author: zturner
Date: Mon Oct 26 11:51:36 2015
New Revision: 251308
URL: http://llvm.org/viewvc/llvm-project?rev=251308&view=rev
Log:
Fix tabs and spaces in one of the python files.
Modified:
lldb/trunk/examples/synthetic/gnu_libstdcpp.py
Modified: lldb/trunk/examples/synthetic/gnu_libstdcpp
Author: zturner
Date: Mon Oct 26 11:50:39 2015
New Revision: 251303
URL: http://llvm.org/viewvc/llvm-project?rev=251303&view=rev
Log:
Convert deprecated unittest method names.
Plural methods were long deprecated, and in Python 3 they are gone.
Convert to the actual supported method names.
Modifi
Author: zturner
Date: Mon Oct 26 11:51:09 2015
New Revision: 251305
URL: http://llvm.org/viewvc/llvm-project?rev=251305&view=rev
Log:
Convert `long` to `int`, and portably detect all integral types.
Modified:
lldb/trunk/test/functionalities/abbreviation/TestCommonShortSpellings.py
lldb/tr
Author: zturner
Date: Mon Oct 26 11:49:57 2015
New Revision: 251302
URL: http://llvm.org/viewvc/llvm-project?rev=251302&view=rev
Log:
Fix usages of range() and xrange() for Python 3.
Modified:
lldb/trunk/test/example/TestSequenceFunctions.py
lldb/trunk/test/functionalities/inferior-assert
Author: labath
Date: Mon Oct 26 11:25:28 2015
New Revision: 251301
URL: http://llvm.org/viewvc/llvm-project?rev=251301&view=rev
Log:
[lldb-server] Send PC of every thread along in the stop-reply packet
This avoids the need to query the PC for private resume operations (public
resumes have the PC
labath added a comment.
We have XFAILed MI tests that were failing on our linux build bot. Atm, I am
seeing expected passes, so I might try enabling them soon...
However, these tests are not remote-ready, so we have to skip them on the
android built bots.
http://reviews.llvm.org/D14060
___
tfiala accepted this revision.
tfiala added a comment.
LGTM.
Who currently owns the MI tests (or system) these days? I suppose you are
doing this to squelch them from failing on the buildbots. On our end, we see
the MI tests fail fairly frequently, typically intermittently.
http://reviews.l
Author: ewancrawford
Date: Mon Oct 26 09:04:37 2015
New Revision: 251293
URL: http://llvm.org/viewvc/llvm-project?rev=251293&view=rev
Log:
[RenderScript] Add option to break on a specific kernel invocation
Adds option -c to the 'language renderscript kernel breakpoint set'
command.
Breaks onl
labath added a comment.
In http://reviews.llvm.org/D14060#274952, @tberghammer wrote:
> Before commit please sync with Ying about updating all android build bot to
> still skip the MI tests after the change.
I've got it covered. :)
I will commit this tomorrow, to give more people a chance to
tberghammer added a subscriber: tberghammer.
tberghammer added a comment.
Before commit please sync with Ying about updating all android build bot to
still skip the MI tests after the change.
http://reviews.llvm.org/D14060
___
lldb-commits mailing
tberghammer accepted this revision.
tberghammer added a comment.
This revision is now accepted and ready to land.
LGTM
http://reviews.llvm.org/D14051
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/lis
ki.stfu accepted this revision.
ki.stfu added a comment.
This revision is now accepted and ready to land.
lgtm
http://reviews.llvm.org/D14060
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/ll
labath created this revision.
labath added reviewers: tfiala, dawn, ki.stfu, abidh.
labath added a subscriber: lldb-commits.
This change deprecates -m/+m dotest options (the options are still recognized
but they print an
error message pointing to the new options) and adds a new lldb-mi test categ
Author: tberghammer
Date: Mon Oct 26 05:53:58 2015
New Revision: 251282
URL: http://llvm.org/viewvc/llvm-project?rev=251282&view=rev
Log:
Fix a fission expression evaluation issue
This fix should eliminate the duplicate definition errors when debug
info is available in multiple dwo symbol file fo
This revision was automatically updated to reflect the committed changes.
Closed by commit rL251277: Port the python api decorator to use test categories
(authored by labath).
Changed prior to commit:
http://reviews.llvm.org/D14020?vs=38235&id=38383#toc
Repository:
rL LLVM
http://reviews.ll
54 matches
Mail list logo
