zturner added a comment.

Do we need this `GetScheme()` method?  And instead of having `Create` take a 
string, couldn't it just take a `SocketProtocol` instead?  It seems like the 
logic of converting the string to the enum should be done in the `Acceptor` 
class, as this URI format is defined by the acceptor, and the socket itself is 
just a low-level host layer abstraction.


http://reviews.llvm.org/D14085



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to