jaydeep added a comment.
Hi Dwan,
Could you please try http://reviews.llvm.org/rL247968 and let me know if the
issue persist?
Thanks,
Jaydeep
Users:
jaydeep (Author)
dawn (Auditor)
http://reviews.llvm.org/rL247773
___
lldb-commits mailing l
brucem added a subscriber: brucem.
Comment at: tools/lldb-server/CMakeLists.txt:42
@@ +41,3 @@
+ if (LLDB_VERS_GENERATED_FILE)
+add_dependencies(lldb-server swig_wrapper)
+ endif()
Why is this needed?
Repository:
rL LLVM
http://reviews.llvm.org/D13535
This revision was automatically updated to reflect the committed changes.
Closed by commit rL249651: [LLDB][MIPS] microMIPS load/store instruction
emulation for hardware watchpoints (authored by mohit.bhakkad).
Changed prior to commit:
http://reviews.llvm.org/D13493?vs=36704&id=36824#toc
Repos
Author: mohit.bhakkad
Date: Wed Oct 7 22:34:11 2015
New Revision: 249651
URL: http://llvm.org/viewvc/llvm-project?rev=249651&view=rev
Log:
[LLDB][MIPS] microMIPS load/store instruction emulation for hardware watchpoints
Reviewers: clayborg.
Subscribers: jaydeep, bhushan, sagar, nitesh.jain, lldb
dawn added a comment.
What other details are you looking for?
Users:
jaydeep (Author)
dawn (Auditor)
http://reviews.llvm.org/rL247773
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-
lgtm is just as good as hitting accept in Phabricator, I just can't login
to Phab right now so I'm using email. Feel free to commit
On Wed, Oct 7, 2015 at 8:24 PM Dawn Perchik wrote:
> dawn added a comment.
>
> Can someone accept this patch so I can commit please?
>
>
> Repository:
> rL LLVM
dawn added a comment.
Can someone accept this patch so I can commit please?
Repository:
rL LLVM
http://reviews.llvm.org/D13535
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Ok, lgtm then.
On Wed, Oct 7, 2015 at 7:25 PM Dawn Perchik wrote:
> dawn added a comment.
>
> Works fine on Linux too.
>
>
> Repository:
> rL LLVM
>
> http://reviews.llvm.org/D13535
>
>
>
>
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
ht
dawn added a comment.
Works fine on Linux too.
Repository:
rL LLVM
http://reviews.llvm.org/D13535
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
brucem requested changes to this revision.
brucem added a comment.
This revision now requires changes to proceed.
This also has the whitespace changes and needs rebasing forward. (And a
question for someone about the nature of one of the changes.)
Comment at: source/Plugins/ABI
brucem requested changes to this revision.
brucem added a comment.
This revision now requires changes to proceed.
There are a number of places where you've changed spaces to tabs ... Also the
GetShortPluginName has already been removed. Please rebase forward and correct
the whitespace issues.
brucem requested changes to this revision.
brucem added a comment.
This revision now requires changes to proceed.
This doesn't currently apply. (Probably true of your others as well.) Please
update.
Repository:
rL LLVM
http://reviews.llvm.org/D12606
___
sivachandra updated this revision to Diff 36818.
sivachandra added a comment.
Rebase.
http://reviews.llvm.org/D12809
Files:
include/lldb/Symbol/ClangASTContext.h
include/lldb/Symbol/CompilerDeclContext.h
include/lldb/Symbol/SymbolFile.h
include/lldb/Symbol/TypeSystem.h
include/lldb/Ta
sivachandra added a comment.
Another friendly ping.
http://reviews.llvm.org/D12809
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
brucem requested changes to this revision.
brucem added a comment.
This revision now requires changes to proceed.
Could you rebase this forward so that it applies cleanly?
Repository:
rL LLVM
http://reviews.llvm.org/D12611
___
lldb-commits mailin
brucem accepted this revision.
brucem added a comment.
This revision is now accepted and ready to land.
I can land this for you. I'd like it to go in as I have another patch myself
that addresses almost all of the Plugins directory, so if I land this, I'll
rebase on top of it and submit mine for
dawn added a comment.
In http://reviews.llvm.org/D13535#262225, @zturner wrote:
> I can't verify that this works on MacOSX at the moment. Did you verify that
> this works on other platforms as well?
I've confirmed it works on MacOSX - I'll try to test Linux later today if no
one beats me to
zturner added inline comments.
Comment at: unittests/ScriptInterpreter/CMakeLists.txt:4
@@ +3,1 @@
+endif()
\ No newline at end of file
Missed this one in my updated patch, but I fixed it locally. Don't want to
update a 3rd revision just for a newline though.
zturner updated this revision to Diff 36806.
zturner added a comment.
Do you mind giving this a run on MacOSX and verifying it still compiles and
test suite passes?
http://reviews.llvm.org/D13537
Files:
source/Plugins/ScriptInterpreter/Python/PythonDataObjects.cpp
source/Plugins/ScriptInte
Author: gclayton
Date: Wed Oct 7 17:36:52 2015
New Revision: 249631
URL: http://llvm.org/viewvc/llvm-project?rev=249631&view=rev
Log:
Expected fail this test and supplied the radar number that is tracking the fix.
Modified:
lldb/trunk/test/macosx/queues/TestQueues.py
Modified: lldb/trunk/t
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
Few minor changes.
Comment at:
source/Plugins/ScriptInterpreter/Python/ScriptInterpreterPython.cpp:1183
@@ +1182,3 @@
+llvm::StringRef value_str(str
zturner created this revision.
zturner added reviewers: clayborg, granata.enrico.
zturner added a subscriber: lldb-commits.
With this change, liblldb is 95% of the way towards being able
to work under both Python 2.x and Python 3.x. This should
introduce no functional change for Python 2.x, but f
Author: sivachandra
Date: Wed Oct 7 17:11:52 2015
New Revision: 249629
URL: http://llvm.org/viewvc/llvm-project?rev=249629&view=rev
Log:
[DWARFASTParserClang] Strengthen incomplete type handling.
Summary: This change fixes pr24916. As associated test has been added.
Reviewers: clayborg
Subscri
sivachandra updated this revision to Diff 36805.
sivachandra added a comment.
Rebase.
http://reviews.llvm.org/D13224
Files:
source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp
test/lang/cpp/limit-debug-info/Makefile
test/lang/cpp/limit-debug-info/TestWithLimitDebugInfo.py
test/lang/
Author: gclayton
Date: Wed Oct 7 17:07:33 2015
New Revision: 249626
URL: http://llvm.org/viewvc/llvm-project?rev=249626&view=rev
Log:
Fix the TestCppNsImport test case for DWARF. It was failing for DWARF in .o
files because SymbolFileDWARFDebugMap didn't implement the following function:
void
P
Author: gclayton
Date: Wed Oct 7 17:06:08 2015
New Revision: 249625
URL: http://llvm.org/viewvc/llvm-project?rev=249625&view=rev
Log:
Don't do DWO tests on darwin as they aren't supported. If this is an error and
they are supported, we need to add support _only_ if the clang compiler that is
be
This revision was automatically updated to reflect the committed changes.
Closed by commit rL249624: Decide on the expression language inside
UserExpression (authored by dperchik).
Changed prior to commit:
http://reviews.llvm.org/D13267?vs=36029&id=36803#toc
Repository:
rL LLVM
http://revie
Author: dperchik
Date: Wed Oct 7 17:01:12 2015
New Revision: 249624
URL: http://llvm.org/viewvc/llvm-project?rev=249624&view=rev
Log:
Decide on the expression language inside UserExpression
When the target settings are consulted to decide the expression language
is decided in CommandObjectExpres
zturner added a comment.
I can't verify that this works on MacOSX at the moment. Did you verify that
this works on other platforms as well?
Repository:
rL LLVM
http://reviews.llvm.org/D13535
___
lldb-commits mailing list
lldb-commits@lists.llvm
dawn added a comment.
See http://reviews.llvm.org/D13535 for a workaround.
Users:
sas (Author)
dawn (Auditor)
http://reviews.llvm.org/rL249434
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listi
dawn created this revision.
dawn added reviewers: sas, clayborg, zturner.
dawn added a subscriber: lldb-commits.
dawn set the repository for this revision to rL LLVM.
This fixes the cmake build on OSX when building in a new workspace. It
reverts r249434 and instead fixes the issue as proposed i
dawn added a subscriber: dawn.
dawn raised a concern with this commit.
dawn added a comment.
This broke the lldb build on OSX using cmake. After this commit, we get:
CMake Error at cmake/modules/AddLLVM.cmake:401 (add_library):
Cannot find source file:
/Users/testuser/build/works
dawn added a subscriber: lldb-commits.
Users:
sas (Author)
http://reviews.llvm.org/rL249434
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: gclayton
Date: Wed Oct 7 15:38:20 2015
New Revision: 249613
URL: http://llvm.org/viewvc/llvm-project?rev=249613&view=rev
Log:
This test is useless. It doesn't work and it fails on MacOSX. Removing it.
Removed:
lldb/trunk/test/functionalities/connect_remote/EchoServer.py
lldb/tru
Author: gclayton
Date: Wed Oct 7 15:08:26 2015
New Revision: 249605
URL: http://llvm.org/viewvc/llvm-project?rev=249605&view=rev
Log:
Another stripped test that requires darwin and a dSYM (no Dwarf or DWO).
Modified:
lldb/trunk/test/lang/objc/objc-static-method-stripped/TestObjCStaticMethod
Author: gclayton
Date: Wed Oct 7 15:06:45 2015
New Revision: 249604
URL: http://llvm.org/viewvc/llvm-project?rev=249604&view=rev
Log:
More fixes for binaries that we strip. When we strip a binary we can't do Dwarf
or DWO.
Modified:
lldb/trunk/test/lang/objc/hidden-ivars/TestHiddenIvars.py
Author: gclayton
Date: Wed Oct 7 15:01:13 2015
New Revision: 249601
URL: http://llvm.org/viewvc/llvm-project?rev=249601&view=rev
Log:
Fix a test that should only be run with a dSYM file by adding @skipIfDwarf and
using a new @skipIfDWO.
Modified:
lldb/trunk/test/lang/objc/objc-ivar-strippe
Author: gclayton
Date: Wed Oct 7 15:00:28 2015
New Revision: 249600
URL: http://llvm.org/viewvc/llvm-project?rev=249600&view=rev
Log:
Fixed up some first responder issues and added menubar support that isn't in
use yet.
Modified:
lldb/trunk/test/curses_results.py
lldb/trunk/test/lldbcu
Author: dperchik
Date: Wed Oct 7 14:55:33 2015
New Revision: 249597
URL: http://llvm.org/viewvc/llvm-project?rev=249597&view=rev
Log:
[lldb-mi] Fix evaluation of strings containing characters from non-ascii range
If a string contained characters outside the ASCII range, lldb-mi would
print them
This revision was automatically updated to reflect the committed changes.
Closed by commit rL249597: [lldb-mi] Fix evaluation of strings containing
characters from non-ascii range (authored by dperchik).
Changed prior to commit:
http://reviews.llvm.org/D13058?vs=36341&id=36782#toc
Repository:
KLapshin added a comment.
In http://reviews.llvm.org/D12968#259931, @clayborg wrote:
> This can't be the real fix for this. We must be able to trust the empty()
> function call. We must have someone playing with the collection without
> locking the mutex. Please find the real bug.
Hello @clay
KLapshin added a comment.
In http://reviews.llvm.org/D12968#261762, @labath wrote:
> I have committed http://reviews.llvm.org/D13056 with the event hijacking
> portion from your patch. I think your use case should be working now. I am
> planning to return to this later, as I believe there are s
Author: enrico
Date: Wed Oct 7 13:36:53 2015
New Revision: 249587
URL: http://llvm.org/viewvc/llvm-project?rev=249587&view=rev
Log:
This is the work I was building up to with my patches yesterday
Introduce the notion of Language-based formatter prefix/suffix
This is meant for languages that shar
Author: sylvestre
Date: Wed Oct 7 13:26:29 2015
New Revision: 249585
URL: http://llvm.org/viewvc/llvm-project?rev=249585&view=rev
Log:
Revert commit -r249558 as it is not fixing the issue :/
Modified:
lldb/trunk/lib/Makefile
Modified: lldb/trunk/lib/Makefile
URL:
http://llvm.org/viewvc/llv
zturner added a comment.
Looks good, thanks.
Repository:
rL LLVM
http://reviews.llvm.org/D13520
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
enlight created this revision.
enlight added reviewers: zturner, brucem.
enlight added a subscriber: lldb-commits.
enlight set the repository for this revision to rL LLVM.
Previously CMake would display messages like these:
```
-- LLDB Found PythonExecutable:
$<$:C:/Projects/Python-2.7.9-bin/x64
This revision was automatically updated to reflect the committed changes.
Closed by commit rL249570: Reduce header inclusion in Expression. (authored by
brucem).
Changed prior to commit:
http://reviews.llvm.org/D1?vs=36760&id=36762#toc
Repository:
rL LLVM
http://reviews.llvm.org/D1
Author: brucem
Date: Wed Oct 7 12:22:54 2015
New Revision: 249570
URL: http://llvm.org/viewvc/llvm-project?rev=249570&view=rev
Log:
Reduce header inclusion in Expression.
Reviewers: spyffe
Subscribers: lldb-commits
Differential Revision: http://reviews.llvm.org/D1
Modified:
lldb/trunk
brucem updated this revision to Diff 36760.
brucem added a comment.
Rebase forward.
http://reviews.llvm.org/D1
Files:
include/lldb/Expression/ExpressionParser.h
include/lldb/Expression/ExpressionVariable.h
include/lldb/Expression/FunctionCaller.h
include/lldb/Expression/IRInterprete
This revision was automatically updated to reflect the committed changes.
Closed by commit rL249563: Remove unused virtuals from ABISysV_ppc* (authored
by brucem).
Changed prior to commit:
http://reviews.llvm.org/D13506?vs=36726&id=36753#toc
Repository:
rL LLVM
http://reviews.llvm.org/D1350
Author: brucem
Date: Wed Oct 7 11:48:33 2015
New Revision: 249563
URL: http://llvm.org/viewvc/llvm-project?rev=249563&view=rev
Log:
Remove unused virtuals from ABISysV_ppc*
Summary:
The StackUsesFrames and FunctionCallsChangeCFA virtual functions
aren't used anywhere and aren't overridden by any
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Thanks for the info, now the patch makes more sense. That is some really lame
DWARF I must say, but alas we must deal with it. Looks good.
http://reviews.llvm.org/D13224
__
Author: emaste
Date: Wed Oct 7 11:21:43 2015
New Revision: 249561
URL: http://llvm.org/viewvc/llvm-project?rev=249561&view=rev
Log:
Add expectedFailureFreeBSD for Go runtime test
AssertionError: False is not True : No thread stopped at our breakpoint.
llvm.org/pr24895
Modified:
lldb/trunk/
Author: sylvestre
Date: Wed Oct 7 11:13:10 2015
New Revision: 249558
URL: http://llvm.org/viewvc/llvm-project?rev=249558&view=rev
Log:
Fix a linking issue on lib lldb linking with the new Go support
Modified:
lldb/trunk/lib/Makefile
Modified: lldb/trunk/lib/Makefile
URL:
http://llvm.org/vi
sivachandra added a comment.
I will use an example to explain the problem that this patch is trying to solve.
class.h:
class C
{
public:
C () {
c = 0;
}
virtual int method();
private:
int c;
};
class.cpp:
#include "class.h"
int
C::meth
labath added a comment.
I have committed http://reviews.llvm.org/D13056 with the event hijacking
portion from your patch. I think your use case should be working now. I am
planning to return to this later, as I believe there are still some edge cases
lurking here.
Repository:
rL LLVM
http:
Author: labath
Date: Wed Oct 7 10:11:11 2015
New Revision: 249554
URL: http://llvm.org/viewvc/llvm-project?rev=249554&view=rev
Log:
Resumbit "Fix race condition during process detach"
This is a resubmission of r248371. It also incorporates the process event
hijack patch by Kyrill
Lapshin in D12
Author: tberghammer
Date: Wed Oct 7 09:52:16 2015
New Revision: 249549
URL: http://llvm.org/viewvc/llvm-project?rev=249549&view=rev
Log:
Fix race condition in the working directory cleanup code
Modified:
lldb/trunk/test/lldbtest.py
Modified: lldb/trunk/test/lldbtest.py
URL:
http://llvm.org
jhibbits accepted this revision.
jhibbits added a comment.
This revision is now accepted and ready to land.
In http://reviews.llvm.org/D13506#261638, @brucem wrote:
> There's nothing to test here short of "Does it compile?" as these functions
> aren't actually used anywhere. I'm cleaning out dea
brucem added a comment.
There's nothing to test here short of "Does it compile?" as these functions
aren't actually used anywhere. I'm cleaning out dead virtuals in various
patches.
http://reviews.llvm.org/D13506
___
lldb-commits mailing list
lldb
jhibbits added a comment.
Backtraces do work now, for ppc at least (ppc64 IIRC still has issues dealing
with the function descriptors, but traversing the backchain does work). I can
test this after I get my system set up from my move, but if you've tested it
either natively or on a core then I
brucem marked 2 inline comments as done.
brucem added a comment.
http://reviews.llvm.org/D13503
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: tberghammer
Date: Wed Oct 7 07:38:29 2015
New Revision: 249541
URL: http://llvm.org/viewvc/llvm-project?rev=249541&view=rev
Log:
Remove working directory from remote platform in the test suite
Previously we haven't cleaned up the working directory we created on
the remote platform and be
Author: tberghammer
Date: Wed Oct 7 06:40:10 2015
New Revision: 249539
URL: http://llvm.org/viewvc/llvm-project?rev=249539&view=rev
Log:
XFAIL new dwo test failing with totclang on linux i386
Modified:
lldb/trunk/test/functionalities/breakpoint/breakpoint_locations/TestBreakpointLocations.p
jaydeep added a comment.
Hi Dawn,
Could you please provide more details on this?
Thanks,
Jaydeep
Users:
jaydeep (Author)
dawn (Auditor)
http://reviews.llvm.org/rL247968
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.ll
jaydeep added a comment.
Hi Dawn,
Could you please provide more details on this?
Thanks,
Jaydeep
Users:
jaydeep (Author)
dawn (Auditor)
http://reviews.llvm.org/rL247773
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.ll
brucem created this revision.
brucem added reviewers: clayborg, jingham, jhibbits, emaste.
brucem added a subscriber: lldb-commits.
The StackUsesFrames and FunctionCallsChangeCFA virtual functions
aren't used anywhere and aren't overridden by anything.
They were introduced when the ABISysV_ppc* c
Author: brucem
Date: Wed Oct 7 05:11:10 2015
New Revision: 249533
URL: http://llvm.org/viewvc/llvm-project?rev=249533&view=rev
Log:
Fix minor typos in comments.
Modified:
lldb/trunk/source/Commands/CommandObjectExpression.cpp
lldb/trunk/source/Commands/CommandObjectTarget.cpp
lldb/tr
tberghammer added a comment.
I committed in this CL in its current state (with fixing the issues raised by
Pavel).
If you see any of the newly added dwo test failing on your platform then please
skip/xfail them accordingly or let me know so I can take a look.
If you have to disable the running
This revision was automatically updated to reflect the committed changes.
Closed by commit rL249530: Run tests with dwo symbol files (authored by
tberghammer).
Changed prior to commit:
http://reviews.llvm.org/D13300?vs=36114&id=36723#toc
Repository:
rL LLVM
http://reviews.llvm.org/D13300
F
Author: tberghammer
Date: Wed Oct 7 05:02:17 2015
New Revision: 249530
URL: http://llvm.org/viewvc/llvm-project?rev=249530&view=rev
Log:
Run tests with dwo symbol files
dwo symbol files are generated when code compiled with the "-gsplit-dwarf"
command option (https://gcc.gnu.org/wiki/DebugFissio
Author: brucem
Date: Wed Oct 7 05:02:24 2015
New Revision: 249531
URL: http://llvm.org/viewvc/llvm-project?rev=249531&view=rev
Log:
[Go] Fix inconsistent-missing-override warnings.
Modified:
lldb/trunk/source/Plugins/LanguageRuntime/Go/GoLanguageRuntime.h
Modified: lldb/trunk/source/Plugins
labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
Looks good. You can also fix a couple of style issues, if you feel like it (or
just keep it in mind for next time).
Comment at: source/Commands/CommandObjectMemory.cpp:381
@@
Sure. Thanks a lot for suggesting this.
Thanks & Regards
Abhishek Aggarwal
From: Zachary Turner [mailto:ztur...@google.com]
Sent: Tuesday, October 6, 2015 6:01 PM
To: Aggarwal, Abhishek A; lldb-commits@lists.llvm.org
Subject: Re: [Lldb-commits] [lldb] r249379 - Bug 25050: X87 FPU Special Purpose
mohit.bhakkad created this revision.
mohit.bhakkad added a reviewer: clayborg.
mohit.bhakkad added subscribers: jaydeep, bhushan, sagar, nitesh.jain,
lldb-commits.
mohit.bhakkad set the repository for this revision to rL LLVM.
Repository:
rL LLVM
http://reviews.llvm.org/D13493
Files:
source
75 matches
Mail list logo
