Re: [Live-devel] Potential Issues in ReorderingPacketBuffer Class Implementation

2008-09-18 Thread Guy Bonneau
> No, each of the "BufferedPacket"s in the chain will be > deleted as a result of the call to "delete fHeadPacket;", > because the "BufferedPacket" destructor includes the line > "delete fNextPacket;". Indeed !!! Thanks for the clarification. Its much appreciated. _

Re: [Live-devel] Potential Issues in ReorderingPacketBuffer Class Implementation

2008-09-17 Thread Ross Finlayson
The first issue is related to : delete fHeadPacket when reset() method of ReorderingPacketBuffer is called. The fHeadPacket pointer can be NULL if it is calling in the context of ~ReorderingPacketBuffer() when the medium source is closed. I know it legal on C++ but it is confusing for someone t

[Live-devel] Potential Issues in ReorderingPacketBuffer Class Implementation

2008-09-17 Thread Guy Bonneau
Ross, While reviewing the code of Class ReorderingPacketBuffer in file MultiFramedRTPSource.cpp I think I might have found potential issues. The first issue is related to : delete fHeadPacket when reset() method of ReorderingPacketBuffer is called. The fHeadPacket pointer can be NULL if it is