[Linuxdcpp-team] [Bug 1756881] Re: Remove Coral CDN support from DC++

2018-11-11 Thread poy
Fixed in DC++ 0.868. ** Changed in: dcplusplus Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to DC++. https://bugs.launchpad.net/bugs/1756881 Title: Remove Coral CDN support from DC++ Status

[Linuxdcpp-team] [Bug 1791463] Re: Full build information is sent in VE to pingers

2018-09-18 Thread poy
the dev build number indeed matters - as is, I can agree with removing it from "final" builds (where the version number has been increased) only. the separate INF field sounds nicer. -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to ADCH++.

[Linuxdcpp-team] [Bug 880488] Re: Rev 543 disconnects PING user

2018-09-18 Thread poy
workaround which sent the hub's INF earlier (before full user login) removed in the next ADCH++ version. the workaround was limited to an old (now unused) IP anyways. for reference, that workaround could not be generalized as it could result in information being sent about private hubs without ha

[Linuxdcpp-team] [Bug 1791793] Re: Recent versions of build tools cannot be used to compile ADCH++

2018-09-18 Thread poy
builds again now with MinGW (links in the expert guide doc), SCons 2.5.0, boost 1.68, OpenSSL 1.1.1. ** Changed in: adchpp Status: New => Fix Committed -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to ADCH++. https://bugs.launchpad.

[Linuxdcpp-team] [Bug 1774502] Re: Free GeoIP Database Format Change

2018-06-01 Thread poy
GeoLite 2 still has the info we use from GeoLite 1 databases, especially city-level geoloc, IPv6 support, region names... unfortunately is licensed under Apache License 2 which is compatible with GPL 3 but not GPL 2 because of a missing patent clause in

[Linuxdcpp-team] [Bug 1728221] Re: uploading files to other users

2017-10-28 Thread poy
*** This bug is a duplicate of bug 1638038 *** https://bugs.launchpad.net/bugs/1638038 ** This bug has been marked a duplicate of bug 1638038 32-bit version crashes due to alignment issues -- You received this bug notification because you are a member of Dcplusplus-team, which is subscrib

[Linuxdcpp-team] [Bug 1722364] Re: Invalid ADC commands sent via UDP will crash the app

2017-10-16 Thread poy
Fixed in DC++ 0.867. ** Changed in: dcplusplus Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to DC++. https://bugs.launchpad.net/bugs/1722364 Title: Invalid ADC commands sent via UDP will cra

[Linuxdcpp-team] [Bug 1722364] Re: Invalid ADC commands sent via UDP will crash the app

2017-10-11 Thread poy
what a nice patch! thanks, applied. I especially liked the variadic template... ;) - has anyting changed in the NMDC parsing part? hard to catch that from the patch. - as I'm a bit rusty... could the "x[x.length() - 1] != 0x0a" check crash on empty data? it was after a "x.compare(1, 4, "RES ") ==

[Linuxdcpp-team] [Bug 1722364] Re: Invalid ADC commands sent via UDP will crash the app

2017-10-10 Thread poy
makes perfect sense. a similar patch for DC++ would be very welcome. :) nitpick: I'd change "public CommandHandler" to private. -- You received this bug notification because you are a member of Dcplusplus-team, w

[Linuxdcpp-team] [Bug 1707507] Re: DC++ crashes when i open a particular user's file list

2017-08-01 Thread poy
-- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to DC++. https://bugs.launchpad.net/bugs/1707507 Title: DC++ crashes when i open a particular user's file list Status in DC+

[Linuxdcpp-team] [Bug 609834] Re: Windows 7 Taskbar features

2017-07-25 Thread poy
I fail to see the relation between taskbar thumbnails, the amount of tabs, and the inability to minimize DC++. for the first problem, they may be globally disabled (for the whole Windows system, not just DC++) if you feel they bother you. the amount of tabs shouldn't be an issue. after about 15 t

[Linuxdcpp-team] [Bug 1705496] [NEW] UPnP renewal

2017-07-20 Thread poy
Public bug reported: on by the miniupnp author: "Unfortunately you cannot rely on Home routers to properly fire the right events in case the IP change or a mapping is not good anymore. I advice to periodically (every few minutes) call GetSpecificPortMapping

[Linuxdcpp-team] [Bug 1681153] Re: Sending a lot of empty lines to main chat makes DC++ to hang

2017-05-20 Thread poy
Fixed in DC++ 0.866. ** Changed in: dcplusplus Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to DC++. https://bugs.launchpad.net/bugs/1681153 Title: Sending a lot of empty lines to main chat

[Linuxdcpp-team] [Bug 1681153] Re: Sending a lot of empty lines to main chat makes DC++ to hang

2017-05-08 Thread poy
there were several issues - see rev 87aa1e0fcb086d82243e517310c192a049275582 and the one before for defatils. essentially, a loop trying to make room for text being added was not finding enough lines to strip off and was therefore running infinitely. I've also fixed scolling in the process, which

[Linuxdcpp-team] [Bug 1681153] Re: Sending a lot of empty lines to main chat makes DC++ to hang

2017-04-27 Thread poy
hoho, this is actually caused by our code! the offending bit is the while loop in dwt::RichTextBox::addTextSteady (dwt/src/widgets/RichTextBox.cpp:258) - that code attempts to remove old lines when adding new ones. anyone can debug / figure out what precisely the loop does and fix it the right wa

[Linuxdcpp-team] [Bug 1681153] Re: Sending a lot of empty lines to main chat makes DC++ to hang

2017-04-26 Thread poy
maybe I should have clarified in my previous message - I was hoping others would look into this now that a test case is there; rebuilds in a breeze with: scons build/[...]/dwt/test just pushed a few tweaks; interestingly, adding 2 chars or more per line fixes the issue here... (but 1 is not enoug

[Linuxdcpp-team] [Bug 1681153] Re: Sending a lot of empty lines to main chat makes DC++ to hang

2017-04-10 Thread poy
** Attachment added: "Backtrace from RichTextBoxTest when it freezes" https://bugs.launchpad.net/dcplusplus/+bug/1681153/+attachment/4859877/+files/test-bt.txt -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to DC++. https://bugs.launchpa

[Linuxdcpp-team] [Bug 1681153] Re: Sending a lot of empty lines to main chat makes DC++ to hang

2017-04-10 Thread poy
this is a limitation in the Rich Edit control we use to display chat messages. rev 62243417be3658a8aeaf25d6b6a6a0432df2b4bf adds a little test one can easily tweak to reproduce. the most straight-forward resolution is to cut these messages when it is known they are hitting on Rich Edit limits. -

[Linuxdcpp-team] [Bug 1681153] Re: Sending a lot of empty lines to main chat makes DC++ to hang

2017-04-10 Thread poy
** Attachment added: "Backtrace from DC++ when it freezes" https://bugs.launchpad.net/dcplusplus/+bug/1681153/+attachment/4859876/+files/dcpp-bt.txt -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to DC++. https://bugs.launchpad.net/bugs/

[Linuxdcpp-team] [Bug 1681153] Re: Sending a lot of empty lines to main chat makes DC++ to hang

2017-04-10 Thread poy
** Attachment added: "ADCH++ test script" https://bugs.launchpad.net/dcplusplus/+bug/1681153/+attachment/4859869/+files/test-lots-of-new-lines.lua -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to DC++. https://bugs.launchpad.net/bugs/16

[Linuxdcpp-team] [Bug 1656050] Re: Compression errors with zlib 1.2.11

2017-02-01 Thread poy
Fixed in DC++ 0.865. ** Changed in: dcplusplus Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to DC++. https://bugs.launchpad.net/bugs/1656050 Title: Compression errors with zlib 1.2.11 Statu

[Linuxdcpp-team] [Bug 1656050] Re: Compression errors with zlib 1.2.11

2017-01-30 Thread poy
this is actually easy to reproduce once one understands the causes. :) pushed a test case that simulates compression being dynamically disabled, along with the fix I attached here (but with proper guards based on the zlib version). ** Changed in: dcplusplus Status: Confirmed => Fix Committ

[Linuxdcpp-team] [Bug 1656050] Re: Compression errors with zlib 1.2.10

2017-01-18 Thread poy
patch that might work, cooked up by following the deflateParams doc. please test. ** Patch added: "zlib-deflateparams.patch" https://bugs.launchpad.net/dcplusplus/+bug/1656050/+attachment/4806035/+files/zlib-deflateparams.patch -- You received this bug notification because you are a member o

[Linuxdcpp-team] [Bug 1656337] Re: DC++ crash when running DescriptionRotator plugin

2017-01-15 Thread poy
happens only with the 64-bit version; the 32-bit one works fine. backtrace from a GDB run (haven't looked further into this yet): #0 0x07fefec159e0 in strlen () from C:\Windows\system32\msvcrt.dll #1 0x0062c423 in std::char_traits::length ( __s=0xabababababababab ) at H:/min

[Linuxdcpp-team] [Bug 1654411] Re: sharing filtering can't add words in upper, lower and/or mixed case

2017-01-09 Thread poy
Fixed in DC++ 0.864. ** Changed in: dcplusplus Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to DC++. https://bugs.launchpad.net/bugs/1654411 Title: sharing filtering can't add words in upper

[Linuxdcpp-team] [Bug 1654329] Re: Crash on search

2017-01-09 Thread poy
Fixed in DC++ 0.864. ** Changed in: dcplusplus Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to DC++. https://bugs.launchpad.net/bugs/1654329 Title: Crash on search Status in DC++: Fix Rel

[Linuxdcpp-team] [Bug 1654411] Re: sharing filtering can't add words in upper, lower and/or mixed case

2017-01-08 Thread poy
rev ae6d4c5bb320 removes these uniqueness checks. I leave it to future improvements to allow for both case-sensitive and case-insensitive checks? ** Changed in: dcplusplus Status: Confirmed => Fix Committed ** Changed in: dcplusplus Assignee: Fredrik Ullner (ullner) => (unassigned) -

[Linuxdcpp-team] [Bug 1654329] Re: Crash on search

2017-01-08 Thread poy
your patch looks good to me: - we did not ignore these results before; no reason to start ignoring them now. - a default-initialized dcpp::Style is fine. ** Changed in: dcplusplus Status: Confirmed => Fix Committed -- You received this bug notification because you are a member of Dcpluspl

[Linuxdcpp-team] [Bug 1649066] Re: Invalid UTF-8 data is not always being rejected

2016-12-19 Thread poy
good point about favs. maybe the download queue & hash files would be of concern as well? could we handle them through some upgrade step? could be done outside of the XML parsing code, launched for these "precious" files when the XML parser encounters a validation error? some best effort to repl

[Linuxdcpp-team] [Bug 1649066] Re: Invalid UTF-8 data is not always being rejected

2016-12-18 Thread poy
applied - utf8-validation-1649066 bookmark. TODO - could you please: - add a test case for this in test/testxml.cpp? - make this somehow optional so current hub lists keep working for now? and I'd be interested in knowing how much this impacts the time it takes to parse some big file lists... --

[Linuxdcpp-team] [Bug 1628615] Re: Extend users nick coloring rules throughout the whole UI

2016-11-11 Thread poy
Fixed in DC++ 0.863. ** Changed in: dcplusplus Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to DC++. https://bugs.launchpad.net/bugs/1628615 Title: Extend users nick coloring rules throughou

[Linuxdcpp-team] [Bug 1638038] Re: 32-bit version crashes due to alignment issues

2016-11-11 Thread poy
Fixed in DC++ 0.863. ** Changed in: dcplusplus Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to DC++. https://bugs.launchpad.net/bugs/1638038 Title: 32-bit version crashes due to alignment is

[Linuxdcpp-team] [Bug 1638038] Re: 32-bit version crashes due to alignment issues

2016-11-10 Thread poy
** Summary changed: - Crashes with chunked transfers on Windows 10 x86 (DC++ 0.862) + 32-bit version crashes due to alignment issues ** Changed in: dcplusplus Status: Confirmed => Fix Committed -- You received this bug notification because you are a member of Dcplusplus-team, which is su

[Linuxdcpp-team] [Bug 1638038] Re: Crashes with chunked transfers on Windows 10 x86 (DC++ 0.862)

2016-11-10 Thread poy
Hey, Don't bother with these tests - eMTee has been able to reproduce the issue and we are closing in on a fix. -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to DC++. https://bugs.launchpad.net/bugs/1638038 Title: Crashes with chunked t

[Linuxdcpp-team] [Bug 1638038] Re: Crash after an upload transfer has finished (DC++ 0.862)

2016-11-05 Thread poy
Hi, I know this is asking for a lot on your side, but since the crash log doesn't tell us much, could you try the 2 versions in-between 0.851 & 0.862? You can see them on ; take the .exe file to get the automated installer. If you get crash repo

[Linuxdcpp-team] [Bug 1628615] Re: Extend users nick coloring rules throughout the whole UI

2016-10-10 Thread poy
hey, I like it! you have taken good care of locking / performance / etc. -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to DC++. https://bugs.launchpad.net/bugs/1628615 Title: Extend users nick coloring rules throughout the whole UI Sta

[Linuxdcpp-team] [Bug 1629574] Re: Automatic Connectivitiy Setup does not set Passive mode after all mapping attempts are unsuccessful (DC++ 0.86x)

2016-10-02 Thread poy
Fixed in DC++ 0.862. ** Changed in: dcplusplus Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to DC++. https://bugs.launchpad.net/bugs/1629574 Title: Automatic Connectivitiy Setup does not set

[Linuxdcpp-team] [Bug 1629574] Re: Automatic Connectivitiy Setup does not set Passive mode after all mapping attempts are unsuccessful (DC++ 0.86x)

2016-10-02 Thread poy
just tried by simulating an error during port mapping; it does correctly select passive mode with the fix: [18:29] Connectivity (IPv4): Determining the best connectivity settings... [18:29] Connectivity (IPv4): Local network with possible NAT detected, trying to map the ports... [18:29] Connectiv

[Linuxdcpp-team] [Bug 1629574] Re: Automatic Connectivitiy Setup does not set Passive mode after all mapping attempts are unsuccessful (DC++ 0.86x)

2016-10-01 Thread poy
the fix looks good; must have been lost during refactoring... -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to DC++. https://bugs.launchpad.net/bugs/1629574 Title: Automatic Connectivitiy Setup does not set Passive mode after all mappi

[Linuxdcpp-team] [Bug 1626741] Re: External / WAN IP address seems not to be saved

2016-09-26 Thread poy
Fixed in DC++ 0.861. ** Changed in: dcplusplus Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to DC++. https://bugs.launchpad.net/bugs/1626741 Title: External / WAN IP address seems not to be

[Linuxdcpp-team] [Bug 1626741] Re: External / WAN IP address seems not to be saved

2016-09-25 Thread poy
thanks for the report Jo - fixed for the next version, to be released very soon. commit 088f109aab8b ** Changed in: dcplusplus Status: Confirmed => Fix Committed -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to DC++. https://bugs.l

[Linuxdcpp-team] [Bug 1502650] Re: DC++ 0.851 - Arbitrary code execution

2016-09-14 Thread poy
Fixed in DC++ 0.860. ** Changed in: dcplusplus Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to DC++. https://bugs.launchpad.net/bugs/1502650 Title: DC++ 0.851 - Arbitrary code execution Sta

[Linuxdcpp-team] [Bug 1484807] Re: Encryption problems in DC++ 0.851 when connecting to a LUADCH hub

2016-09-14 Thread poy
Fixed in DC++ 0.860. ** Changed in: dcplusplus Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to DC++. https://bugs.launchpad.net/bugs/1484807 Title: Encryption problems in DC++ 0.851 when con

[Linuxdcpp-team] [Bug 264208] Re: Limit the number of possibly opened slots when using "Automatically open extra slot if speed is below" option

2016-09-14 Thread poy
Fixed in DC++ 0.860. ** Changed in: dcplusplus Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to DC++. https://bugs.launchpad.net/bugs/264208 Title: Limit the number of possibly opened slots w

[Linuxdcpp-team] [Bug 1262319] Re: Search only on encrypted hubs/ADC(S) hubs

2016-09-14 Thread poy
Fixed in DC++ 0.860. ** Changed in: dcplusplus Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to DC++. https://bugs.launchpad.net/bugs/1262319 Title: Search only on encrypted hubs/ADC(S) hubs

[Linuxdcpp-team] [Bug 236056] Re: Can't search from Notepad

2016-09-14 Thread poy
Fixed in DC++ 0.860. ** Changed in: dcplusplus Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to DC++. https://bugs.launchpad.net/bugs/236056 Title: Can't search from Notepad Status in DC++:

[Linuxdcpp-team] [Bug 1543595] Re: Issues with encrypted transfers

2016-09-14 Thread poy
Fixed in DC++ 0.860. ** Changed in: dcplusplus Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to DC++. https://bugs.launchpad.net/bugs/1543595 Title: Issues with encrypted transfers Status in

[Linuxdcpp-team] [Bug 1494809] Re: DC++ does not update contents of chat on tab change (Win 10)

2016-09-14 Thread poy
Fixed in DC++ 0.860. ** Changed in: dcplusplus Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to DC++. https://bugs.launchpad.net/bugs/1494809 Title: DC++ does not update contents of chat on t

[Linuxdcpp-team] [Bug 1306825] Re: Hide hubs from the hublist which the user is already connected to

2016-09-14 Thread poy
Fixed in DC++ 0.860. ** Changed in: dcplusplus Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to DC++. https://bugs.launchpad.net/bugs/1306825 Title: Hide hubs from the hublist which the user

[Linuxdcpp-team] [Bug 1451223] Re: Support for HTTP file retrieval in DC Plugin

2016-09-14 Thread poy
Fixed in DC++ 0.860. ** Changed in: dcplusplus Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to DC++. https://bugs.launchpad.net/bugs/1451223 Title: Support for HTTP file retrieval in DC Plug

[Linuxdcpp-team] [Bug 1353402] Re: Autostart DC++ when Windows starts

2016-09-14 Thread poy
Fixed in DC++ 0.860. ** Changed in: dcplusplus Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to DC++. https://bugs.launchpad.net/bugs/1353402 Title: Autostart DC++ when Windows starts Status

[Linuxdcpp-team] [Bug 1483036] Re: Add toolbar/context menu to transferview for common operations

2016-09-14 Thread poy
Fixed in DC++ 0.860. ** Changed in: dcplusplus Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to DC++. https://bugs.launchpad.net/bugs/1483036 Title: Add toolbar/context menu to transferview f

[Linuxdcpp-team] [Bug 1506210] Re: Decision on how to move forward with IPv6 connectivity setup

2016-09-14 Thread poy
Fixed in DC++ 0.860. ** Changed in: dcplusplus Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to DC++. https://bugs.launchpad.net/bugs/1506210 Title: Decision on how to move forward with IPv6

[Linuxdcpp-team] [Bug 710249] Re: Displaymassage of right click popup is overlapped by OK button

2016-09-14 Thread poy
Fixed in DC++ 0.860. ** Changed in: dcplusplus Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to DC++. https://bugs.launchpad.net/bugs/710249 Title: Displaymassage of right click popup is over

[Linuxdcpp-team] [Bug 1265578] Re: Add toolbar to download queue for common operations

2016-09-14 Thread poy
Fixed in DC++ 0.860. ** Changed in: dcplusplus Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to DC++. https://bugs.launchpad.net/bugs/1265578 Title: Add toolbar to download queue for common o

[Linuxdcpp-team] [Bug 1411974] Re: Distro: Files not excluded from zip archives

2016-09-14 Thread poy
Fixed in DC++ 0.860. ** Changed in: dcplusplus Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to DC++. https://bugs.launchpad.net/bugs/1411974 Title: Distro: Files not excluded from zip archiv

[Linuxdcpp-team] [Bug 1436105] Re: KEYP checks not in effect with default settings

2016-09-14 Thread poy
Fixed in DC++ 0.860. ** Changed in: dcplusplus Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to DC++. https://bugs.launchpad.net/bugs/1436105 Title: KEYP checks not in effect with default set

[Linuxdcpp-team] [Bug 1241606] Re: Chat does not scroll properly when more lines than fit on screen occurs

2016-09-14 Thread poy
Fixed in DC++ 0.860. ** Changed in: dcplusplus Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to DC++. https://bugs.launchpad.net/bugs/1241606 Title: Chat does not scroll properly when more li

[Linuxdcpp-team] [Bug 1473791] Re: Support encoding in NMDC hubs

2016-09-14 Thread poy
Fixed in DC++ 0.860. ** Changed in: dcplusplus Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to DC++. https://bugs.launchpad.net/bugs/1473791 Title: Support encoding in NMDC hubs Status in D

[Linuxdcpp-team] [Bug 1620100] Re: NSIS 3

2016-09-14 Thread poy
Fixed in DC++ 0.860. ** Changed in: dcplusplus Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to DC++. https://bugs.launchpad.net/bugs/1620100 Title: NSIS 3 Status in DC++: Fix Released Bu

[Linuxdcpp-team] [Bug 1435007] Re: The "/clear" command scrolls back to the top

2016-09-14 Thread poy
Fixed in DC++ 0.860. ** Changed in: dcplusplus Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to DC++. https://bugs.launchpad.net/bugs/1435007 Title: The "/clear" command scrolls back to the t

[Linuxdcpp-team] [Bug 1516181] Re: disabled keyprint check for hubs

2016-09-14 Thread poy
Fixed in DC++ 0.860. ** Changed in: dcplusplus Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to DC++. https://bugs.launchpad.net/bugs/1516181 Title: disabled keyprint check for hubs Status i

[Linuxdcpp-team] [Bug 1506210] Re: Decision on how to move forward with IPv6 connectivity setup

2016-09-14 Thread poy
** Changed in: dcplusplus Status: In Progress => Fix Committed -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to DC++. https://bugs.launchpad.net/bugs/1506210 Title: Decision on how to move forward with IPv6 connectivity setup Sta

[Linuxdcpp-team] [Bug 1620100] Re: NSIS 3

2016-09-14 Thread poy
that is annoying but not terribly important; adapted the script to be clearer about missing languages and created bug #1623625. -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to DC++. https://bugs.launchpad.net/bugs/1620100 Title: NSIS 3

[Linuxdcpp-team] [Bug 1623625] [NEW] Installer: Unhandled translations

2016-09-14 Thread poy
Public bug reported: While running "scons distro=1": NSIS base language file English (United Kingdom).nlf not found NSIS base language file Hindi.nlf not found Hindi used to be present in language files of Unicode NSIS 2 , but is not available in NSI

[Linuxdcpp-team] [Bug 1411974] Re: Distro: Files not excluded from zip archives

2016-09-13 Thread poy
rev 2b07e6718452. ** Changed in: dcplusplus Status: Confirmed => Fix Committed -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to DC++. https://bugs.launchpad.net/bugs/1411974 Title: Distro: Files not excluded from zip archives St

[Linuxdcpp-team] [Bug 1620100] Re: NSIS 3

2016-09-05 Thread poy
ouch! yeah, better be up-to-date then... eMTee, I notice you don't set the "unicode" flag to "true" in the commit? -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to DC++. https

[Linuxdcpp-team] [Bug 1620106] Re: Upgrade to OpenSSL 1.1.0

2016-09-04 Thread poy
I would prefer caution as well, especially as: - the build process has changed quite a bit; - there are API changes; - threading management has evolved - the method used is great in general but scary to use in mingw, where it is quite experimental (though it can be disabled): *) OpenSSL now us

[Linuxdcpp-team] [Bug 1620100] [NEW] NSIS 3

2016-09-04 Thread poy
Public bug reported: & : NSIS 3 has been released, with Unicode support -> Migrate to NSIS 3 f

[Linuxdcpp-team] [Bug 333599] Re: Shut-down when downloads finished

2016-09-04 Thread poy
*** This bug is a duplicate of bug 337672 *** https://bugs.launchpad.net/bugs/337672 ** This bug has been marked a duplicate of bug 337672 [Wishlist] Automatic shutdown after all uploads/downloads complete -- You received this bug notification because you are a member of Dcplusplus-team,

[Linuxdcpp-team] [Bug 1315472] Re: Use tabs instead of dialogs for End of XP support message and other announcements

2016-09-04 Thread poy
hello, the next version is around the corner and it will drop support for Windows XP. the 0.840 branch mentioned in comment #10 is no longer maintained and does not contain the latest security fixes. -- You received this bug notification because you are a member of Dcplusplus-team, which is sub

[Linuxdcpp-team] [Bug 1238966] Re: DC++ crashes randomly, sometimes at startup

2016-09-04 Thread poy
hi, sorry for the belated reply. the next version is around the corner; there have been several stability fixes since version 0.831. this is to be checked again once the next version is out. ** Changed in: dcplusplus Status: Confirmed => Incomplete -- You received this bug notification

[Linuxdcpp-team] [Bug 914079] Re: Ability to set Tabs text of hubs

2016-09-04 Thread poy
3) WindowManager does save the title of the whole tab, but only so it can be shown in the recent window list. I would add a param in HubFrame::getWindowParams / HubFrame::parseWindowParams that would save / load the custom tab text. 4) We need a way to clear the custom tab text - maybe use a Param

[Linuxdcpp-team] [Bug 1506210] Re: Decision on how to move forward with IPv6 connectivity setup

2016-09-04 Thread poy
thanks maksis, I've brought some of your changes back into DC++. it looks to me the version we have of your connectivity improvements is not the latest, so I'm slighly worried we may be missing other stuff... in particular, I notice your getBindAdapters / getDisplayAdapters is not the same as our

[Linuxdcpp-team] [Bug 1473791] Re: Support encoding in NMDC hubs

2016-08-30 Thread poy
by default it selects the current Windows encoding, which is what would happen without any setting. I see no issue with that logic. -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to DC++. https://bugs.launchpad.net/bugs/1473791 Title: Sup

[Linuxdcpp-team] [Bug 1506210] Re: Decision on how to move forward with IPv6 connectivity setup

2016-08-30 Thread poy
thanks klondike, will keep PCP in mind! no worries about NAT-PMP; only UPnP is used for IPv6. as maksis explained, it's available in our lib so there's little effort in adding that support. :) (assuming the lib does work - I couldn't test with my ISP-provided box.) thanks for the Util::isPrivate

[Linuxdcpp-team] [Bug 1506210] Re: Decision on how to move forward with IPv6 connectivity setup

2016-08-29 Thread poy
I wanted to prevent 2 port mappers from running in parallel, so I restored the MappingManager singleton and implemented IPv6 port mapping slightly differently; then one change led to another and before I knew it I had rewritten quite a good chunk of the connectivity / port mapping code. :P I have

[Linuxdcpp-team] [Bug 1506210] Re: Decision on how to move forward with IPv6 connectivity setup

2016-08-24 Thread poy
good. the only regression I am wary off is about IPv6 being disabled by default; I hope this version does not inadvertently disable IPv6 connections that previously used to work "off the shelf". -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed

[Linuxdcpp-team] [Bug 1506210] Re: Decision on how to move forward with IPv6 connectivity setup

2016-08-23 Thread poy
I have a fix for the last issue (port settings not honored after disabling auto-detection), that hopefully does not introduce any regression. The code in question is quite convoluted; hard to be confident about a change in there... Please test. The other issues are in my opinion "acceptable" for n

[Linuxdcpp-team] [Bug 1435007] Re: The "/clear" command scrolls back to the top

2016-08-21 Thread poy
diregard comment #2; I was confusing the total line count with the amount of lines per page... I have fiddled with the code though to add a "scroll holder" tool. ;) -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to DC++. https://bugs.launch

[Linuxdcpp-team] [Bug 1562479] Re: names and password

2016-07-07 Thread poy
I just tried; using a dollar sign in the nick works just fine in DC++ when connecting to an ADC hub. :) -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to DC++. https://bugs.launchpad.net/bugs/1562479 Title: names and password Status in D

[Linuxdcpp-team] [Bug 1553808] [NEW] Improve texts.lua

2016-03-06 Thread poy
Public bug reported: Improve the texts.lua script (plugins/Script/examples/texts.lua) following the 2 TODOs mentioned in it: -- TODO Command to reload texts. Currently texts are loaded when the hub starts; provide a command (registered under "acces.commands") to re-read texts. -- TODO Allow cus

[Linuxdcpp-team] [Bug 1553806] Re: Script to remove IPs

2016-03-06 Thread poy
First try - unable to test as the event handler is never called on INF. ** Attachment added: "restrict-ips.lua" https://bugs.launchpad.net/adchpp/+bug/1553806/+attachment/4590908/+files/restrict-ips.lua -- You received this bug notification because you are a member of Dcplusplus-team, which

[Linuxdcpp-team] [Bug 1553806] [NEW] Script to remove IPs

2016-03-06 Thread poy
Public bug reported: See further for the start of a script meant to remove IPs. It does not work; TODO: - the "send" signal does not catch INFs sent to users when they connect. - remove IPs from "+info" too. ** Affects: adchpp Importance: Undecided Status: In Progress ** Tags: ip

[Linuxdcpp-team] [Bug 1516181] Re: disabled keyprint check for hubs

2016-01-10 Thread poy
thanks Konstantin; applied in rev 612a56de0d0c. ** Changed in: dcplusplus Status: In Progress => Fix Committed -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to DC++. https://bugs.launchpad.net/bugs/1516181 Title: disabled keyprin

[Linuxdcpp-team] [Bug 1436105] Re: KEYP checks not in effect with default settings

2016-01-10 Thread poy
applied with minor changes (rev 0f3239d2f56c). ** Changed in: dcplusplus Status: In Progress => Fix Committed -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to DC++. https://bugs.launchpad.net/bugs/1436105 Title: KEYP checks not i

[Linuxdcpp-team] [Bug 804559] Re: portable semaphore implementation

2016-01-03 Thread poy
the patch submitted by Gennady has not been applied in the version of boost currently in the DC++ repo. at a first glance at the file in question, this might affect Windows builds (Windows-specific stuff is within an elif-guar

[Linuxdcpp-team] [Bug 1506210] Re: Decision on how to move forward with IPv6 connectivity setup

2015-10-15 Thread poy
Personally, I would attempt to keep the noob / experienced distinction between automatic and manual connectivity settings. That means: - Only 1 "magic" check-box in automatic settings, that does both IPv4 & IPv6 detections (or only the IPv4 one while the IPv6 one is not yet polished / known not t

[Linuxdcpp-team] [Bug 1502650] Re: DC++ 0.851 - Arbitrary code execution

2015-10-07 Thread poy
great! just one thing: now that we have an std::function, the "!= nullptr" check can (or even should) be removed. -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to DC++. https://bugs.launchpad.net/bugs/1502650 Title: DC++ 0.851 - Arbitra

[Linuxdcpp-team] [Bug 710249] Re: Displaymassage of right click popup is overlapped by OK button

2015-10-07 Thread poy
surely you can factor it out abit? :) can you check the tooltip's handle is actually destroyed? (ie, no GUI handle leak?) -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to DC++. https://bugs.launchpad.net/bugs/710249 Title: Displaymassag

[Linuxdcpp-team] [Bug 1502650] Re: DC++ 0.851 - Arbitrary code execution

2015-10-06 Thread poy
looking good. can you change the new function pointer to an std::function? that's what dwt uses in other places. also (if it's not too much work), maybe look into slapping a StringListDlg over the white list field. ;) -- You received this bug notification because you are a member of Dcplusplus-

[Linuxdcpp-team] [Bug 1306825] Re: Hide hubs from the hublist which the user is already connected to

2015-10-05 Thread poy
great. if I could nitpick: - having to assign a "-1" before calling the new function is a bit ugly... maybe that function should do the assignment? - does "resort" always have to be called? iirc, there are other places where we only resort when the data that has changed is actually being sorted o

[Linuxdcpp-team] [Bug 1502650] Re: DC++ 0.851 - Arbitrary code execution

2015-10-05 Thread poy
nice. can you also add a setting to disable it? or even better, allow the whitelist to be user-editable... -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to DC++. https://bugs.launchpad.net/bugs/1502650 Title: DC++ 0.851 - Arbitrary code

[Linuxdcpp-team] [Bug 1502650] Re: DC++ 0.851 - Arbitrary code execution

2015-10-04 Thread poy
you got the wrong link - that one is about HTML embedded in a field of certificates. ;) what I wrote above is my opinion of this after a quick research - I would like to know what others in the DC++ team think. -- You received this bug notification because you are a member of Dcplusplus-team, wh

[Linuxdcpp-team] [Bug 1502650] Re: DC++ 0.851 - Arbitrary code execution

2015-10-04 Thread poy
from what I understand by reading , this is well mitigated by the "UNC Hardened Access" feature that has been introduced. "Even 3rd party applications and services can take advantage of this new f

[Linuxdcpp-team] [Bug 264208] Re: Limit the number of possibly opened slots when using "Automatically open extra slot if speed is below" option

2015-10-03 Thread poy
looks good to me. -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to DC++. https://bugs.launchpad.net/bugs/264208 Title: Limit the number of possibly opened slots when using "Automatically open extra slot if speed is below" option Statu

[Linuxdcpp-team] [Bug 710249] Re: Displaymassage of right click popup is overlapped by OK button

2015-10-03 Thread poy
well, at least there is no glitch / text overlap. :) I agree it's annoying, but how do you propose we solve this? maybe add ellipsis at the end of the text and show a tooltip when hovering it? -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed

[Linuxdcpp-team] [Bug 1473791] Re: Support encoding in NMDC hubs

2015-10-03 Thread poy
seems cool. can you make the UI part hidden when editing an ADC hub? or rather, the other way around - only show it when editing an NMDC hub? -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to DC++. https://bugs.launchpad.net/bugs/1473791 Ti

[Linuxdcpp-team] [Bug 1484807] Re: encrypt problems in 0.851

2015-09-12 Thread poy
this thread is no longer private. could luadch devs write their thoughts here? it would make much more sense to have that discussion recorded on a bug tracker that lost in a DC chat. ** Information type changed from Private Security to Public -- You received this bug notification because you ar

[Linuxdcpp-team] [Bug 1494809] Re: DC++ does not update contents of chat on tab change (Win 10)

2015-09-12 Thread poy
hmm, i'm surprised taskbar thumbnails could cause this... could you disable them by adding a "return;" at the start of Taskbar::initTaskbar in dwt/src/Taskbar.cpp? -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to DC++. https://bugs.launchp

  1   2   3   4   5   6   7   8   9   10   >