[Linuxdcpp-team] [Bug 1308290] Re: Require TLS 1.2 connections for ADCS

2014-04-15 Thread cologic
What would that accomplish? Downgrade attacks are bad and the point is to enable this unconditionally. Part of the calculation of the timing of this patch is that it's early enough in the cycle (I waited until just after 0.842 became stable) that if this approach proves too aggressive, it can be ad

[Linuxdcpp-team] [Bug 1308290] Re: Require TLS 1.2 connections for ADCS

2014-04-15 Thread Francisco Blas Izquierdo Riera (klondike)
Something that came just out of my head, couldn't we use the URI parameters as we do with the kp to implement this restriction? -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to DC++. https://bugs.launchpad.net/bugs/1308290 Title: Requir

[Linuxdcpp-team] [Bug 1308290] [NEW] Require TLS 1.2 connections for ADCS

2014-04-15 Thread cologic
Public bug reported: The same patch attached can be found at http://pastie.org/pastes/8760328 from two months ago. It's the resolution to https://dcpp.wordpress.com/2013/09/20/beast-crime-breach-and-lucky-13 -assessing-tls-in-adcs/ This is meant as a trial patch: easy to add, and if it causes irr

[Linuxdcpp-team] [Bug 1297688] Re: Moving away from Win API to Multiplatform

2014-04-15 Thread cologic
While GTK might have been a good path forward when arne suggested it, it's worth re-evaluating whether GTK+ should be the default choice of backend. Since arne suggested that, Wireshark [1], Linux Torvald's diving application Subsurface [2, 3], and the desktop environment LXDE [4] have all either s

[Linuxdcpp-team] [Bug 1297688] Re: Moving away from Win API to Multiplatform

2014-04-15 Thread Fredrik Ullner
The alternative would be to make sure that plugins would get *everything*. Then, you could build plugins for each specific task (or have a main "DC++ Windows UI" plugin), such as changing the UI for a particular item (say, the search frame) that can specialize in e.g. operating system. -- You rec

[Linuxdcpp-team] [Bug 1297688] Re: Moving away from Win API to Multiplatform

2014-04-15 Thread poy
on the dcpp lib part, my first task a few months ago was to make it compilable using scons; "scons test=1" correctly builds the lib and runs tests. instead of if-guarding too much, i prefer a wait&see approach here as Windows is rapidly getting up to par with Linux in terms of "advanced" C++ supp

[Linuxdcpp-team] [Bug 1307978] Re: Subtract list function broken most of the time

2014-04-15 Thread poy
indeed. i have added you to the dev list at sf.net; feel free to push the change. :) -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to DC++. https://bugs.launchpad.net/bugs/1307978 Title: Subtract list function broken most of the time S

[Linuxdcpp-team] [Bug 1297688] Re: Moving away from Win API to Multiplatform

2014-04-15 Thread Crise
Poy: out of curiosity how did you think about pursuing this? Port DWT or replace it? Personally I think if you intend to seriously pursue this, you should start by eliminating #ifdefs in dcpp lib, use separate cpp files for platform specific code and share only headers. This would limit preprocess

[Linuxdcpp-team] [Bug 1307978] [NEW] Subtract list function broken most of the time

2014-04-15 Thread Crise
Public bug reported: Subtract list functionality is broken, most of the time anyways returns only empty lists. If you look at the line here: https://sourceforge.net/p/dcplusplus/code/ci/813af952cd51534ca8f530b90c5f36fcfc848427/tree/dcpp/DirectoryListing.cpp#l460 It should be AND not OR as far as

[Linuxdcpp-team] [Bug 1307313] Re: ADLSearch can no longer show different files with the same name

2014-04-15 Thread Crise
To my knowledge it was changed to behave like this with the recent share changes (ie. when virtual names became a thing, or the changes following that to filelist handling). -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to DC++. https://bug