Public bug reported:
Subtract list functionality is broken, most of the time anyways returns
only empty lists. If you look at the line here:
https://sourceforge.net/p/dcplusplus/code/ci/813af952cd51534ca8f530b90c5f36fcfc848427/tree/dcpp/DirectoryListing.cpp#l460
It should be AND not OR as far as I can see, because the recursive call
to filterList above it is likely to clear files, and when it does not
then if the directory has no sub directories (which it does not if they
have no new files) it gets removed anyways. So you are left with an
empty set in most cases, if not always because you will eventually
always hit a directory where one of the conditions is true.
** Affects: dcplusplus
Importance: Undecided
Status: New
--
You received this bug notification because you are a member of
Dcplusplus-team, which is subscribed to DC++.
https://bugs.launchpad.net/bugs/1307978
Title:
Subtract list function broken most of the time
Status in DC++:
New
Bug description:
Subtract list functionality is broken, most of the time anyways
returns only empty lists. If you look at the line here:
https://sourceforge.net/p/dcplusplus/code/ci/813af952cd51534ca8f530b90c5f36fcfc848427/tree/dcpp/DirectoryListing.cpp#l460
It should be AND not OR as far as I can see, because the recursive
call to filterList above it is likely to clear files, and when it does
not then if the directory has no sub directories (which it does not if
they have no new files) it gets removed anyways. So you are left with
an empty set in most cases, if not always because you will eventually
always hit a directory where one of the conditions is true.
To manage notifications about this bug go to:
https://bugs.launchpad.net/dcplusplus/+bug/1307978/+subscriptions
_______________________________________________
Mailing list: https://launchpad.net/~linuxdcpp-team
Post to : linuxdcpp-team@lists.launchpad.net
Unsubscribe : https://launchpad.net/~linuxdcpp-team
More help : https://help.launchpad.net/ListHelp
