[PATCH] arc: remove num-slots from arc platforms

2017-07-05 Thread Shawn Lin
dwmmc driver deprecated num-slots and plan to get rid of it finally. Just move a step to cleanup it from DT. Cc: Jaehoon Chung Signed-off-by: Shawn Lin --- arch/arc/boot/dts/axs10x_mb.dtsi | 1 - arch/arc/boot/dts/vdk_axs10x_mb.dtsi | 1 - 2 files changed, 2 deletions(-) diff --git a

Re: [PATCH] arc: remove num-slots from arc platforms

2017-07-06 Thread Shawn Lin
Hi Alexey, On 2017/7/6 19:33, Alexey Brodkin wrote: Hi Jaehoon, On Thu, 2017-07-06 at 13:17 +0900, Jaehoon Chung wrote: On 07/05/ Right, that's why doesn't use the multiple slot. Company hopes to make the product that costumer is satisfied. Performance is one of important things... For saving

Re: [PATCH] arc: remove num-slots from arc platforms

2017-07-18 Thread Shawn Lin
Hi Vineet, On 2017/7/8 6:35, Vineet Gupta wrote: On 07/07/2017 01:13 AM, Alexey Brodkin wrote: Hi Shawn, On Wed, 2017-07-05 at 15:10 +0800, Shawn Lin wrote: dwmmc driver deprecated num-slots and plan to get rid of it finally. Just move a step to cleanup it from DT. Cc: Jaehoon Chung Signed

Re: [PATCH v2] mmc: dw_mmc: Fix the DTO timeout overflow calculation for 32-bit systems

2018-02-22 Thread Shawn Lin
ld be improved a bit: Fixes: 9d9491a7da2a ("mmc: dw_mmc: Fix the DTO timeout calculation") Cc: Otherwise, Reviewed-by: Shawn Lin BTW, would you mind cooking another patch for fixing cto_ms case? --- Changes since v1: -uint64_t switched to u64 -changed commit message drivers/mmc

Re: [PATCH v2] mmc: dw_mmc: Fix the DTO timeout overflow calculation for 32-bit systems

2018-02-22 Thread Shawn Lin
On 2018/2/23 0:03, Alexey Brodkin wrote: Hi Shawn, On Thu, 2018-02-22 at 23:28 +0800, Shawn Lin wrote: [snip] Stack Trace: arc_unwind_core.constprop.1+0xd0/0xf4 dump_stack+0x68/0x80 warn_slowpath_null+0x4e/0xec sg_miter_next+0x28/0x20c dw_mci_read_data_pio+0x44/0x190 dw_mmc

Re: mmc: dw_mmc: DRTO interrupt cause driver switch to PIO mode

2018-03-05 Thread Shawn Lin
On 2018/3/1 0:11, Evgeniy Didin wrote: Hello everyone, We have made some research of how driver behaves in case when changes [1] are not applied. Here in [2] was metioned that while transfering data after interrupt has happend driver went to PIO mode, that is not expected. Here is log: | Run

Re: [PATCH 1/2 v3] mmc: dw_mmc: Fix the DTO timeout overflow calculation for 32-bit systems

2018-03-05 Thread Shawn Lin
Tested-by: Vineet Gupta Fixes: ARC STAR 9001306872 HSDK, sdio: board crashes when copying big files Signed-off-by: Evgeniy Didin CC: Alexey Brodkin CC: Eugeniy Paltsev CC: Douglas Anderson CC: Ulf Hansson CC: linux-ker...@vger.kernel.org CC: linux-snps-arc@lists.infradead.org Cc: # 9d9

Re: [PATCH v4] mmc: dw_mmc: Fix the DTO/CTO timeout overflow calculation for 32-bit systems

2018-03-05 Thread Shawn Lin
. The broken timeout calculations leads to unexpected ETIMEDOUT errors and causes stacktrace splat (such as below) during normal data exchange with SD-card. Reviewed-by: Shawn Lin | Running : 4M-check-reassembly-tcp-cmykw2-rotatew2.out -v0 -w1 | - Info: Finished target initialization. |

Re: [PATCH 1/2 v3] mmc: dw_mmc: Fix the DTO timeout overflow calculation for 32-bit systems

2018-03-05 Thread Shawn Lin
#define DIV_ROUND_DOWN_ULL(ll, d) \ ({ unsigned long long _tmp = (ll); do_div(_tmp, d); _tmp; }) #define DIV_ROUND_UP_ULL(ll, d)    DIV_ROUND_DOWN_ULL((ll) + (d) - 1, (d)) It uses intermediate unsigned long long _tmp for your "multiply", namely MSEC_PER_SEC * drto_clks * drto_div,