Tested-by: Vineet Gupta <vineet.gup...@synopsys.com>
Fixes: ARC STAR 9001306872 HSDK, sdio: board crashes when copying big files

Signed-off-by: Evgeniy Didin <evgeniy.di...@synopsys.com>

CC: Alexey Brodkin <abrod...@synopsys.com>
CC: Eugeniy Paltsev <palt...@synopsys.com>
CC: Douglas Anderson <diand...@chromium.org>
CC: Ulf Hansson <ulf.hans...@linaro.org>
CC: linux-ker...@vger.kernel.org
CC: linux-snps-arc@lists.infradead.org
Cc: <sta...@vger.kernel.org> #  9d9491a7da2a mmc: dw_mmc: Fix the DTO timeout 
calculation

As I said, the correct tag may be:

Reported-by: Vineet Gupta <vineet.gup...@synopsys.com> # ARC STAR 9001306872 HSDK, sdio: board crashes when copying big files
Tested-by: Vineet Gupta <vineet.gup...@synopsys.com>
Fixes: 9d9491a7da2a ("mmc: dw_mmc: Fix the DTO timeout calculation")
Cc: <sta...@vger.kernel.org>
Signed-off-by: Evgeniy Didin <evgeniy.di...@synopsys.com>
...
...


---
Nothing changed since v2.
  drivers/mmc/host/dw_mmc.c | 3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)


-       drto_ms = DIV_ROUND_UP(MSEC_PER_SEC * drto_clks * drto_div,
+
+       drto_ms = DIV_ROUND_UP((u64)MSEC_PER_SEC * drto_clks * drto_div,
                               host->bus_hz);

Hmm?

#define DIV_ROUND_DOWN_ULL(ll, d) \
        ({ unsigned long long _tmp = (ll); do_div(_tmp, d); _tmp; })

#define DIV_ROUND_UP_ULL(ll, d)         DIV_ROUND_DOWN_ULL((ll) + (d) - 1, (d))


It uses intermediate unsigned long long _tmp for your "multiply", namely
MSEC_PER_SEC * drto_clks * drto_div, which could solves the problem.
So I don't see why DIV_ROUND_UP_ULL can't work for you?


        /* add a bit spare time */



_______________________________________________
linux-snps-arc mailing list
linux-snps-arc@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-snps-arc

Reply via email to