Re: [PATCH 3/6] ARC: mm: TLB Miss optim: avoid re-reading ECR

2019-09-17 Thread Vineet Gupta
On 9/16/19 4:36 PM, Alexey Brodkin wrote: >> >> ; >> ; UPDATE_PTE: Let Linux VM know that page was accessed/dirty > > I'd suggest to put a BOLD comment here saying that we rely on previously > set condition flag so that whoe

RE: [PATCH 3/6] ARC: mm: TLB Miss optim: avoid re-reading ECR

2019-09-16 Thread Alexey Brodkin
Hi Vineet, > -Original Message- > From: Vineet Gupta > Sent: Monday, September 16, 2019 2:32 PM > To: linux-snps-arc@lists.infradead.org > Cc: Alexey Brodkin ; Vineet Gupta > Subject: [PATCH 3/6] ARC: mm: TLB Miss optim: avoid re-reading ECR > > For setting

[PATCH 3/6] ARC: mm: TLB Miss optim: avoid re-reading ECR

2019-09-16 Thread Vineet Gupta
For setting PTE Dirty bit, reuse the prior test for ST miss. No need to reload ECR and test for ST cause code as the prev condition code is still valid (uncloberred) Signed-off-by: Vineet Gupta --- arch/arc/mm/tlbex.S | 2 -- 1 file changed, 2 deletions(-) diff --git a/arch/arc/mm/tlbex.S b/ar