On 9/16/19 4:36 PM, Alexey Brodkin wrote: >> >> ;---------------------------------------------------------------- >> ; UPDATE_PTE: Let Linux VM know that page was accessed/dirty > > I'd suggest to put a BOLD comment here saying that we rely on previously > set condition flag so that whoever reads or (even worse) modifies that or > previous code keeps in mind that we shouldn't clobber a particular flag.
The flag setting code is only a few lines prior. It would be messy to annotate for flag checking instruction where the flags are clobbered. This is low level assembly code - not for faint hearted. _______________________________________________ linux-snps-arc mailing list linux-snps-arc@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-snps-arc
