Re: [PATCH] ARC: bpf_jit_arcv2: Remove redundant condition check

2024-11-12 Thread Hardevsinh Palaniya
Hi Vadim , Shahab Thanks for the feedback  > > The original code is obviously optimized out, but the intention, I > > believe, was to check if the jump is conditional or not. > > So the proper fix should change the code to check cond: > > > > - if (ARC_CC_AL) > > + if (cond == ARC_CC_AL) Okay 

Re: [PATCH] ARC: bpf_jit_arcv2: Remove redundant condition check

2024-11-12 Thread Shahab Vahedi
Vadim Fedorenko wrote: > The original code is obviously optimized out, but the intention, I > believe, was to check if the jump is conditional or not. > So the proper fix should change the code to check cond: > > - if (ARC_CC_AL) > + if (cond == ARC_CC_AL) That is absolutely correct. If a new p