Hi Vadim , Shahab Thanks for the feedback
> > The original code is obviously optimized out, but the intention, I > > believe, was to check if the jump is conditional or not. > > So the proper fix should change the code to check cond: > > > > - if (ARC_CC_AL) > > + if (cond == ARC_CC_AL) Okay > That is absolutely correct. If a new patch is not submitted soon > I'll try to fix it myself. if you are okay with that then I can proceed by submitting version 2 of the patch with the proposed changes included Best Regards, Hardev ________________________________________ From: Shahab Vahedi <list+...@vahedi.org> Sent: Wednesday, November 13, 2024 7:41 AM To: Vadim Fedorenko <vadim.fedore...@linux.dev>; Hardevsinh Palaniya <hardevsinh.palan...@siliconsignals.io>; a...@kernel.org <a...@kernel.org>; and...@kernel.org <and...@kernel.org> Cc: Daniel Borkmann <dan...@iogearbox.net>; Martin KaFai Lau <martin....@linux.dev>; Eduard Zingerman <eddy...@gmail.com>; Song Liu <s...@kernel.org>; Yonghong Song <yonghong.s...@linux.dev>; John Fastabend <john.fastab...@gmail.com>; KP Singh <kpsi...@kernel.org>; Stanislav Fomichev <s...@fomichev.me>; Hao Luo <hao...@google.com>; Jiri Olsa <jo...@kernel.org>; Vineet Gupta <vgu...@kernel.org>; b...@vger.kernel.org <b...@vger.kernel.org>; linux-snps-arc@lists.infradead.org <linux-snps-arc@lists.infradead.org>; linux-ker...@vger.kernel.org <linux-ker...@vger.kernel.org> Subject: Re: [PATCH] ARC: bpf_jit_arcv2: Remove redundant condition check CAUTION: This email originated from outside the organization. Do not click links or open attachments unless you recognize the sender and know the content is safe. Vadim Fedorenko wrote: > The original code is obviously optimized out, but the intention, I > believe, was to check if the jump is conditional or not. > So the proper fix should change the code to check cond: > > - if (ARC_CC_AL) > + if (cond == ARC_CC_AL) That is absolutely correct. If a new patch is not submitted soon I'll try to fix it myself. Cheers, Shahab _______________________________________________ linux-snps-arc mailing list linux-snps-arc@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-snps-arc
